Importing the same track at the same position in different albums, doesn't show up in UI after successful upload (#928) · Issues · funkwhale / funkwhale

Importing the same track at the same position in different albums, doesn't show up in UI after successful upload

Steps to reproduce

Upload first album
Upload a second album with a track sharing the same name, position and artist in both albums

What happens?

All uploads are successful, the track is missing in the second album.

What is expected?

All uploads are successful, the track is present in both albums.

Context

Funkwhale version(s) affected: 0.19.1

Picard screenshot for the two albums, the second track (Rise) is the one triggering this bug.

UI screenshot of the second album uploaded.

Musicbrainz page for GET9 and Ghost in the Shell: STAND ALONE COMPLEX O.S.T. 2

I noticed the GET9 tracsk aren't affected by this bug, they're basically identical too (same AcoustID, same name, same artist) but don't share the same track position in both albums. The missing track isn't marked skipped as duplicate during upload too, so I guess this bug is triggered in later deduplication logic?

<!--
Hi there! You are reporting a bug on this project, and we want to thank you!

If it's the first time you post here, please take a moment to read our Code of Conduct
(https://funkwhale.audio/code-of-conduct/) and ensure your issue respect our guidelines.

To ensure your bug report is as useful as possible, please try to stick
to the following structure. You can leave the parts text between `<!- ->`
markers untouched, they won't be displayed in your final message.

Please do not edit the following line, it's used for automatic classification
-->

## Steps to reproduce

1. Upload first album
2. Upload a second album with a track sharing the same name, position and artist in both albums

## What happens?

All uploads are successful, the track is missing in the second album.

## What is expected?

All uploads are successful, the track is present in both albums.

## Context

**Funkwhale version(s) affected**: 0.19.1

Picard screenshot for the two albums, the second track (Rise) is the one triggering this bug.

![2019-09-29-114724_632x417_scrot](/uploads/2bc91b745e8ee29c95c1e2cf10489928/2019-09-29-114724_632x417_scrot.png)

UI screenshot of the second album uploaded.

![2019-09-29-115005_876x308_scrot](/uploads/692ef0f1615240cb9a0699163062bd70/2019-09-29-115005_876x308_scrot.png)

Musicbrainz page for [GET9](https://musicbrainz.org/release/ee52508f-a668-469a-a8ce-db75477e0855?tport=8000) and [Ghost in the Shell: STAND ALONE COMPLEX O.S.T. 2](https://musicbrainz.org/release/ee52508f-a668-469a-a8ce-db75477e0855)