Non-Existing Content Return a 200 Response Code Instead of a 404
Steps to reproduce
- Visit a page that shouldn't exist on any Funkwhale instance. https://open.audio/invalid-file.php
- While the page correctly displays a "File Not Found" error, the response code is still 200.
What happens?
Response code logged (and returned to the user) is 200 (OK).
What is expected?
I expected the response code to be 404 (Not Found).
Context
I was pouring over some of my access logs and noticed that I can't report mass 404 errors to myself from Funkwhale because file-not-found pages return response code 200. I don't think this is expected, I would have expected non-existent files to return a 404 response code.
Funkwhale version(s) affected: 0.18.3
Note: I did test to see that this is still an issue on 0.19 using open.audio instance - file-not-found errors still report a 200.