Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Sign in / Register
  • funkwhale funkwhale
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Issues 406
    • Issues 406
    • List
    • Boards
    • Service Desk
    • Milestones
    • Iterations
    • Requirements
  • Merge requests 22
    • Merge requests 22
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
    • Test Cases
  • Deployments
    • Deployments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Container Registry
    • Infrastructure Registry
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Code review
    • Insights
    • Issue
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • funkwhalefunkwhale
  • funkwhalefunkwhale
  • Merge requests
  • !781

Model / settings for allow-listing

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Agate requested to merge 853-allow-listing-settings into develop Jun 11, 2019
  • Overview 9
  • Commits 5
  • Pipelines 6
  • Changes 8

(See #853 (closed) for context)

This MR adds:

  • Two dedicated admin settings to control if:
    • Allow-listing is enabled
    • The list of domains on the allow-list is public or not
  • A new allowed field in the Domain table, to control wether or not the domain is on the allow-list. We default to Null so mods of pods switching to allow-listing can quickly find out the list of domains they need to check , and batch allow/disallow those
  • Display of the allowed value for each domain in Django's admin
  • The corresponding allowed field for Domain resources in the API
  • Support for updating this field when you're a moderator

I know it may seem a lot, but the MR is actually quite small, and each commit match precisely one of the items listed above. I recommend reading the changes commit-by-commit ;)

Let me know if you have any question!

Edited Jun 17, 2019 by Agate
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: 853-allow-listing-settings