Skip to content

GitLab

  • Menu
Projects Groups Snippets
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • funkwhale funkwhale
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 384
    • Issues 384
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 16
    • Merge requests 16
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Monitor
    • Monitor
    • Incidents
  • Packages & Registries
    • Packages & Registries
    • Container Registry
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • funkwhale
  • funkwhalefunkwhale
  • Merge requests
  • !1619

Merged
Created Feb 06, 2022 by Ciarán Ainsworth@SporiffMaintainer

Resolve "No picture in embedded player"

  • Overview 0
  • Commits 3
  • Pipelines 6
  • Changes 2

Closes #1697 (closed)

This MR adds support for all cover sources in the embedded player. Currently, the embedded player only checks to see if the album associated with a track contains a cover, and returns the default cover if not. Many channels don't use albums or series (see this forum post). This MR proposes the following approach:

  1. Look for covers in the following locations in this order:
  • The track
  • The album/series
  • The artist
  1. Return the first cover object for the embedded player. Return the default cover if none are found.

Before

Screen_Shot_2022-02-06_at_17.49.20

After

Screen_Shot_2022-02-06_at_17.49.26

Edited Feb 06, 2022 by Ciarán Ainsworth
Assignee
Assign to
Reviewer
Request review from
Time tracking
Source branch: 1697-no-picture-in-embedded-player