Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Sign in / Register
  • funkwhale funkwhale
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Issues 379
    • Issues 379
    • List
    • Boards
    • Service Desk
    • Milestones
    • Iterations
    • Requirements
  • Merge requests 20
    • Merge requests 20
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
    • Test Cases
  • Deployments
    • Deployments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Container Registry
    • Infrastructure Registry
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Code review
    • Insights
    • Issue
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • funkwhalefunkwhale
  • funkwhalefunkwhale
  • Merge requests
  • !1041

Drop redundant display of album artist in track lists

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Tony Wasserka requested to merge neobrain/funkwhale:develop into develop Feb 26, 2020
  • Overview 1
  • Commits 1
  • Pipelines 1
  • Changes 1

See e.g. https://open.audio/library/albums/5875/ for an example affected by this change.

This is a partial revert of the frontend changes in 1458c084.

Reasons not displaying the album artist in the track list is preferrable:

  • The album artist is already printed at the top (Album containing N tracks, by Album Artist), so printing it in the track list is redundant
  • For collaboration tracks (X feat. Y), the displayed Artist entry will contain the album artist twice (e.g. "X / X feat. Y")
  • Printing only the track artists is consistent with the way songs are displayed in the playback queue

This Merge Request includes:

  • Tests (N/A)
  • A changelog fragment (N/A)
Edited Feb 28, 2020 by Agate
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: develop