funkwhale merge requestshttps://dev.funkwhale.audio/funkwhale/funkwhale/-/merge_requests2019-04-30T14:50:50Zhttps://dev.funkwhale.audio/funkwhale/funkwhale/-/merge_requests/741Fix #550: Show remaining storage space during import and prevent file upload...2019-04-30T14:50:50ZAgateFix #550: Show remaining storage space during import and prevent file upload...Fix #550: Show remaining storage space during import and prevent file upload if not enough space is remaining
Closes #550
![image](/uploads/4af25a75a82043e18d11bdc271e0dccc/image.png)Fix #550: Show remaining storage space during import and prevent file upload if not enough space is remaining
Closes #550
![image](/uploads/4af25a75a82043e18d11bdc271e0dccc/image.png)0.19https://dev.funkwhale.audio/funkwhale/funkwhale/-/merge_requests/740Fix #809: Added admin options to disable login for users, ensure related...2019-04-30T12:57:59ZAgateFix #809: Added admin options to disable login for users, ensure related...Fix #809: Added admin options to disable login for users, ensure related content is deleted when deleting a user account
Closes #809
- Added quick link to django admin when browsing user profile in moderation UI
- Delete related actor ...Fix #809: Added admin options to disable login for users, ensure related content is deleted when deleting a user account
Closes #809
- Added quick link to django admin when browsing user profile in moderation UI
- Delete related actor object when deleting user
- Added action to batch enable/disable login on multiple users0.19https://dev.funkwhale.audio/funkwhale/funkwhale/-/merge_requests/739Resolve "Federated tracks are downloaded too late and too slowly and don't pl...2022-06-26T19:06:12ZAgateResolve "Federated tracks are downloaded too late and too slowly and don't play the first time they come up in the queue"Closes #572
So, this:
- Moves the all the playing logic from our old `audio/Track` component to our `Player` component
- Preload the next track in queue, if any, after 15 seconds of playback on the current track, or if the current tra...Closes #572
So, this:
- Moves the all the playing logic from our old `audio/Track` component to our `Player` component
- Preload the next track in queue, if any, after 15 seconds of playback on the current track, or if the current track ends in less than 20s (whichever comes first)
- Fix a few unrelated glitches that were introduced recently (see first commits)
Incidentally, the changes in this MR seems to make the whole player more stable, especially when appending tracks to queue / reordering.
Under the hood, the cache size is configurable, so we could technically make the preload more powerful (e.g disable it, or preload more than one track), or offer a UI to control it in the future.0.19https://dev.funkwhale.audio/funkwhale/funkwhale/-/merge_requests/738Fix #770: Document how to use Redis over unix sockets2019-04-30T12:20:37ZAgateFix #770: Document how to use Redis over unix sockets0.19https://dev.funkwhale.audio/funkwhale/funkwhale/-/merge_requests/737Fix #619: Use attributedTo instead of actor in library ActivityPub payload2019-04-24T12:44:21ZAgateFix #619: Use attributedTo instead of actor in library ActivityPub payloadThe old field is still sent, and we use it when the new one is not received
Closes #619The old field is still sent, and we use it when the new one is not received
Closes #6190.19https://dev.funkwhale.audio/funkwhale/funkwhale/-/merge_requests/736See #565: fixed path issues with external storage2019-04-24T13:29:58ZAgateSee #565: fixed path issues with external storageCloses #565Closes #5650.19https://dev.funkwhale.audio/funkwhale/funkwhale/-/merge_requests/735Fix #565: store media files in S3 bucket2019-04-24T10:59:46ZAgateFix #565: store media files in S3 bucketCloses #565
Tested locally with Minio
tested with wasabi as well, seems to work too :)Closes #565
Tested locally with Minio
tested with wasabi as well, seems to work too :)0.19https://dev.funkwhale.audio/funkwhale/funkwhale/-/merge_requests/734Fix #719: Added a "load more" button on artist pages to load more tracks/albums2019-04-23T10:57:49ZAgateFix #719: Added a "load more" button on artist pages to load more tracks/albumsCloses #719
(For the screenshots I only load 1 album/tracks, but by default, 25 albums and 50 tracks are loaded, nothing changed on the API side)
![image](/uploads/ae15d6ce9b04872449a6216ea2797231/image.png)
![image](/uploads/a21b...Closes #719
(For the screenshots I only load 1 album/tracks, but by default, 25 albums and 50 tracks are loaded, nothing changed on the API side)
![image](/uploads/ae15d6ce9b04872449a6216ea2797231/image.png)
![image](/uploads/a21bd7f979eae1ac8faf07dbf9df695b/image.png)0.19https://dev.funkwhale.audio/funkwhale/funkwhale/-/merge_requests/733Fix #798: Allow users with dots in their usernames to request a subsonic pass...2019-04-23T09:38:42ZAgateFix #798: Allow users with dots in their usernames to request a subsonic passwordCloses #798Closes #7980.19https://dev.funkwhale.audio/funkwhale/funkwhale/-/merge_requests/732Fix #806: Use proper site name/domain in emails2019-04-23T09:18:23ZAgateFix #806: Use proper site name/domain in emailsCloses #806Closes #8060.19https://dev.funkwhale.audio/funkwhale/funkwhale/-/merge_requests/731Fix #799: Removed broken/instable lyrics feature2019-04-23T08:36:10ZAgateFix #799: Removed broken/instable lyrics featureCloses #799Closes #7990.19https://dev.funkwhale.audio/funkwhale/funkwhale/-/merge_requests/730Fix #385: Improved readability of logo2019-04-23T08:14:42ZAgateFix #385: Improved readability of logoCloses #385
Thank you @troll :)Closes #385
Thank you @troll :)0.19https://dev.funkwhale.audio/funkwhale/funkwhale/-/merge_requests/729Resolve "Add confirmation when adding a song to a playlist if it is already i...2019-04-24T09:31:47ZQasim AliResolve "Add confirmation when adding a song to a playlist if it is already in the playlist"Closes #784
![Video recording](/uploads/9d7020476cb982565cc1839f8b9ca06f/funkwhale-playlist.webm)
Return a validation error on PLT create / playlist add many if the given tracks are already in the target playlist and a `allowDupli...Closes #784
![Video recording](/uploads/9d7020476cb982565cc1839f8b9ca06f/funkwhale-playlist.webm)
Return a validation error on PLT create / playlist add many if the given tracks are already in the target playlist and a `allowDuplicate`/`allowDuplicates` flag is not specified in the request body.
Display a message on add-to-playlist / playlist batch add with buttons which allow adding duplicate items to the targeted playlist.
---
Screenshots (I tweaked with the frontend code in order to generate extra entries for some of these):
(unchanged) Before clicking the 'add' button:
![modal-before-add](/uploads/ed6c90f94e87bec27fef2a3af7c91d54/modal-before-add.png)
After trying to add a track to a playlist that already contains it. 'Cancel' dismisses the dialog, 'Add anyways' adds the song and dismisses the dialog:
![Screenshot_20190423_204425](/uploads/0ed26402868288776a355a2ead5f9e26/Screenshot_20190423_204425.png)
After trying to add songs from the current queue (a few duplicated songs):
![Screenshot_20190423_204445](/uploads/138e9c7440355d286762f011288ea8c8/Screenshot_20190423_204445.png)
After trying to add songs from the current queue (many duplicate songs):
![Screenshot_20190423_205228](/uploads/7aa493bfbf11f40ad56d6d3c4afea714/Screenshot_20190423_205228.png)https://dev.funkwhale.audio/funkwhale/funkwhale/-/merge_requests/728Resolve "Move admin/moderation related UI in a dedicated webpack chunk"2019-04-19T15:33:44ZAgateResolve "Move admin/moderation related UI in a dedicated webpack chunk"Closes #805
We moves from roughly 1350kb to 1000kb for regular users (it doesn't change anything for admin users), so that's not bad for an hour of work!Closes #805
We moves from roughly 1350kb to 1000kb for regular users (it doesn't change anything for admin users), so that's not bad for an hour of work!0.19https://dev.funkwhale.audio/funkwhale/funkwhale/-/merge_requests/727Keep persistent connections to the database instead of recreating a new one f...2019-05-10T07:42:55ZAgateKeep persistent connections to the database instead of recreating a new one for each requesthttps://dev.funkwhale.audio/funkwhale/funkwhale/-/merge_requests/726See #689: Fixed some performance issues with filtering on library/upload/trac...2019-04-19T12:16:24ZAgateSee #689: Fixed some performance issues with filtering on library/upload/track pageshttps://dev.funkwhale.audio/funkwhale/funkwhale/-/merge_requests/725Fix #689: changelog and release notes2019-04-19T10:26:14ZAgateFix #689: changelog and release notesCloses #689Closes #6890.19https://dev.funkwhale.audio/funkwhale/funkwhale/-/merge_requests/724Admin UI for libraries and uploads2019-04-19T10:07:26ZAgateAdmin UI for libraries and uploadsSee #689
### Libraries
![image](/uploads/8f8a19c2324373d5ad5557a7b3bec6d7/image.png)
![image](/uploads/d0a854f6f6cb6c3a3721e8507cd1081e/image.png)
### Uploads
![image](/uploads/31c226875a2e515d5459edf92868a013/image.png)
![image](...See #689
### Libraries
![image](/uploads/8f8a19c2324373d5ad5557a7b3bec6d7/image.png)
![image](/uploads/d0a854f6f6cb6c3a3721e8507cd1081e/image.png)
### Uploads
![image](/uploads/31c226875a2e515d5459edf92868a013/image.png)
![image](/uploads/88f866eed4c1684c8d857cd1dfe4724d/image.png)0.19https://dev.funkwhale.audio/funkwhale/funkwhale/-/merge_requests/723Logic to refetch remote entities2019-04-18T12:37:18ZAgateLogic to refetch remote entitiesThis implement the UI / API Endpoints to refetch AP objects. Currently it's limited to Artist, Album and Track objects, but it should work with any object.
This is useful to manually sync with a remote entity if we didn't received the `...This implement the UI / API Endpoints to refetch AP objects. Currently it's limited to Artist, Album and Track objects, but it should work with any object.
This is useful to manually sync with a remote entity if we didn't received the `Update` messages for some reason.
cf #6890.19https://dev.funkwhale.audio/funkwhale/funkwhale/-/merge_requests/722Edits for artists and albums2019-04-17T14:11:25ZAgateEdits for artists and albumsSee #689See #6890.19