funkwhale merge requestshttps://dev.funkwhale.audio/funkwhale/funkwhale/-/merge_requests2019-06-17T06:25:25Zhttps://dev.funkwhale.audio/funkwhale/funkwhale/-/merge_requests/785Resolve ""This backend doesn't support absolute paths" when uploading certain...2019-06-17T06:25:25ZAgateResolve ""This backend doesn't support absolute paths" when uploading certain tracks"Closes #857
Quite a simple fix: instead of using the file *path* to guess the mimetype (when guessing from file content fails), which is unsupported on S3 storages, we use the file *name*, which works seamlessly!
@funkwhale/revie...Closes #857
Quite a simple fix: instead of using the file *path* to guess the mimetype (when guessing from file content fails), which is unsupported on S3 storages, we use the file *name*, which works seamlessly!
@funkwhale/reviewers-python0.19.1https://dev.funkwhale.audio/funkwhale/funkwhale/-/merge_requests/784Fix #833: broken translation on homepage2019-06-17T06:25:47ZAgateFix #833: broken translation on homepageCloses #833
This specific translation had HTML in it, and it's usually causing such problems. Moving it to javascript fixed it :)Closes #833
This specific translation had HTML in it, and it's usually causing such problems. Moving it to javascript fixed it :)0.19.1https://dev.funkwhale.audio/funkwhale/funkwhale/-/merge_requests/783Fix #814: Added copy-to-clipboard button with Subsonic password input2019-06-12T08:41:34ZAgateFix #814: Added copy-to-clipboard button with Subsonic password inputCloses #814
- Adds a "copy-to-clipboard" button next to the subsonic password
- Automatically reveal the password during creation/change to avoid copy-pasting the "hidden password dots"
![Peek_2019-06-11_13-46](/uploads/723964a1b7e9e...Closes #814
- Adds a "copy-to-clipboard" button next to the subsonic password
- Automatically reveal the password during creation/change to avoid copy-pasting the "hidden password dots"
![Peek_2019-06-11_13-46](/uploads/723964a1b7e9ee349d7d7a8c1765c9bb/Peek_2019-06-11_13-46.mp4)0.19.1https://dev.funkwhale.audio/funkwhale/funkwhale/-/merge_requests/782Fix #855: secondary menus truncated on narrow screens2019-06-11T11:13:06ZAgateFix #855: secondary menus truncated on narrow screensCloses #855
This now makes the menu scrollable when needed :)
![Peek_2019-06-11_11-51](/uploads/1ea6bded4798f3497cd4ef5e69b7ab54/Peek_2019-06-11_11-51.mp4)Closes #855
This now makes the menu scrollable when needed :)
![Peek_2019-06-11_11-51](/uploads/1ea6bded4798f3497cd4ef5e69b7ab54/Peek_2019-06-11_11-51.mp4)0.19.1https://dev.funkwhale.audio/funkwhale/funkwhale/-/merge_requests/781Model / settings for allow-listing2019-06-17T07:56:38ZAgateModel / settings for allow-listing(See #853 for context)
This MR adds:
- Two dedicated admin settings to control if:
- Allow-listing is enabled
- The list of domains on the allow-list is public or not
- A new `allowed` field in the `Domain` table, to control...(See #853 for context)
This MR adds:
- Two dedicated admin settings to control if:
- Allow-listing is enabled
- The list of domains on the allow-list is public or not
- A new `allowed` field in the `Domain` table, to control wether or not the domain is on the allow-list. We default to Null so mods of pods switching to allow-listing can quickly find out the list of domains they need to check , and batch allow/disallow those
- Display of the `allowed` value for each domain in Django's admin
- The corresponding `allowed` field for `Domain` resources in the API
- Support for updating this field when you're a moderator
**I know it may seem a lot, but the MR is actually quite small, and each commit match precisely one of the items listed above. I recommend reading the changes commit-by-commit ;)**
Let me know if you have any question!0.20https://dev.funkwhale.audio/funkwhale/funkwhale/-/merge_requests/780Fix #835: Hide pod statistics on about page if those are disabled2019-06-11T08:03:59ZAgateFix #835: Hide pod statistics on about page if those are disabledCloses #835
It just completely hide the stats bloc on the about page if we don't have the minimum data available.
cc @Sporiff Closes #835
It just completely hide the stats bloc on the about page if we don't have the minimum data available.
cc @Sporiff 0.19.1https://dev.funkwhale.audio/funkwhale/funkwhale/-/merge_requests/779Fix #834: Simplified embedded docker reverse proxy IP configuration2019-06-11T07:58:22ZAgateFix #834: Simplified embedded docker reverse proxy IP configurationCloses #834
cc @egon: tested on my own dockerized instance, seems to work great, thank you for the contribution!
cc @Sporiff Closes #834
cc @egon: tested on my own dockerized instance, seems to work great, thank you for the contribution!
cc @Sporiff 0.19.1https://dev.funkwhale.audio/funkwhale/funkwhale/-/merge_requests/778Fix #847: Use ASCII filename before upload to S3 to avoid playback issues2019-06-11T08:04:24ZAgateFix #847: Use ASCII filename before upload to S3 to avoid playback issuesCloses #847
Introduce a new [slugify](https://github.com/mozilla/unicode-slugify) dependency to avoid troubles with non latin filenames, cf [Mastodon](https://mastodon.eliotberriot.com/@eliotberriot/102247691700691956).
This one w...Closes #847
Introduce a new [slugify](https://github.com/mozilla/unicode-slugify) dependency to avoid troubles with non latin filenames, cf [Mastodon](https://mastodon.eliotberriot.com/@eliotberriot/102247691700691956).
This one will translate non-latin characters to something close in latin alphabet, instead of return empty spaces, as our previous implementation did.0.19.1https://dev.funkwhale.audio/funkwhale/funkwhale/-/merge_requests/777Fix #851: wrong og:image url when using S3 storage2019-06-10T10:13:59ZAgateFix #851: wrong og:image url when using S3 storageCloses #851Closes #8510.19.1https://dev.funkwhale.audio/funkwhale/funkwhale/-/merge_requests/776Fix #848: Fixed invalid file extension for transcoded tracks2019-06-10T09:59:44ZAgateFix #848: Fixed invalid file extension for transcoded tracksCloses #848Closes #8480.19.1https://dev.funkwhale.audio/funkwhale/funkwhale/-/merge_requests/775Fix #850: Ensure empty but optional fields in file metadata don't error durin...2019-06-10T09:09:04ZAgateFix #850: Ensure empty but optional fields in file metadata don't error during importCloses #850
Note that the issue wasn't only with `copyright` field, but also license, position, disc number and mbid fields ;)Closes #850
Note that the issue wasn't only with `copyright` field, but also license, position, disc number and mbid fields ;)0.19.1https://dev.funkwhale.audio/funkwhale/funkwhale/-/merge_requests/774Develop cherry pick2019-06-10T07:56:00ZAgateDevelop cherry pickCherry picked a few commits from develop that should be included in the 0.19.1 release:
- aa5fd6b2b7be5c8bc6044b4994a22a374a07b84a Fix websockets reverse proxy
- bc67779303e5ea8bc4fc7552cd7c66e9dc265cd0 Fix French translation for "St...Cherry picked a few commits from develop that should be included in the 0.19.1 release:
- aa5fd6b2b7be5c8bc6044b4994a22a374a07b84a Fix websockets reverse proxy
- bc67779303e5ea8bc4fc7552cd7c66e9dc265cd0 Fix French translation for "Start radio"
- 4ab490eb69cfb7412895316eee3224996b668593 (origin/listenings-filter, listenings-filter) Added username and domain filter on /history/listenings endpoint
- 3814c1101c88207490ace59ad4bca2d493f9dc21 Added some documentation about translations lifecycle
- 7bcf896f3a4e7b77ff5f1a343439f49eccf0b589 Added fix + changelog fragment for #838
- d530aca4d09cc15fc209737f9a7957ac9ee88b9f Resolve "Add documentation for resolver conf"0.19.1https://dev.funkwhale.audio/funkwhale/funkwhale/-/merge_requests/772Fix French translation for "Start radio"2019-06-08T19:03:19ZCreakFix French translation for "Start radio"Related issue: #849 <!-- it's okay to have no issue for small changes -->
This Merge Request includes:
- [x] Tests (I don't think a test is even doable for this :wink: )
- [x] A changelog fragment (cf https://docs.funkwhale.audio/...Related issue: #849 <!-- it's okay to have no issue for small changes -->
This Merge Request includes:
- [x] Tests (I don't think a test is even doable for this :wink: )
- [x] A changelog fragment (cf https://docs.funkwhale.audio/contributing.html#changelog-management)0.19.1https://dev.funkwhale.audio/funkwhale/funkwhale/-/merge_requests/771Added username and domain filter on /history/listenings endpoint2019-06-07T14:44:49ZAgateAdded username and domain filter on /history/listenings endpoint0.19.1https://dev.funkwhale.audio/funkwhale/funkwhale/-/merge_requests/770Added some documentation about translations lifecycle2019-06-06T11:53:06ZAgateAdded some documentation about translations lifecycle0.19.1Ciarán Ainsworthsporiff@funkwhale.audioCiarán Ainsworthsporiff@funkwhale.audiohttps://dev.funkwhale.audio/funkwhale/funkwhale/-/merge_requests/769Add new translations, fix en_GB2019-06-06T12:00:28ZCiarán Ainsworthsporiff@funkwhale.audioAdd new translations, fix en_GBAdd the following translation files:
- [x] Czech
- [x] Catalan
Fix the following translation files
- [x] en_GB
Add all of these to the locale files to allow them to be picked from the dropdown
This MR contains:
- [x] A...Add the following translation files:
- [x] Czech
- [x] Catalan
Fix the following translation files
- [x] en_GB
Add all of these to the locale files to allow them to be picked from the dropdown
This MR contains:
- [x] A changelog fragment
- [x] Language files
- [x] An updated language list
Closes #844
Closes #845
Closes #846 Ciarán Ainsworthsporiff@funkwhale.audioCiarán Ainsworthsporiff@funkwhale.audiohttps://dev.funkwhale.audio/funkwhale/funkwhale/-/merge_requests/768Resolve "Hovering volume button changes player's height"2019-05-24T09:15:18ZCiarán Ainsworthsporiff@funkwhale.audioResolve "Hovering volume button changes player's height"Closes #838Closes #8380.19.1https://dev.funkwhale.audio/funkwhale/funkwhale/-/merge_requests/767Resolve "Add documentation for resolver conf"2019-06-11T12:27:54ZCiarán Ainsworthsporiff@funkwhale.audioResolve "Add documentation for resolver conf"Closes #840Closes #840https://dev.funkwhale.audio/funkwhale/funkwhale/-/merge_requests/766Translations integration2019-05-16T07:54:02ZAgateTranslations integration0.19https://dev.funkwhale.audio/funkwhale/funkwhale/-/merge_requests/765Fix #830: Better handling of follow/accept messages to avoid and recover from...2019-05-14T09:03:22ZAgateFix #830: Better handling of follow/accept messages to avoid and recover from...Fix #830: Better handling of follow/accept messages to avoid and recover from desync between instances
- Ensure `Accept` message is resent when receiving a new follow (only if the follow was already accepted)
- Added a button in the lib...Fix #830: Better handling of follow/accept messages to avoid and recover from desync between instances
- Ensure `Accept` message is resent when receiving a new follow (only if the follow was already accepted)
- Added a button in the library card to cancel follow requests0.19