funkwhale merge requestshttps://dev.funkwhale.audio/funkwhale/funkwhale/-/merge_requests2020-07-23T15:28:15Zhttps://dev.funkwhale.audio/funkwhale/funkwhale/-/merge_requests/1173Resolve "Licence Art Libre"2020-07-23T15:28:15ZCiarán Ainsworthsporiff@funkwhale.audioResolve "Licence Art Libre"Closes #1088
Adds support for Licence Art Libre (LAL-1.3). Tested in-app and with upload tagged by Picard.Closes #1088
Adds support for Licence Art Libre (LAL-1.3). Tested in-app and with upload tagged by Picard.1.0Ciarán Ainsworthsporiff@funkwhale.audioCiarán Ainsworthsporiff@funkwhale.audiohttps://dev.funkwhale.audio/funkwhale/funkwhale/-/merge_requests/1172Resolve "Missing internationalization/fromatting add time for Channels"2020-07-21T14:58:46ZCiarán Ainsworthsporiff@funkwhale.audioResolve "Missing internationalization/fromatting add time for Channels"Closes #1089
Adds more human-readable "time ago" stats for channel cards, uses internationalization from moment
![Screenshot_from_2020-07-21_14.33.09](/uploads/e2e300f198041b86c0ad1071e420eb52/Screenshot_from_2020-07-21_14.33.09.p...Closes #1089
Adds more human-readable "time ago" stats for channel cards, uses internationalization from moment
![Screenshot_from_2020-07-21_14.33.09](/uploads/e2e300f198041b86c0ad1071e420eb52/Screenshot_from_2020-07-21_14.33.09.png)
![Screenshot_from_2020-07-21_14.33.22](/uploads/714778697e8a07a870fdaba9d4fa23ec/Screenshot_from_2020-07-21_14.33.22.png)1.0Ciarán Ainsworthsporiff@funkwhale.audioCiarán Ainsworthsporiff@funkwhale.audiohttps://dev.funkwhale.audio/funkwhale/funkwhale/-/merge_requests/1171Resolve "API Endpoint for my own music"2020-07-21T12:43:09ZAgateResolve "API Endpoint for my own music"Closes #1116Closes #11160.21.2https://dev.funkwhale.audio/funkwhale/funkwhale/-/merge_requests/1170Fix #1175: Fix embedded player not working on channel serie/album2020-07-21T09:24:45ZAgateFix #1175: Fix embedded player not working on channel serie/albumCloses #1175Closes #1175https://dev.funkwhale.audio/funkwhale/funkwhale/-/merge_requests/1169Fix #1083: Play button now replace current queue instead of appending to it2020-07-18T14:55:59ZAgateFix #1083: Play button now replace current queue instead of appending to itCloses #1083Closes #10831.0https://dev.funkwhale.audio/funkwhale/funkwhale/-/merge_requests/1168Add support for unauthenticated users hitting the logout page2020-07-17T09:45:33ZCiarán Ainsworthsporiff@funkwhale.audioAdd support for unauthenticated users hitting the logout pageCurrently, if an unauthenticated users navigates to <funkwhale-url>/logout they are met with the following screen:
![Screenshot_from_2020-07-16_20.57.17](/uploads/93d816823c6c9f2c602c188dcb683fd4/Screenshot_from_2020-07-16_20.57.17.pn...Currently, if an unauthenticated users navigates to <funkwhale-url>/logout they are met with the following screen:
![Screenshot_from_2020-07-16_20.57.17](/uploads/93d816823c6c9f2c602c188dcb683fd4/Screenshot_from_2020-07-16_20.57.17.png)
Rather than simply navigate the user away from this page to a login page, this change detects whether or not the user is authenticated and presents them the option of navigating themselves.Ciarán Ainsworthsporiff@funkwhale.audioCiarán Ainsworthsporiff@funkwhale.audiohttps://dev.funkwhale.audio/funkwhale/funkwhale/-/merge_requests/1167Resolve "Playback bar renders incorrectly, is unusable on iPad in landscape m...2020-07-16T17:32:41ZCiarán Ainsworthsporiff@funkwhale.audioResolve "Playback bar renders incorrectly, is unusable on iPad in landscape mode"Closes #1144
### Before
![Screenshot_from_2020-07-15_22.19.21](/uploads/52ee5cdf566d375861d41a2f5ccdcf2e/Screenshot_from_2020-07-15_22.19.21.png)
### After
![Screenshot_from_2020-07-15_22.18.42](/uploads/ad289cb7d42ac33c3339...Closes #1144
### Before
![Screenshot_from_2020-07-15_22.19.21](/uploads/52ee5cdf566d375861d41a2f5ccdcf2e/Screenshot_from_2020-07-15_22.19.21.png)
### After
![Screenshot_from_2020-07-15_22.18.42](/uploads/ad289cb7d42ac33c3339d954f318565a/Screenshot_from_2020-07-15_22.18.42.png)Ciarán Ainsworthsporiff@funkwhale.audioCiarán Ainsworthsporiff@funkwhale.audiohttps://dev.funkwhale.audio/funkwhale/funkwhale/-/merge_requests/1166Fix issue with artist embed2020-07-15T18:02:06ZCiarán Ainsworthsporiff@funkwhale.audioFix issue with artist embedArtist embed was broken due to invalid order filter on URL. This MR changes this to a valid query string.Artist embed was broken due to invalid order filter on URL. This MR changes this to a valid query string.0.21.2Ciarán Ainsworthsporiff@funkwhale.audioCiarán Ainsworthsporiff@funkwhale.audiohttps://dev.funkwhale.audio/funkwhale/funkwhale/-/merge_requests/1165Upgraded dependencies2020-07-18T08:29:23ZAgateUpgraded dependencies1.0https://dev.funkwhale.audio/funkwhale/funkwhale/-/merge_requests/1164Remove extra period in documentation.2020-07-10T14:10:25ZBheesham PersaudRemove extra period in documentation.Minor documentation update.Minor documentation update.https://dev.funkwhale.audio/funkwhale/funkwhale/-/merge_requests/1163Add `-e` flag to `sed` command in fix-fomantic-css.sh.2020-07-10T19:00:40ZBheesham PersaudAdd `-e` flag to `sed` command in fix-fomantic-css.sh.Related issue: None
This Merge Request includes:
- [X] Tests (manual: https://dev.funkwhale.audio/bheesham/funkwhale/-/jobs/51069#L32)
- [X] A changelog fragment (cf https://docs.funkwhale.audio/contributing.html#changelog-managem...Related issue: None
This Merge Request includes:
- [X] Tests (manual: https://dev.funkwhale.audio/bheesham/funkwhale/-/jobs/51069#L32)
- [X] A changelog fragment (cf https://docs.funkwhale.audio/contributing.html#changelog-management)
---
This allows me to run `yarn install` on Mac.https://dev.funkwhale.audio/funkwhale/funkwhale/-/merge_requests/1162Fix #1080: broken artist and album pages2020-07-07T17:22:47ZAgateFix #1080: broken artist and album pagesCloses #1080Closes #10801.0https://dev.funkwhale.audio/funkwhale/funkwhale/-/merge_requests/1161Fix #1131: More consistent search UX on /albums, /artists, /radios and /playl...2020-07-06T11:26:37ZAgateFix #1131: More consistent search UX on /albums, /artists, /radios and /playlistsCloses #1131Closes #11311.0https://dev.funkwhale.audio/funkwhale/funkwhale/-/merge_requests/1160Resolve "Automatically confirm email once the confirmation link is clicked in...2020-07-06T11:07:27ZAgateResolve "Automatically confirm email once the confirmation link is clicked instead of showing the form"Closes #407Closes #4071.0https://dev.funkwhale.audio/funkwhale/funkwhale/-/merge_requests/1159Resolve "Remove tracks from /api/v1/albums API"2020-07-07T10:40:35ZAgateResolve "Remove tracks from /api/v1/albums API"Closes #1102Closes #11021.0https://dev.funkwhale.audio/funkwhale/funkwhale/-/merge_requests/1158Fix #996: Persist theme and language settings accross sessions2020-07-05T09:28:20ZAgateFix #996: Persist theme and language settings accross sessionsCloses #996Closes #9961.0https://dev.funkwhale.audio/funkwhale/funkwhale/-/merge_requests/1157Fix #1128: Lock focus in modals to improve accessibility2020-07-03T14:13:18ZAgateFix #1128: Lock focus in modals to improve accessibilityCloses #1128Closes #11281.0https://dev.funkwhale.audio/funkwhale/funkwhale/-/merge_requests/1156Fix #1121: Use semantic headers for accessibility2020-07-03T12:26:22ZAgateFix #1121: Use semantic headers for accessibilityCloses #1121Closes #11211.0https://dev.funkwhale.audio/funkwhale/funkwhale/-/merge_requests/1155Plugins infrastructure2020-07-03T09:00:18ZAgatePlugins infrastructureContext : https://mastodon.technology/@agateblue/104444213352771496 and https://governance.funkwhale.audio/d/QyEBOaV6/status-of-our-nlnet-funding
- [x] User level plugins
- [x] USe cases:
- [x] scrobbling
- [ ] import rem...Context : https://mastodon.technology/@agateblue/104444213352771496 and https://governance.funkwhale.audio/d/QyEBOaV6/status-of-our-nlnet-funding
- [x] User level plugins
- [x] USe cases:
- [x] scrobbling
- [ ] import remote files (eg. via webdav/owncloud) -> will be done separately
- [x] Configuration per plugin per user
- [x] Functionnal as much as possible
- [x] Hooks -> no return value
- [x] Filters -> can alter the return value -> mrf
- [x] Plugins can declare dependencies
- [x] enabled plugins are listed as an env variable
- [x] Plugins are simple directories with
- [x] a funkwhale_startup.py file that is imported at startup time
- [x] a funkwhale_ready.py file that is imported when apps are ready
- [x] Plugins entrypoints are all listed in a single file, with proper documentation
# Demo
![image](/uploads/f8cda13ddb42a4e289b6297f91343280/image.png)
![image](/uploads/ce7697527f25344881f78f8d331ba5d0/image.png)
1.0https://dev.funkwhale.audio/funkwhale/funkwhale/-/merge_requests/1154Handle PermissionError when checking existing files2020-07-01T18:55:57ZSimon ArlottHandle PermissionError when checking existing files