funkwhale merge requestshttps://dev.funkwhale.audio/funkwhale/funkwhale/-/merge_requests2022-01-22T18:21:27Zhttps://dev.funkwhale.audio/funkwhale/funkwhale/-/merge_requests/1470Resolve "Widget improperly configured (missing resource id)."2022-01-22T18:21:27ZCiarán Ainsworthsporiff@funkwhale.audioResolve "Widget improperly configured (missing resource id)."Closes #1675
An issue probably introduced by linting. It looks like we're comparing types in the `getURLParams` function rather than assigning a value to the `match` variable.
![Screen_Shot_2022-01-21_at_19.13.10](/uploads/148d87faa45...Closes #1675
An issue probably introduced by linting. It looks like we're comparing types in the `getURLParams` function rather than assigning a value to the `match` variable.
![Screen_Shot_2022-01-21_at_19.13.10](/uploads/148d87faa459c52963c1749803a623ad/Screen_Shot_2022-01-21_at_19.13.10.png)1.2.2Ciarán Ainsworthsporiff@funkwhale.audioCiarán Ainsworthsporiff@funkwhale.audiohttps://dev.funkwhale.audio/funkwhale/funkwhale/-/merge_requests/1469Update dependency vue to ^2.6.142022-01-23T06:47:59ZRenovateBotUpdate dependency vue to ^2.6.14This MR contains the following updates:
| Package | Type | Update | Change |
|---|---|---|---|
| [vue](https://github.com/vuejs/vue) | dependencies | patch | [`^2.6.10` -> `^2.6.14`](https://renovatebot.com/diffs/npm/vue/2.6.11/2.6.14) ...This MR contains the following updates:
| Package | Type | Update | Change |
|---|---|---|---|
| [vue](https://github.com/vuejs/vue) | dependencies | patch | [`^2.6.10` -> `^2.6.14`](https://renovatebot.com/diffs/npm/vue/2.6.11/2.6.14) |
:warning: Release Notes retrieval for this MR were skipped because no github.com credentials were available.
If you are self-hosted, please see [this instruction](https://github.com/renovatebot/renovate/blob/master/docs/usage/examples/self-hosting.md#githubcom-token-for-release-notes).
---
### Configuration
📅 **Schedule**: At any time (no schedule defined).
🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.
♻ **Rebasing**: Renovate will not automatically rebase this PR, because other commits have been found.
🔕 **Ignore**: Close this MR and you won't be reminded about this update again.
---
- [ ] <!-- rebase-check -->If you want to rebase/retry this MR, click this checkbox.
---
This MR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).https://dev.funkwhale.audio/funkwhale/funkwhale/-/merge_requests/1462Update dependency js-logger to ^1.6.1 (stable) - autoclosed2022-01-20T13:34:19ZRenovateBotUpdate dependency js-logger to ^1.6.1 (stable) - autoclosedThis MR contains the following updates:
| Package | Type | Update | Change |
|---|---|---|---|
| [js-logger](https://github.com/jonnyreeves/js-logger) | dependencies | patch | [`^1.4.1` -> `^1.6.1`](https://renovatebot.com/diffs/npm/js-...This MR contains the following updates:
| Package | Type | Update | Change |
|---|---|---|---|
| [js-logger](https://github.com/jonnyreeves/js-logger) | dependencies | patch | [`^1.4.1` -> `^1.6.1`](https://renovatebot.com/diffs/npm/js-logger/1.6.0/1.6.1) |
:warning: Release Notes retrieval for this MR were skipped because no github.com credentials were available.
If you are self-hosted, please see [this instruction](https://github.com/renovatebot/renovate/blob/master/docs/usage/examples/self-hosting.md#githubcom-token-for-release-notes).
---
### Configuration
📅 **Schedule**: At any time (no schedule defined).
🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.
♻ **Rebasing**: Whenever MR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 **Ignore**: Close this MR and you won't be reminded about this update again.
---
- [ ] <!-- rebase-check -->If you want to rebase/retry this MR, click this checkbox.
---
This MR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).https://dev.funkwhale.audio/funkwhale/funkwhale/-/merge_requests/1461Update dependency howler to ^2.2.3 (stable) - autoclosed2022-01-20T13:34:17ZRenovateBotUpdate dependency howler to ^2.2.3 (stable) - autoclosedThis MR contains the following updates:
| Package | Type | Update | Change |
|---|---|---|---|
| [howler](https://howlerjs.com) ([source](https://github.com/goldfire/howler.js)) | dependencies | patch | [`^2.2.1` -> `^2.2.3`](https://re...This MR contains the following updates:
| Package | Type | Update | Change |
|---|---|---|---|
| [howler](https://howlerjs.com) ([source](https://github.com/goldfire/howler.js)) | dependencies | patch | [`^2.2.1` -> `^2.2.3`](https://renovatebot.com/diffs/npm/howler/2.2.1/2.2.3) |
:warning: Release Notes retrieval for this MR were skipped because no github.com credentials were available.
If you are self-hosted, please see [this instruction](https://github.com/renovatebot/renovate/blob/master/docs/usage/examples/self-hosting.md#githubcom-token-for-release-notes).
---
### Configuration
📅 **Schedule**: At any time (no schedule defined).
🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.
♻ **Rebasing**: Whenever MR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 **Ignore**: Close this MR and you won't be reminded about this update again.
---
- [ ] <!-- rebase-check -->If you want to rebase/retry this MR, click this checkbox.
---
This MR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).https://dev.funkwhale.audio/funkwhale/funkwhale/-/merge_requests/1460Update dependency fomantic-ui-css to ^2.8.8 (stable) - autoclosed2022-01-20T13:34:14ZRenovateBotUpdate dependency fomantic-ui-css to ^2.8.8 (stable) - autoclosedThis MR contains the following updates:
| Package | Type | Update | Change |
|---|---|---|---|
| [fomantic-ui-css](https://fomantic-ui.com) ([source](https://github.com/fomantic/Fomantic-UI-CSS)) | dependencies | patch | [`^2.8.3` -> `^...This MR contains the following updates:
| Package | Type | Update | Change |
|---|---|---|---|
| [fomantic-ui-css](https://fomantic-ui.com) ([source](https://github.com/fomantic/Fomantic-UI-CSS)) | dependencies | patch | [`^2.8.3` -> `^2.8.8`](https://renovatebot.com/diffs/npm/fomantic-ui-css/2.8.6/2.8.8) |
:warning: Release Notes retrieval for this MR were skipped because no github.com credentials were available.
If you are self-hosted, please see [this instruction](https://github.com/renovatebot/renovate/blob/master/docs/usage/examples/self-hosting.md#githubcom-token-for-release-notes).
---
### Configuration
📅 **Schedule**: At any time (no schedule defined).
🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.
♻ **Rebasing**: Whenever MR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 **Ignore**: Close this MR and you won't be reminded about this update again.
---
- [ ] <!-- rebase-check -->If you want to rebase/retry this MR, click this checkbox.
---
This MR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).https://dev.funkwhale.audio/funkwhale/funkwhale/-/merge_requests/1458Update dependency eslint-config-standard to ^16.0.3 (stable) - autoclosed2022-01-20T10:06:51ZRenovateBotUpdate dependency eslint-config-standard to ^16.0.3 (stable) - autoclosedThis MR contains the following updates:
| Package | Type | Update | Change |
|---|---|---|---|
| [eslint-config-standard](https://github.com/standard/eslint-config-standard) | devDependencies | patch | [`^16.0.2` -> `^16.0.3`](https://r...This MR contains the following updates:
| Package | Type | Update | Change |
|---|---|---|---|
| [eslint-config-standard](https://github.com/standard/eslint-config-standard) | devDependencies | patch | [`^16.0.2` -> `^16.0.3`](https://renovatebot.com/diffs/npm/eslint-config-standard/16.0.3/16.0.3) |
---
### Configuration
📅 **Schedule**: At any time (no schedule defined).
🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.
♻ **Rebasing**: Whenever MR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 **Ignore**: Close this MR and you won't be reminded about this update again.
---
- [ ] <!-- rebase-check -->If you want to rebase/retry this MR, click this checkbox.
---
This MR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).https://dev.funkwhale.audio/funkwhale/funkwhale/-/merge_requests/1457Update dependency eslint to ^7.32.0 (stable) - autoclosed2022-01-20T10:06:49ZRenovateBotUpdate dependency eslint to ^7.32.0 (stable) - autoclosedThis MR contains the following updates:
| Package | Type | Update | Change |
|---|---|---|---|
| [eslint](https://eslint.org) ([source](https://github.com/eslint/eslint)) | devDependencies | patch | [`^7.25.0` -> `^7.32.0`](https://reno...This MR contains the following updates:
| Package | Type | Update | Change |
|---|---|---|---|
| [eslint](https://eslint.org) ([source](https://github.com/eslint/eslint)) | devDependencies | patch | [`^7.25.0` -> `^7.32.0`](https://renovatebot.com/diffs/npm/eslint/7.32.0/7.32.0) |
---
### Configuration
📅 **Schedule**: At any time (no schedule defined).
🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.
♻ **Rebasing**: Whenever MR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 **Ignore**: Close this MR and you won't be reminded about this update again.
---
- [ ] <!-- rebase-check -->If you want to rebase/retry this MR, click this checkbox.
---
This MR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).https://dev.funkwhale.audio/funkwhale/funkwhale/-/merge_requests/1456Update dependency diff to ^4.0.2 (stable) - autoclosed2022-01-20T13:34:09ZRenovateBotUpdate dependency diff to ^4.0.2 (stable) - autoclosedThis MR contains the following updates:
| Package | Type | Update | Change |
|---|---|---|---|
| [diff](https://github.com/kpdecker/jsdiff) | dependencies | patch | [`^4.0.1` -> `^4.0.2`](https://renovatebot.com/diffs/npm/diff/4.0.2/4.0...This MR contains the following updates:
| Package | Type | Update | Change |
|---|---|---|---|
| [diff](https://github.com/kpdecker/jsdiff) | dependencies | patch | [`^4.0.1` -> `^4.0.2`](https://renovatebot.com/diffs/npm/diff/4.0.2/4.0.2) |
---
### Configuration
📅 **Schedule**: At any time (no schedule defined).
🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.
♻ **Rebasing**: Whenever MR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 **Ignore**: Close this MR and you won't be reminded about this update again.
---
- [ ] <!-- rebase-check -->If you want to rebase/retry this MR, click this checkbox.
---
This MR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).https://dev.funkwhale.audio/funkwhale/funkwhale/-/merge_requests/1454Update dependency @babel/eslint-parser to ^7.16.5 (stable) - autoclosed2022-01-20T10:06:46ZRenovateBotUpdate dependency @babel/eslint-parser to ^7.16.5 (stable) - autoclosedThis MR contains the following updates:
| Package | Type | Update | Change |
|---|---|---|---|
| [@babel/eslint-parser](https://babel.dev/) ([source](https://github.com/babel/babel)) | devDependencies | patch | [`^7.13.14` -> `^7.16.5`]...This MR contains the following updates:
| Package | Type | Update | Change |
|---|---|---|---|
| [@babel/eslint-parser](https://babel.dev/) ([source](https://github.com/babel/babel)) | devDependencies | patch | [`^7.13.14` -> `^7.16.5`](https://renovatebot.com/diffs/npm/@babel%2feslint-parser/7.16.0/7.16.5) |
:warning: Release Notes retrieval for this MR were skipped because no github.com credentials were available.
If you are self-hosted, please see [this instruction](https://github.com/renovatebot/renovate/blob/master/docs/usage/examples/self-hosting.md#githubcom-token-for-release-notes).
---
### Configuration
📅 **Schedule**: At any time (no schedule defined).
🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.
♻ **Rebasing**: Whenever MR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 **Ignore**: Close this MR and you won't be reminded about this update again.
---
- [ ] <!-- rebase-check -->If you want to rebase/retry this MR, click this checkbox.
---
This MR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).https://dev.funkwhale.audio/funkwhale/funkwhale/-/merge_requests/1445Update index.rst - improve nginx docker instructions2022-01-23T11:32:39ZKeunesUpdate index.rst - improve nginx docker instructionsCiarán Ainsworthsporiff@funkwhale.audioCiarán Ainsworthsporiff@funkwhale.audiohttps://dev.funkwhale.audio/funkwhale/funkwhale/-/merge_requests/1441De-duplicate installation methods list2022-11-05T11:35:51ZKeunesDe-duplicate installation methods listI have no experience with reStructuredText, but used the [Documentation documentation](https://docs.funkwhale.audio/documentation/restructured.html) to form the links. There's no mention of links to internal pages, so I hope this works :...I have no experience with reStructuredText, but used the [Documentation documentation](https://docs.funkwhale.audio/documentation/restructured.html) to form the links. There's no mention of links to internal pages, so I hope this works :)
I removed the Docker warning - this list now doesn't mention AIO and multi-container difference, so is out of place here.Ciarán Ainsworthsporiff@funkwhale.audioCiarán Ainsworthsporiff@funkwhale.audiohttps://dev.funkwhale.audio/funkwhale/funkwhale/-/merge_requests/1438Implement api dependency management with pipenv2022-01-08T18:52:38ZGeorg KrauseImplement api dependency management with pipenvPipenv has a few advantages: It allows dependency pinning and locking, which would solve some problems.Pipenv has a few advantages: It allows dependency pinning and locking, which would solve some problems.1.3.0https://dev.funkwhale.audio/funkwhale/funkwhale/-/merge_requests/1434Draft: First hack to add favorite albums2022-05-10T13:45:05ZCreakDraft: First hack to add favorite albumsThis MR aims at adding the possibility to add favorite albums.
_Notes:_
* I need a mentor to guide me further, I don't know much about Django so I'm a bit lost
* I basically took the track favorite code and replaced "track" by "album" (...This MR aims at adding the possibility to add favorite albums.
_Notes:_
* I need a mentor to guide me further, I don't know much about Django so I'm a bit lost
* I basically took the track favorite code and replaced "track" by "album" (and use a bit of common sense when I could)
* I got three `# TODO: ...` in this MR: it's about values/fields that I really don't know if/how I should change
Related issue: #492
This Merge Request includes:
- [ ] Tests
- [ ] A changelog fragment (cf https://docs.funkwhale.audio/contributing.html#changelog-management)https://dev.funkwhale.audio/funkwhale/funkwhale/-/merge_requests/1427Resolve "Moderation reports and registration requests doesn't work"2021-12-20T23:33:00ZJuniorJPDJResolve "Moderation reports and registration requests doesn't work"Closes #1645Closes #16451.2.0JuniorJPDJJuniorJPDJhttps://dev.funkwhale.audio/funkwhale/funkwhale/-/merge_requests/1410Update importing-music.rst2022-01-02T15:23:58ZdudenasUpdate importing-music.rstSome simple inaccuracies, which were bugging me while reading:
1. in-place import should be default by now, since v1.0
2. sample library id weirdly had inconsistent characters throughout explanation
3. There is no /data/music folder in m...Some simple inaccuracies, which were bugging me while reading:
1. in-place import should be default by now, since v1.0
2. sample library id weirdly had inconsistent characters throughout explanation
3. There is no /data/music folder in my installation: music folder is directly in funkwhale. It seems to be have changed in some previous version.Georg KrauseGeorg Krausehttps://dev.funkwhale.audio/funkwhale/funkwhale/-/merge_requests/1398Draft: Use proper RegisterSerializer2022-09-15T06:18:56ZJuniorJPDJDraft: Use proper RegisterSerializerCloses #1288
This Merge Request includes:
- [x] Tests
- [ ] A changelog fragment (cf https://docs.funkwhale.audio/contributing.html#changelog-management)Closes #1288
This Merge Request includes:
- [x] Tests
- [ ] A changelog fragment (cf https://docs.funkwhale.audio/contributing.html#changelog-management)Georg KrauseGeorg Krausehttps://dev.funkwhale.audio/funkwhale/funkwhale/-/merge_requests/13941218 Adding acousticbrainz support for smart playlist2022-02-10T18:04:14Zpetitminion1218 Adding acousticbrainz support for smart playlistAdd Acousticbrainz support for smart playlist. Can be implemented in various ways in the frontend but it will need some update. related to #1218 .
You can test it by changing `similar_history` to `similar_mbid` in PlayButton.vue add lau...Add Acousticbrainz support for smart playlist. Can be implemented in various ways in the frontend but it will need some update. related to #1218 .
You can test it by changing `similar_history` to `similar_mbid` in PlayButton.vue add launching a song radio
![image](/uploads/537ac900725c43b9cb56165795c716a9/image.png)
I'm using regex to query the db with a list of all similar mbid. I'm not sure if this is the most efficient way to do this.1.3.0Georg KrauseGeorg Krausehttps://dev.funkwhale.audio/funkwhale/funkwhale/-/merge_requests/1393Draft: Resolve "Enable starting embedded player at a specific position in track"2022-05-31T08:35:20ZGeorg KrauseDraft: Resolve "Enable starting embedded player at a specific position in track"Closes #653Closes #6531.3.0Georg KrauseGeorg Krausehttps://dev.funkwhale.audio/funkwhale/funkwhale/-/merge_requests/1390Draft: Lets play2021-10-20T21:51:56ZJuniorJPDJDraft: Lets playTEST, DONT MERGETEST, DONT MERGEhttps://dev.funkwhale.audio/funkwhale/funkwhale/-/merge_requests/1389Draft: Kek2021-10-20T21:40:56ZJuniorJPDJDraft: KekTEST, DONT MERGETEST, DONT MERGE