funkwhale merge requestshttps://dev.funkwhale.audio/funkwhale/funkwhale/-/merge_requests2019-02-07T14:16:02Zhttps://dev.funkwhale.audio/funkwhale/funkwhale/-/merge_requests/581See #662: documentation about i18n / contexts, and first contextualized strings2019-02-07T14:16:02ZAgateSee #662: documentation about i18n / contexts, and first contextualized stringsSee #662
- Documentation to include context in HTML / Javascript
- Documentation for a hierarchical structure for contexts
- Added context on the signup page and the play button to test the whole thing
@jovuit, let me know what ...See #662
- Documentation to include context in HTML / Javascript
- Documentation for a hierarchical structure for contexts
- Added context on the signup page and the play button to test the whole thing
@jovuit, let me know what you think about this :)0.19https://dev.funkwhale.audio/funkwhale/funkwhale/-/merge_requests/580Update /usr/bin/nologin to /usr/sbin/nologin2019-02-05T13:41:20ZZach HalaszUpdate /usr/bin/nologin to /usr/sbin/nologini can't find search results for /usr/bin/nologin but i can for /usr/sbin/nologini can't find search results for /usr/bin/nologin but i can for /usr/sbin/nologinhttps://dev.funkwhale.audio/funkwhale/funkwhale/-/merge_requests/579Removed popularity weight in similar radio, to avoid filter bubbles2019-01-31T13:58:12ZAgateRemoved popularity weight in similar radio, to avoid filter bubblesCf https://mastodon.eliotberriot.com/@eliotberriot/101510909229084264Cf https://mastodon.eliotberriot.com/@eliotberriot/1015109092290842640.19https://dev.funkwhale.audio/funkwhale/funkwhale/-/merge_requests/578[Experimental] Added a new "Similar" radio based on users history (suggested ...2019-01-30T15:57:37ZAgate[Experimental] Added a new "Similar" radio based on users history (suggested by @gordon)cc @gordoncc @gordon0.19https://dev.funkwhale.audio/funkwhale/funkwhale/-/merge_requests/577System actor2019-01-30T10:56:13ZAgateSystem actorSee #689See #6890.19AgateAgatehttps://dev.funkwhale.audio/funkwhale/funkwhale/-/merge_requests/576Api docs2019-01-29T16:16:39ZAgateApi docsThis includes documentation for a few readonly endpoints:
- /licenses
- /tracks
- /albums
- /artists
cc @nhaddagThis includes documentation for a few readonly endpoints:
- /licenses
- /tracks
- /albums
- /artists
cc @nhaddaghttps://dev.funkwhale.audio/funkwhale/funkwhale/-/merge_requests/575Added user upload documentation2019-01-29T11:28:26ZAgateAdded user upload documentation0.18.1https://dev.funkwhale.audio/funkwhale/funkwhale/-/merge_requests/574Translations integration2019-01-29T09:52:18ZAgateTranslations integration0.18.1AgateAgatehttps://dev.funkwhale.audio/funkwhale/funkwhale/-/merge_requests/573Fix #668: list icon alignement on landing page2019-01-29T09:41:31ZAgateFix #668: list icon alignement on landing pageCloses #668Closes #6680.18.1https://dev.funkwhale.audio/funkwhale/funkwhale/-/merge_requests/572Fix #678: Removed potential BREACH exploit because of Gzip compression2019-01-29T09:24:32ZAgateFix #678: Removed potential BREACH exploit because of Gzip compressionCloses #678Closes #6780.18.1https://dev.funkwhale.audio/funkwhale/funkwhale/-/merge_requests/571Resolve "In-place imports cannot be transcoded"2019-01-29T08:32:36ZVierkantorResolve "In-place imports cannot be transcoded"Closes #688
This Merge Request includes:
- [x] Tests
- [x] A changelog fragment (cf https://docs.funkwhale.audio/contributing.html#changelog-management)
In-place imported tracks have no audio_file attribute but only a source a...Closes #688
This Merge Request includes:
- [x] Tests
- [x] A changelog fragment (cf https://docs.funkwhale.audio/contributing.html#changelog-management)
In-place imported tracks have no audio_file attribute but only a source attribute. The transcoding code assumes that the file has an audio_file attribute, so it failed on these cases.
By splitting the transcoding function into one that takes files, and one that takes pydub.AudioSegment, we can make a method on Upload that gives the AudioSegment, either by reading from self.audio_file.open() or open(self.source).
It looks like transcode_file is not used anywhere else, so it could also be an option to delete it entirely and just preserve the function that takes an AudioSegment. Is the function needed for any planned changes?
Another option would be to allow passing open files to transcode_file, which only opens them if it is needed. I'm not sure how to do this idiomatically.0.18.1https://dev.funkwhale.audio/funkwhale/funkwhale/-/merge_requests/570Document upgrading the Postgres database files.2019-01-28T08:48:06ZinterfectDocument upgrading the Postgres database files.I ran into some trouble trying to upgrade my Dockerized setup to 0.18:
```
fw-postgres_1 | 2019-01-27 18:09:38.287 UTC [1] FATAL: database files are incompatible with server
fw-postgres_1 | 2019-01-27 18:09:38.287 UTC [1] DET...I ran into some trouble trying to upgrade my Dockerized setup to 0.18:
```
fw-postgres_1 | 2019-01-27 18:09:38.287 UTC [1] FATAL: database files are incompatible with server
fw-postgres_1 | 2019-01-27 18:09:38.287 UTC [1] DETAIL: The data directory was initialized by PostgreSQL version 9.4, which is not compatible with this version 11.1 (Debian 11.1-1.pgdg90+1).
```
It looks like the changes in !529 didn't come with any upgrade path from the old Postgres for people like me who decided to take all the changes in 0.18's `docker-compose.yml` on top of an 0.17 installation.
I've documented what I did to upgrade the containerized Postgres's database, since upgrading Postgres is somehow not natively supported by the official Postgres docker images, because you need both the old and new Postgres versions installed side by side.
I'm pointing people at a third party set of containers designed to do the database upgrade for you between any two Postgres versions. They worked for me.https://dev.funkwhale.audio/funkwhale/funkwhale/-/merge_requests/569Fixed wrong URL in documentation for funkwhale_proxy.conf file when deploying...2019-01-30T11:04:20ZAgateFixed wrong URL in documentation for funkwhale_proxy.conf file when deploying using Docker0.18.1https://dev.funkwhale.audio/funkwhale/funkwhale/-/merge_requests/568Fix #685: Disable makemigrations in production and misleading message when ru...2019-01-26T21:04:29ZAgateFix #685: Disable makemigrations in production and misleading message when running migrateCloses #685Closes #6850.18.1https://dev.funkwhale.audio/funkwhale/funkwhale/-/merge_requests/567Display progress during file upload2019-01-26T19:48:41ZAgateDisplay progress during file upload0.18.1https://dev.funkwhale.audio/funkwhale/funkwhale/-/merge_requests/566Fix #686: Added name attributes on all inputs to improve UX, especially with ...2019-01-26T17:08:53ZAgateFix #686: Added name attributes on all inputs to improve UX, especially with password managersCloses #686Closes #6860.18.1https://dev.funkwhale.audio/funkwhale/funkwhale/-/merge_requests/565Improved German translations2019-01-26T16:56:17ZMax PueschelImproved German translationsI hope it's okay that I didn't create an issue for this.
I just went over the translation file and fixed some spelling / grammar / choice of word errors I found.I hope it's okay that I didn't create an issue for this.
I just went over the translation file and fixed some spelling / grammar / choice of word errors I found.https://dev.funkwhale.audio/funkwhale/funkwhale/-/merge_requests/564Fix #676: overescaping issue in notifications and album page2019-01-26T12:16:31ZAgateFix #676: overescaping issue in notifications and album pageCloses #676Closes #6760.18.1https://dev.funkwhale.audio/funkwhale/funkwhale/-/merge_requests/563Fix celery issues2019-01-25T14:44:01ZAgateFix celery issuescc @nhaddagcc @nhaddag0.18.1https://dev.funkwhale.audio/funkwhale/funkwhale/-/merge_requests/562Disable Pagination component if only 1 page of content2019-01-25T12:41:38ZjovuitDisable Pagination component if only 1 page of contentRelated issue: #681 <!-- it's okay to have no issue for small changes -->
Disables the whole `<div>` block if the content fits on 1 page, so there is no empty page selector.Related issue: #681 <!-- it's okay to have no issue for small changes -->
Disables the whole `<div>` block if the content fits on 1 page, so there is no empty page selector.