funkwhale merge requestshttps://dev.funkwhale.audio/funkwhale/funkwhale/-/merge_requests2019-03-07T09:18:29Zhttps://dev.funkwhale.audio/funkwhale/funkwhale/-/merge_requests/643Fix #737: delivering of local activities causing unintended side effects, suc...2019-03-07T09:18:29ZAgateFix #737: delivering of local activities causing unintended side effects, such...Fix #737: delivering of local activities causing unintended side effects, such as rollbacking changes
Closes #737
cc @ariasuniFix #737: delivering of local activities causing unintended side effects, such as rollbacking changes
Closes #737
cc @ariasuni0.19https://dev.funkwhale.audio/funkwhale/funkwhale/-/merge_requests/642See "[EPIC] Audio metadata update"2019-03-05T14:15:37ZAgateSee "[EPIC] Audio metadata update"See #689
This MR:
- Ensure we parse received activities with a Json-LD parser, and implement all the cleaning layers to deal with expanded jsonld payloads
- Use this new logic on all federation-related serializers
- Implement lo...See #689
This MR:
- Ensure we parse received activities with a Json-LD parser, and implement all the cleaning layers to deal with expanded jsonld payloads
- Use this new logic on all federation-related serializers
- Implement logic to dereference jsonld objects, when needed (it's not used anywhere in the code for now)
- Fix a bug that caused a crash with transient activities
- Use cached jsonld contexts to ensure we don't send absurd numbers of HTTP requests on the network
0.19https://dev.funkwhale.audio/funkwhale/funkwhale/-/merge_requests/641#511: Resolve "Page title not updated when changing the language"2019-03-05T08:31:20Zjovuit#511: Resolve "Page title not updated when changing the language"Closes #511
binding with custom directive v-title was not updated when changing the language with the dropdown menu in the footer. This has been fixed.
Source: https://vuejs.org/v2/guide/custom-directive.html#Function-Shorthand
Added...Closes #511
binding with custom directive v-title was not updated when changing the language with the dropdown menu in the footer. This has been fixed.
Source: https://vuejs.org/v2/guide/custom-directive.html#Function-Shorthand
Added changelog fragmenthttps://dev.funkwhale.audio/funkwhale/funkwhale/-/merge_requests/640Fix #735: library view doesn't like long titles names2019-03-20T15:25:32ZjovuitFix #735: library view doesn't like long titles namesCloses #735
Truncates filename at 25 characters, as to match with the truncating with correctly tagged files.
Added changelog fragmentCloses #735
Truncates filename at 25 characters, as to match with the truncating with correctly tagged files.
Added changelog fragment0.19https://dev.funkwhale.audio/funkwhale/funkwhale/-/merge_requests/639WIP: Resolve "The library view doesn't like long titles names"2019-03-04T22:41:49ZjovuitWIP: Resolve "The library view doesn't like long titles names"Closes #735Closes #735https://dev.funkwhale.audio/funkwhale/funkwhale/-/merge_requests/638#662: Fixed broken app by deleting double translate-context parameters2019-03-01T12:04:11Zjovuit#662: Fixed broken app by deleting double translate-context parametersA previous MR !636 broke the App by introducing double `:translate-context` tags in `front/src/components/common/EmptyState.vue`. This small commit should fix this.A previous MR !636 broke the App by introducing double `:translate-context` tags in `front/src/components/common/EmptyState.vue`. This small commit should fix this.0.19https://dev.funkwhale.audio/funkwhale/funkwhale/-/merge_requests/637Fixed button design 404 not found2019-03-01T13:35:16ZjovuitFixed button design 404 not foundJust a very small MR to fix the design of the button 'Go Home' on a 404 page to match the other buttons of the AppJust a very small MR to fix the design of the button 'Go Home' on a 404 page to match the other buttons of the Apphttps://dev.funkwhale.audio/funkwhale/funkwhale/-/merge_requests/636#662: Resolve "Add contexts to translatable strings"2019-03-01T13:29:58Zjovuit#662: Resolve "Add contexts to translatable strings"#662
Added context to translation strings
Minor rewording
Added changelog fragment
This was the last MR of this XL-issue #662. I will soon try to check review them all to remove potentials duplicates. I will submit a new MR for that.#662
Added context to translation strings
Minor rewording
Added changelog fragment
This was the last MR of this XL-issue #662. I will soon try to check review them all to remove potentials duplicates. I will submit a new MR for that.0.19https://dev.funkwhale.audio/funkwhale/funkwhale/-/merge_requests/635#662: Resolve "Add contexts to translatable strings"2019-03-01T08:40:13Zjovuit#662: Resolve "Add contexts to translatable strings"#662
Added translation context
+ 1 minor rewording#662
Added translation context
+ 1 minor rewording0.19https://dev.funkwhale.audio/funkwhale/funkwhale/-/merge_requests/634#662: Added translation context2019-03-01T11:39:26Zjovuit#662: Added translation context#662 Added translation context
@eliotberriot: In https://dev.funkwhale.audio/jovuit/funkwhale/blob/c65cb7aa12e1e8bdaeda0bc3f9cd662a35919118/front/src/components/mixins/Translations.vue, `title` and `track_title` seem to represent the sa...#662 Added translation context
@eliotberriot: In https://dev.funkwhale.audio/jovuit/funkwhale/blob/c65cb7aa12e1e8bdaeda0bc3f9cd662a35919118/front/src/components/mixins/Translations.vue, `title` and `track_title` seem to represent the same thing. Could you please consider removing one of them? Or did I see something wrong?
In https://dev.funkwhale.audio/jovuit/funkwhale/blob/c65cb7aa12e1e8bdaeda0bc3f9cd662a35919118/front/src/components/mixins/Translations.vue still, the strings `accessed_date` and `imported_date` don't seem to be used anywhere. If this is legacy code, could you please consider removing them as well?0.19https://dev.funkwhale.audio/funkwhale/funkwhale/-/merge_requests/633Added translation context2019-03-01T08:33:41ZjovuitAdded translation context#662 Added translation context#662 Added translation context0.19https://dev.funkwhale.audio/funkwhale/funkwhale/-/merge_requests/632See #689: now serve AP representations for uploads, tracks, albums and artists2019-02-28T11:32:09ZAgateSee #689: now serve AP representations for uploads, tracks, albums and artistsSee #689See #6890.19https://dev.funkwhale.audio/funkwhale/funkwhale/-/merge_requests/631Fix playlist icon padding on the homepage2019-02-28T08:27:02ZGhost UserFix playlist icon padding on the homepagehttps://dev.funkwhale.audio/funkwhale/funkwhale/-/merge_requests/630Added link/documentation for Mobydick2019-02-25T14:16:15ZAgateAdded link/documentation for Mobydickcc @Elzacc @Elzahttps://dev.funkwhale.audio/funkwhale/funkwhale/-/merge_requests/629Resolve "'Delete playlist button' slightly too high compared to 'Cancel' button"2019-02-25T14:07:03ZjovuitResolve "'Delete playlist button' slightly too high compared to 'Cancel' button"Closes #702Closes #702https://dev.funkwhale.audio/funkwhale/funkwhale/-/merge_requests/628Fix #725: Merged artist/album buttons with title text on artist and album pages2019-02-25T13:31:11ZAgateFix #725: Merged artist/album buttons with title text on artist and album pagesCloses #725
![image](/uploads/1bfbd8dd2a263fb2fb4822d79698dc27/image.png)
![image](/uploads/fcb466457702cec245b46ab918eebde7/image.png)Closes #725
![image](/uploads/1bfbd8dd2a263fb2fb4822d79698dc27/image.png)
![image](/uploads/fcb466457702cec245b46ab918eebde7/image.png)0.19AgateAgatehttps://dev.funkwhale.audio/funkwhale/funkwhale/-/merge_requests/627Resolve "Enhancement: improve "use another instance menu""2019-02-25T13:03:53ZjovuitResolve "Enhancement: improve "use another instance menu""Fix #715 <!-- it's okay to have no issue for small changes -->
I started to work on this issue, and it starts to look good. Here is the TODO:
- [x] Move the form to switch the instance to a dedicated file (`front/src/components/SetIn...Fix #715 <!-- it's okay to have no issue for small changes -->
I started to work on this issue, and it starts to look good. Here is the TODO:
- [x] Move the form to switch the instance to a dedicated file (`front/src/components/SetInstanceModal.vue`)
- [x] Handle the case where the modal appears when there is no current instance
- [x] Replaced the bulleted list of suggested instances by buttons
- [x] Enhance the buttons (stand: not nice :/)
- [x] Add a link to the current instance
- [x] Remove deprecated code in App.vue and Footer.vue
- [x] Perform a check whether the given url is a running funkwhale server
- [x] Perform a check whether the suggested instances are running funkwhale servers or not, and adapt the color (?) of the button accordingly
- [x] Added i18n `<translate>` tags including translation context (#662)
- [x] Add a changelog fragment
I would need your help though on how to check the status of a given url. The function `fetchDistantNodeInfo(givenurl.audio)` should reach `https://givenurl.audio/api/v1/instance/nodeinfo/2.0/`. Depending on the response, it should be quite easy to check if the server is a running funkwhale server or not.
I wanted to perform those requests with `axios`, as it seems the dedicated tool to do so, however, the requested url is always `currentinstance.audio/givenurl.audio/api/v1/instance/nodeinfo/2.0/`, I can't get it to work outside of the current instance. Even if I use a dedicated instance (see https://github.com/axios/axios#custom-instance-defaults), I still get a request inside the current instance.
How would you perform to make such a request? Is it a good practice to hard code `/api/v1/instance/nodeinfo/2.0/` here (is it really maintainable?)
Sorry for those beginners questions, but I think I could go further if I get some help at this point! Thanks a lot!0.19jovuitjovuithttps://dev.funkwhale.audio/funkwhale/funkwhale/-/merge_requests/625See #578: Improved "responsiveness" of embedded player2019-02-22T11:05:25ZTixieSee #578: Improved "responsiveness" of embedded playerIn this Merge Request I've:
- Improved the player controls to make it works in narrower contexts
- Hided the queue list when the iframe isn't tall at hall (smaller than 180px)
![mini-player-scale-4](/uploads/feada292b2f3930f60a4d3d7fa...In this Merge Request I've:
- Improved the player controls to make it works in narrower contexts
- Hided the queue list when the iframe isn't tall at hall (smaller than 180px)
![mini-player-scale-4](/uploads/feada292b2f3930f60a4d3d7fa1f3fd9/mini-player-scale-4.gif)0.19https://dev.funkwhale.audio/funkwhale/funkwhale/-/merge_requests/624See #578: Added twitter:* meta tags to detect tracks and albums players autom...2019-02-21T13:31:23ZAgateSee #578: Added twitter:* meta tags to detect tracks and albums players automatically on more sitescc @floreal
This should bring compatibility with more software, including Mastodon!cc @floreal
This should bring compatibility with more software, including Mastodon!0.19https://dev.funkwhale.audio/funkwhale/funkwhale/-/merge_requests/623Added guides for Django backend, tagging music properly2019-03-08T21:32:38ZCiarĂ¡n Ainsworthsporiff@funkwhale.audioAdded guides for Django backend, tagging music properlyBased on recent discussions in the troubleshooting chatroom, I've written up some quick guides to help new users navigate the following:
* Tagging music properly with MusicBrainz Picard (based on my own difficulties)
* Administering the...Based on recent discussions in the troubleshooting chatroom, I've written up some quick guides to help new users navigate the following:
* Tagging music properly with MusicBrainz Picard (based on my own difficulties)
* Administering the library with the Django Administration backend
These guides sit under the "User Documentation" section on the documentation page