funkwhale merge requestshttps://dev.funkwhale.audio/funkwhale/funkwhale/-/merge_requests2023-01-17T09:25:19Zhttps://dev.funkwhale.audio/funkwhale/funkwhale/-/merge_requests/2319Resolve "Replace acme.sh with certbot (dev only)" NOCHANGELOG2023-01-17T09:25:19ZGeorg KrauseResolve "Replace acme.sh with certbot (dev only)" NOCHANGELOGCloses #2033Closes #20331.3.0MargeMargehttps://dev.funkwhale.audio/funkwhale/funkwhale/-/merge_requests/2320docs: add missing sudo prefix for apt NOCHANGELOG2023-01-18T14:33:19Zjoooladocs: add missing sudo prefix for apt NOCHANGELOG@georgkrause@georgkrauseMargeMargehttps://dev.funkwhale.audio/funkwhale/funkwhale/-/merge_requests/2321Resolve "RSS channels don't work for "unreachable" service actor" NOCHANGELOG2023-01-20T08:08:04ZGeorg KrauseResolve "RSS channels don't work for "unreachable" service actor" NOCHANGELOGCloses #2014Closes #20141.3.0Georg KrauseMargeGeorg Krausehttps://dev.funkwhale.audio/funkwhale/funkwhale/-/merge_requests/2322Fix tsc linting NOCHANGELOG2023-01-19T07:07:30ZCiarán Ainsworthsporiff@funkwhale.audioFix tsc linting NOCHANGELOGCiarán Ainsworthsporiff@funkwhale.audioMargeCiarán Ainsworthsporiff@funkwhale.audiohttps://dev.funkwhale.audio/funkwhale/funkwhale/-/merge_requests/2323Resolve "Two menu entries might be active on library page" NOCHANGELOG2023-01-20T08:22:06ZKasper Sewerynwvffle@funkwhale.audioResolve "Two menu entries might be active on library page" NOCHANGELOGCloses #2029Closes #20291.3.0Kasper Sewerynwvffle@funkwhale.audioMargeKasper Sewerynwvffle@funkwhale.audiohttps://dev.funkwhale.audio/funkwhale/funkwhale/-/merge_requests/2324Docker: Do not publicly expose API port2023-01-22T10:40:46ZPhilipp WolferDocker: Do not publicly expose API portThe default docker-setup exposes the API container directly on port 5000. This should not be the case and is not needed, as API access is all routed through the frontend nginx reverse proxy.The default docker-setup exposes the API container directly on port 5000. This should not be the case and is not needed, as API access is all routed through the frontend nginx reverse proxy.1.3.0Philipp WolferMargePhilipp Wolferhttps://dev.funkwhale.audio/funkwhale/funkwhale/-/merge_requests/2325ci: allow running the pipeline on tags NOCHANGELOG2023-01-23T13:19:29Zjooolaci: allow running the pipeline on tags NOCHANGELOGcc @georgkrausecc @georgkrause1.3.0jooolaMargejooolahttps://dev.funkwhale.audio/funkwhale/funkwhale/-/merge_requests/2326fix(api): postgres connection details in docker setup2023-01-23T08:09:20Zjooolafix(api): postgres connection details in docker setupWe properly recognize the docker setup to generate DATABASE_URL configuration.
Fix #2036
cc @georgkrauseWe properly recognize the docker setup to generate DATABASE_URL configuration.
Fix #2036
cc @georgkrause1.3.0MargeMargehttps://dev.funkwhale.audio/funkwhale/funkwhale/-/merge_requests/2327Resolve "(Regression) not possible to create albums/series in channel" NOCHAN...2023-01-20T22:26:24ZKasper Sewerynwvffle@funkwhale.audioResolve "(Regression) not possible to create albums/series in channel" NOCHANGELOGCloses #2035Closes #20351.3.0Kasper Sewerynwvffle@funkwhale.audioMargeKasper Sewerynwvffle@funkwhale.audiohttps://dev.funkwhale.audio/funkwhale/funkwhale/-/merge_requests/2328Maloja fixes2023-01-22T11:00:53ZPhilipp WolferMaloja fixesMaloja submission was broken due to not properly submitting the data as JSON. This resulted in garbled artist info, see also https://github.com/krateng/maloja/issues/179Maloja submission was broken due to not properly submitting the data as JSON. This resulted in garbled artist info, see also https://github.com/krateng/maloja/issues/1791.3.0Philipp WolferMargePhilipp Wolferhttps://dev.funkwhale.audio/funkwhale/funkwhale/-/merge_requests/2329Resolve "(Regression) not possible to approve library modifications" NOCHANGELOG2023-01-20T22:59:55ZKasper Sewerynwvffle@funkwhale.audioResolve "(Regression) not possible to approve library modifications" NOCHANGELOGCloses #2024Closes #20241.3.0Kasper Sewerynwvffle@funkwhale.audioMargeKasper Sewerynwvffle@funkwhale.audiohttps://dev.funkwhale.audio/funkwhale/funkwhale/-/merge_requests/2330Resolve "Radio sessions are stopping after internet connections problems"2023-01-21T12:17:18ZKasper Sewerynwvffle@funkwhale.audioResolve "Radio sessions are stopping after internet connections problems"Closes #2022Closes #20221.3.0Kasper Sewerynwvffle@funkwhale.audioMargeKasper Sewerynwvffle@funkwhale.audiohttps://dev.funkwhale.audio/funkwhale/funkwhale/-/merge_requests/2331fix(api): improve signal handling2023-01-25T12:24:18Zjooolafix(api): improve signal handlingFix #2037Fix #20371.3.0jooolaMargejooolahttps://dev.funkwhale.audio/funkwhale/funkwhale/-/merge_requests/2332feat(api): find version using importlib.metadata2023-01-31T07:12:55Zjooolafeat(api): find version using importlib.metadata1.4.0jooolaMargejooolahttps://dev.funkwhale.audio/funkwhale/funkwhale/-/merge_requests/2333chore(docs): update dependency django to v4.1.5 (develop)2023-01-22T10:34:53ZRenovateBotchore(docs): update dependency django to v4.1.5 (develop)This MR contains the following updates:
| Package | Type | Update | Change |
|---|---|---|---|
| [Django](https://www.djangoproject.com/) ([source](https://github.com/django/django), [changelog](https://github.com/django/django/tree/mas...This MR contains the following updates:
| Package | Type | Update | Change |
|---|---|---|---|
| [Django](https://www.djangoproject.com/) ([source](https://github.com/django/django), [changelog](https://github.com/django/django/tree/master/docs/releases)) | dependencies | patch | `==4.1.4` -> `==4.1.5` |
---
### Release Notes
<details>
<summary>django/django</summary>
### [`v4.1.5`](https://github.com/django/django/compare/4.1.4...4.1.5)
[Compare Source](https://github.com/django/django/compare/4.1.4...4.1.5)
</details>
---
### Configuration
📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 **Automerge**: Enabled.
♻ **Rebasing**: Whenever MR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 **Ignore**: Close this MR and you won't be reminded about this update again.
---
- [ ] <!-- rebase-check -->If you want to rebase/retry this MR, check this box
---
This MR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNC4xMDguMSIsInVwZGF0ZWRJblZlciI6IjM0LjEwOC4xIn0=-->MargeMargehttps://dev.funkwhale.audio/funkwhale/funkwhale/-/merge_requests/2334Feature: Support boolean config fields in plugins2023-02-06T12:35:34ZPhilipp WolferFeature: Support boolean config fields in pluginsThis extends the front UI for plugin preferences to render the UI for boolean config values.
This allows rendering a config like:
``` python
conf=[
{"name": "server_url", "type": "text", "label": "Maloja server URL"},
{"name": ...This extends the front UI for plugin preferences to render the UI for boolean config values.
This allows rendering a config like:
``` python
conf=[
{"name": "server_url", "type": "text", "label": "Maloja server URL"},
{"name": "api_key", "type": "text", "label": "Your Maloja API key"},
{"name": "nofix", "type": "boolean", "label": "Skip server-side metadata fixing", "default": False},
],
```
as
![grafik](/uploads/0e5d75f4dc937fa6ac211cbe7e1534cf/grafik.png)
So far this was unsupported in the frontend, even though some of the backend tests in `test_plugins.py` used boolean config fields.1.4.0Philipp WolferMargePhilipp Wolferhttps://dev.funkwhale.audio/funkwhale/funkwhale/-/merge_requests/2335Fix API call for retrieving details of federated library NOCHANGELOG2023-01-23T07:46:52ZPhilipp WolferFix API call for retrieving details of federated library NOCHANGELOGThe implementation of RetrieveModelMixin.retrieve was incomplete, see https://www.django-rest-framework.org/api-guide/generic-views/#retrievemodelmixin . This gave an error `LibraryFollowViewSet.retrieve() got an unexpected keyword argum...The implementation of RetrieveModelMixin.retrieve was incomplete, see https://www.django-rest-framework.org/api-guide/generic-views/#retrievemodelmixin . This gave an error `LibraryFollowViewSet.retrieve() got an unexpected keyword argument 'uuid'`.
Fixes #20461.3.0Philipp WolferMargePhilipp Wolferhttps://dev.funkwhale.audio/funkwhale/funkwhale/-/merge_requests/2337Resolve "Enqueueing same album twice retsults in unrendererd tracks" NOCHANGELOG2023-01-24T17:50:44ZKasper Sewerynwvffle@funkwhale.audioResolve "Enqueueing same album twice retsults in unrendererd tracks" NOCHANGELOGThe issue itself seems related to the vue-virtual-scroller we're using. I see no explanation why it fails.
A workaround (that also clears some memory, so it's more like an enchancement) is to destroy the virtual list whenever queue is em...The issue itself seems related to the vue-virtual-scroller we're using. I see no explanation why it fails.
A workaround (that also clears some memory, so it's more like an enchancement) is to destroy the virtual list whenever queue is empty using `v-if`
Closes #20481.3.0Kasper Sewerynwvffle@funkwhale.audioMargeKasper Sewerynwvffle@funkwhale.audiohttps://dev.funkwhale.audio/funkwhale/funkwhale/-/merge_requests/2338fix: Make sure custom css gets loaded, fixes #2055 NOCHANGELOG2023-01-27T13:08:46ZGeorg Krausefix: Make sure custom css gets loaded, fixes #2055 NOCHANGELOGCloses #2055Closes #20551.3.0Kasper Sewerynwvffle@funkwhale.audioMargeKasper Sewerynwvffle@funkwhale.audiohttps://dev.funkwhale.audio/funkwhale/funkwhale/-/merge_requests/2340Corrected typos in vars.css for card text colour + Dark theme text colour fix2023-06-07T20:44:35ZAMoonRabbitCorrected typos in vars.css for card text colour + Dark theme text colour fixPlease avoid merging the base branch into your feature branch. We are working with rebases and those merged tend to cause trouble.
For further questions, join us at Matrix: https://matrix.to/#/#funkwhale-dev:matrix.org
If your contribut...Please avoid merging the base branch into your feature branch. We are working with rebases and those merged tend to cause trouble.
For further questions, join us at Matrix: https://matrix.to/#/#funkwhale-dev:matrix.org
If your contribution is fixing an issue by a small change, please consider a merge into `stable` by using it as target branch.
Related issue: #2058
This Merge Request includes:
- [ ] Tests
- [x] A changelog fragment (cf https://docs.funkwhale.audio/contributing.html#changelog-management)AMoonRabbitMargeAMoonRabbit