funkwhale merge requestshttps://dev.funkwhale.audio/funkwhale/funkwhale/-/merge_requests2022-05-01T09:31:25Zhttps://dev.funkwhale.audio/funkwhale/funkwhale/-/merge_requests/1301Only suggest existing tag once2022-05-01T09:31:25ZMartin GigerOnly suggest existing tag onceRelated issue: #1427 <!-- it's okay to have no issue for small changes -->
This Merge Request includes:
- [ ] Tests
- [x] A changelog fragment (cf https://docs.funkwhale.audio/contributing.html#changelog-management)Related issue: #1427 <!-- it's okay to have no issue for small changes -->
This Merge Request includes:
- [ ] Tests
- [x] A changelog fragment (cf https://docs.funkwhale.audio/contributing.html#changelog-management)1.1.3Ciarán Ainsworthsporiff@funkwhale.audioCiarán Ainsworthsporiff@funkwhale.audiohttps://dev.funkwhale.audio/funkwhale/funkwhale/-/merge_requests/1353Draft: Resolve "Improve tagging of released docker images"2021-08-01T19:34:30ZGeorg KrauseDraft: Resolve "Improve tagging of released docker images"Closes #1505Closes #15051.1.3Georg KrauseGeorg Krausehttps://dev.funkwhale.audio/funkwhale/funkwhale/-/merge_requests/1352Resolve "prevent open redirect on login"2021-07-26T18:54:15ZCiarán Ainsworthsporiff@funkwhale.audioResolve "prevent open redirect on login"Closes #1492
Attempts to resolve any URL/route passed as a `next` param to the `login` view. Routes that do not exist in the route will be removed and replaced with `/library` to push users to `library`. Any internal routes will push u...Closes #1492
Attempts to resolve any URL/route passed as a `next` param to the `login` view. Routes that do not exist in the route will be removed and replaced with `/library` to push users to `library`. Any internal routes will push users as expected.1.1.3Ciarán Ainsworthsporiff@funkwhale.audioCiarán Ainsworthsporiff@funkwhale.audiohttps://dev.funkwhale.audio/funkwhale/funkwhale/-/merge_requests/1351Add beforeRouteEnter guards for moderation pages2021-07-26T18:08:17ZCiarán Ainsworthsporiff@funkwhale.audioAdd beforeRouteEnter guards for moderation pagesCloses #1494
Adds `beforeRouteEnter` guards to `manage` routes. The permissions match those in the frontend. Unauthenticated users or users without sufficient permissions will be routed back to library page.
This change makes the `sto...Closes #1494
Adds `beforeRouteEnter` guards to `manage` routes. The permissions match those in the frontend. Unauthenticated users or users without sufficient permissions will be routed back to library page.
This change makes the `store` available in the router for any other changes we may need to make and removes the `router` import from the store `auth` file. This is to break the dependency hell caused by importing each into one another.1.1.3Ciarán Ainsworthsporiff@funkwhale.audioCiarán Ainsworthsporiff@funkwhale.audiohttps://dev.funkwhale.audio/funkwhale/funkwhale/-/merge_requests/1330Resolve "Worker-Src missing in CSP-Header of nginx config"2021-07-02T20:56:38ZGeorg KrauseResolve "Worker-Src missing in CSP-Header of nginx config"Closes #1489Closes #14891.1.3Georg KrauseGeorg Krausehttps://dev.funkwhale.audio/funkwhale/funkwhale/-/merge_requests/1326Fix the scrobbler plugin submitting literal "None" as MusicBrainz ID2021-06-17T11:21:42ZPhilipp WolferFix the scrobbler plugin submitting literal "None" as MusicBrainz IDThe scrobbler plugin would submit the string value `"None"` if `track.mbid` is empty.
According to last.fm scrobber 1.2 docs (https://web.archive.org/web/20090217162831/http://last.fm/api/submissions) it should be:
> The MusicBrainz T...The scrobbler plugin would submit the string value `"None"` if `track.mbid` is empty.
According to last.fm scrobber 1.2 docs (https://web.archive.org/web/20090217162831/http://last.fm/api/submissions) it should be:
> The MusicBrainz Track ID, or an empty string if not known.
According to the 2.0 scrobble API https://www.last.fm/api/show/track.scrobble it is
> mbid[i] (Optional) : The MusicBrainz Track ID.
That indicates an empty value is ok. But in any case `"None"` is not :)
Fixes #1498
Closes #14981.1.3