funkwhale merge requestshttps://dev.funkwhale.audio/funkwhale/funkwhale/-/merge_requests2020-06-05T04:21:58Zhttps://dev.funkwhale.audio/funkwhale/funkwhale/-/merge_requests/1106Add distraction username field to sop up autocomplete in Firefox2020-06-05T04:21:58ZinterfectAdd distraction username field to sop up autocomplete in FirefoxRelated issue: #1090 <!-- it's okay to have no issue for small changes -->
This Merge Request includes:
- [ ] Tests (N/A? I don't think the testing system pulls in Firefox to auto-test on.)
- [x] A changelog fragment (cf https://d...Related issue: #1090 <!-- it's okay to have no issue for small changes -->
This Merge Request includes:
- [ ] Tests (N/A? I don't think the testing system pulls in Firefox to auto-test on.)
- [x] A changelog fragment (cf https://docs.funkwhale.audio/contributing.html#changelog-management)0.21.1https://dev.funkwhale.audio/funkwhale/funkwhale/-/merge_requests/1107Fix #1085: Make URL-building logic more resilient against reverse proxy misco...2020-05-04T10:20:23ZAgateFix #1085: Make URL-building logic more resilient against reverse proxy misconfigurationCloses #1085Closes #10850.21.1https://dev.funkwhale.audio/funkwhale/funkwhale/-/merge_requests/1108Fix #1096: Fixed wrong album and track count in admin artist API2020-05-04T10:18:49ZAgateFix #1096: Fixed wrong album and track count in admin artist APICloses #1096Closes #10960.21.1https://dev.funkwhale.audio/funkwhale/funkwhale/-/merge_requests/1109Fix #1082: issue when displaying starred tracks on subsonic2020-05-04T11:20:33ZAgateFix #1082: issue when displaying starred tracks on subsonicCloses #1082Closes #10820.21.1https://dev.funkwhale.audio/funkwhale/funkwhale/-/merge_requests/1110Fix #1093: mimetype detection issue that broke transcoding on certain tracks2020-05-04T11:57:38ZAgateFix #1093: mimetype detection issue that broke transcoding on certain tracksCloses #1093Closes #10930.21.1https://dev.funkwhale.audio/funkwhale/funkwhale/-/merge_requests/1113Resolve "Inject instance name in HTML title"2020-05-25T20:14:46ZAgateResolve "Inject instance name in HTML title"Closes #1107Closes #11070.21.1https://dev.funkwhale.audio/funkwhale/funkwhale/-/merge_requests/1114Fix #1091: page not refreshing when switching between My Library and Explore ...2020-05-06T08:44:09ZAgateFix #1091: page not refreshing when switching between My Library and Explore sectionsCloses #1091
Underlying issue was that the same set of components is used for both sections. However, vue-router attempts to reuse the component if possible, hence the problem.Closes #1091
Underlying issue was that the same set of components is used for both sections. However, vue-router attempts to reuse the component if possible, hence the problem.0.21.1https://dev.funkwhale.audio/funkwhale/funkwhale/-/merge_requests/1115Fix #1087: Fix playlist modal only listing 50 first playlists2020-05-07T11:18:39ZAgateFix #1087: Fix playlist modal only listing 50 first playlistsCloses #1087Closes #10870.21.1https://dev.funkwhale.audio/funkwhale/funkwhale/-/merge_requests/1116Fix #1086: Added safeguard to ensure local uploads are never purged from cache2020-05-07T12:05:41ZAgateFix #1086: Added safeguard to ensure local uploads are never purged from cacheCloses #1086Closes #10860.21.1https://dev.funkwhale.audio/funkwhale/funkwhale/-/merge_requests/1117Fix #1011: Ensure tracks linked to skipped upload can be pruned2020-05-07T11:55:59ZAgateFix #1011: Ensure tracks linked to skipped upload can be prunedCloses #1011Closes #10110.21.1https://dev.funkwhale.audio/funkwhale/funkwhale/-/merge_requests/1121Fix #1078: Include tracks by album artist when filtering by artist on /api/v1...2020-05-07T14:48:11ZAgateFix #1078: Include tracks by album artist when filtering by artist on /api/v1/tracksCloses #1078Closes #10780.21.1https://dev.funkwhale.audio/funkwhale/funkwhale/-/merge_requests/1122Fix #1092: Ensure player doesn't disappear when last queue track is removed m...2020-05-07T15:55:34ZAgateFix #1092: Ensure player doesn't disappear when last queue track is removed manuallyCloses #1092Closes #10920.21.1https://dev.funkwhale.audio/funkwhale/funkwhale/-/merge_requests/1123Resolve "Removed masonry"2020-05-07T16:39:31ZAgateResolve "Removed masonry"Closes #1112Closes #11120.21.1https://dev.funkwhale.audio/funkwhale/funkwhale/-/merge_requests/1129Fix support for Python 3.5 in import script2020-06-05T04:09:47ZCiarán Ainsworthsporiff@funkwhale.audioFix support for Python 3.5 in import scriptFix #1148 and #1147 XXX <!-- it's okay to have no issue for small changes -->
This Merge Request includes:
- [x] A changelog fragment (cf https://docs.funkwhale.audio/contributing.html#changelog-management)
This MR fixes compati...Fix #1148 and #1147 XXX <!-- it's okay to have no issue for small changes -->
This Merge Request includes:
- [x] A changelog fragment (cf https://docs.funkwhale.audio/contributing.html#changelog-management)
This MR fixes compatibility with Python < 3.6. The `os.scandir()` method didn't receive context support until 3.6, so users of Debian 9 (mostly Yunohost users) cannot run the script as of version 0.21 as seen in the above issues. Since we are supporting 3.5 until version 1.0, this should probably be fixed for 0.21.1.
This has been tested on my Yunohost server running Debian 9, Python 3.5.
CC @funkwhale/reviewers-python0.21.1Ciarán Ainsworthsporiff@funkwhale.audioCiarán Ainsworthsporiff@funkwhale.audiohttps://dev.funkwhale.audio/funkwhale/funkwhale/-/merge_requests/1130Resolve "X episodes instead of X tracks on Artist channel page"2020-06-05T08:38:52ZAgateResolve "X episodes instead of X tracks on Artist channel page"Closes #1117
# Before
![Screenshot_20200605_052931](/uploads/fbda734c45615784f84b584e30fd3c87/Screenshot_20200605_052931.png)
# After
![Screenshot_20200605_052911](/uploads/7f53cc80cc425befc22b475a15209b61/Screenshot_2020060...Closes #1117
# Before
![Screenshot_20200605_052931](/uploads/fbda734c45615784f84b584e30fd3c87/Screenshot_20200605_052931.png)
# After
![Screenshot_20200605_052911](/uploads/7f53cc80cc425befc22b475a15209b61/Screenshot_20200605_052911.png)
cc @funkwhale/reviewers-front0.21.1https://dev.funkwhale.audio/funkwhale/funkwhale/-/merge_requests/1131Resolve "Add "New channels" widget on landing page"2020-06-05T08:38:38ZAgateResolve "Add "New channels" widget on landing page"Closes #1113
(don't mind the sidebar, my screenshot tool is confused by the fixed layout)
![image](/uploads/28a30c2b13e72c57b53df123f10924df/image.png)
cc @funkwhale/reviewers-frontCloses #1113
(don't mind the sidebar, my screenshot tool is confused by the fixed layout)
![image](/uploads/28a30c2b13e72c57b53df123f10924df/image.png)
cc @funkwhale/reviewers-front0.21.1https://dev.funkwhale.audio/funkwhale/funkwhale/-/merge_requests/1132Revert "Merge branch 'fix-import-python-3-5' into 'develop'"2020-06-05T04:36:57ZAgateRevert "Merge branch 'fix-import-python-3-5' into 'develop'"This reverts merge request !1129. reopens #1147 and #1148
Unfortunately, this breaks on higher versions of Python with
```
Starting import of new files…
Traceback (most recent call last):
File "manage.py", line 27, in <module>...This reverts merge request !1129. reopens #1147 and #1148
Unfortunately, this breaks on higher versions of Python with
```
Starting import of new files…
Traceback (most recent call last):
File "manage.py", line 27, in <module>
execute_from_command_line(sys.argv)
File "/venv/lib/python3.7/site-packages/django/core/management/__init__.py", line 401, in execute_from_command_line
utility.execute()
File "/venv/lib/python3.7/site-packages/django/core/management/__init__.py", line 395, in execute
self.fetch_command(subcommand).run_from_argv(self.argv)
File "/venv/lib/python3.7/site-packages/django/core/management/base.py", line 328, in run_from_argv
self.execute(*args, **cmd_options)
File "/venv/lib/python3.7/site-packages/django/core/management/base.py", line 369, in execute
output = self.handle(*args, **options)
File "/venv/lib/python3.7/site-packages/django/core/management/commands/shell.py", line 92, in handle
exec(sys.stdin.read())
File "<string>", line 28, in <module>
File "/venv/lib/python3.7/site-packages/django/core/management/__init__.py", line 168, in call_command
return command.execute(*args, **defaults)
File "/venv/lib/python3.7/site-packages/django/core/management/base.py", line 369, in execute
output = self.handle(*args, **options)
File "/app/funkwhale_api/music/management/commands/import_files.py", line 307, in handle
for i, entries in enumerate(batch(crawler, options["batch_size"])):
File "/app/funkwhale_api/music/management/commands/import_files.py", line 58, in batch
current.append(next(iterable))
File "/app/funkwhale_api/music/management/commands/import_files.py", line 46, in crawl_dir
yield from dir_scanner(scanner, extensions, recursive, ignored)
File "/app/funkwhale_api/music/management/commands/import_files.py", line 35, in dir_scanner
entry, extensions, recursive=recursive, ignored=ignored
File "/app/funkwhale_api/music/management/commands/import_files.py", line 27, in dir_scanner
for entry in scanner:
TypeError: 'posix.DirEntry' object is not iterable
```0.21.1https://dev.funkwhale.audio/funkwhale/funkwhale/-/merge_requests/1133Resolve "Firefox auto-fills your remembered username in the search box if you...2020-06-05T04:25:21ZAgateResolve "Firefox auto-fills your remembered username in the search box if you open the user settings page"Closes #1090, supersedes !1106
@interfect, I found out an easier solution, which was setting the "search" type on the search field ;) (via https://gist.github.com/runspired/b9fdf1fa74fc9fb4554418dea35718fe#gistcomment-2725790)Closes #1090, supersedes !1106
@interfect, I found out an easier solution, which was setting the "search" type on the search field ;) (via https://gist.github.com/runspired/b9fdf1fa74fc9fb4554418dea35718fe#gistcomment-2725790)0.21.1https://dev.funkwhale.audio/funkwhale/funkwhale/-/merge_requests/1134Resolve "CLI in-place import impossible with virtualenv with python3.5"2020-06-05T08:42:57ZAgateResolve "CLI in-place import impossible with virtualenv with python3.5"Closes #1148
Also add a unit test that helped reproducing the errorCloses #1148
Also add a unit test that helped reproducing the error0.21.1https://dev.funkwhale.audio/funkwhale/funkwhale/-/merge_requests/1135Fix #1151: Updated the /api/v1/libraries endpoint to support listing public l...2020-06-05T09:26:56ZAgateFix #1151: Updated the /api/v1/libraries endpoint to support listing public libraries of a podCloses #1151Closes #11510.21.1