funkwhale merge requestshttps://dev.funkwhale.audio/funkwhale/funkwhale/-/merge_requests2020-03-31T14:26:45Zhttps://dev.funkwhale.audio/funkwhale/funkwhale/-/merge_requests/1073See #170: fetch channel outbox on discovery/detail2020-03-31T14:26:45ZAgateSee #170: fetch channel outbox on discovery/detailSee #170:
- [x] When channel is first discovered, retrieve the first page of outbox
- [x] Launch additional tasks to fetch more pages of the outbox (5 by default, so 250 items)
- [x] Refresh from time to time in the UI when browsing a c...See #170:
- [x] When channel is first discovered, retrieve the first page of outbox
- [x] Launch additional tasks to fetch more pages of the outbox (5 by default, so 250 items)
- [x] Refresh from time to time in the UI when browsing a channel, in cased we missed delivery0.21https://dev.funkwhale.audio/funkwhale/funkwhale/-/merge_requests/1072See #170: admin UI for channels, reporting channels2020-03-31T08:45:43ZAgateSee #170: admin UI for channels, reporting channelsSee #170:
- [x] Browsing channels in admin (with search, filters, etc.)
- [x] Detailing channels in admin
- [x] Redirect artist to channels in admin UI, when applicable
- [x] UI to report channels
- [x] UI to manage reported channels
-...See #170:
- [x] Browsing channels in admin (with search, filters, etc.)
- [x] Detailing channels in admin
- [x] Redirect artist to channels in admin UI, when applicable
- [x] UI to report channels
- [x] UI to manage reported channels
- [x] Tweaks to ensure reports linked to channels federate properly0.21https://dev.funkwhale.audio/funkwhale/funkwhale/-/merge_requests/1070Fix #1064: routing issue when browsing library2020-03-30T09:50:18ZAgateFix #1064: routing issue when browsing libraryCloses #1064Closes #10640.21https://dev.funkwhale.audio/funkwhale/funkwhale/-/merge_requests/1069Fix #1065: irrelevant redirection to HTML repr of a library2020-03-30T08:03:31ZAgateFix #1065: irrelevant redirection to HTML repr of a libraryCloses #1065Closes #10650.21https://dev.funkwhale.audio/funkwhale/funkwhale/-/merge_requests/1068See #170: single track page redesign2020-03-26T15:40:36ZAgateSee #170: single track page redesignSee #170
![Peek_2020-03-26_16-18](/uploads/72f4f8d1d0a51059c7008fc0012a6c73/Peek_2020-03-26_16-18.mp4)See #170
![Peek_2020-03-26_16-18](/uploads/72f4f8d1d0a51059c7008fc0012a6c73/Peek_2020-03-26_16-18.mp4)0.21https://dev.funkwhale.audio/funkwhale/funkwhale/-/merge_requests/1067Fix #1060: Added a new radio based on another user listenings2020-03-25T21:44:34ZAgateFix #1060: Added a new radio based on another user listenings- [x] Register listening after 15s (instead of at the end of the track)
- [x] Add a radio button on user profiles, that start a custom, client side only radio based on the user listening
- [x] When `Listen` websocket events are dispatche...- [x] Register listening after 15s (instead of at the end of the track)
- [x] Add a radio button on user profiles, that start a custom, client side only radio based on the user listening
- [x] When `Listen` websocket events are dispatched, if the radio is started and the user match the one of the radio, append the Listen track to the queue0.21https://dev.funkwhale.audio/funkwhale/funkwhale/-/merge_requests/1066See #170: Funkwhale federation2020-03-25T14:32:11ZAgateSee #170: Funkwhale federationSee #170:
- [x] Broadcast delete (channel /track / album)
- [x] Handle audio activities from Funkwhale servers
- [x] Ensure funkwhale->funkwhale follows work properly
- [x] Create channel from actor if relevant metadata is present
- [x]...See #170:
- [x] Broadcast delete (channel /track / album)
- [x] Handle audio activities from Funkwhale servers
- [x] Ensure funkwhale->funkwhale follows work properly
- [x] Create channel from actor if relevant metadata is present
- [x] Redirect to channel when fetching actor channel in the UI
- [x] Ensure channel audio includes all necessary stuff: License, copyright, bitrate, position, duration, disc, album, etc.
- [x] If album artist belongs to a channel, then assign the album to the channel artist0.21https://dev.funkwhale.audio/funkwhale/funkwhale/-/merge_requests/1065Fixed empty results issue when browsing library with playable filter2020-03-24T09:36:35ZAgateFixed empty results issue when browsing library with playable filter0.21https://dev.funkwhale.audio/funkwhale/funkwhale/-/merge_requests/1064See #170: switch to PKCS#8 for public key serialization2020-03-25T08:34:42ZAgateSee #170: switch to PKCS#8 for public key serializationCF https://github.com/friendica/friendica/issues/7771#issuecomment-603019826CF https://github.com/friendica/friendica/issues/7771#issuecomment-6030198260.21https://dev.funkwhale.audio/funkwhale/funkwhale/-/merge_requests/1063Faster tests2020-03-23T15:22:21ZAgateFaster tests# Optimizations
- Don't create artist, albums and track covers for test that don't actually need them
- Use a cached RSA key pair for actors in tests, instead of generating a new one each time
# Before (on my local computer)
API Test ...# Optimizations
- Don't create artist, albums and track covers for test that don't actually need them
- Use a cached RSA key pair for actors in tests, instead of generating a new one each time
# Before (on my local computer)
API Test suite runs in 265.52s
# After (on my local computer)
API Test suite runs in 163.85s (almost twice as fast!)0.21https://dev.funkwhale.audio/funkwhale/funkwhale/-/merge_requests/1062See #170: ensure fetch works properly on tracks with public upload2020-03-23T12:00:24ZAgateSee #170: ensure fetch works properly on tracks with public uploadSee #170See #1700.21https://dev.funkwhale.audio/funkwhale/funkwhale/-/merge_requests/1061Update configuration.rst for unsafe characters in URLs2020-03-23T10:39:00ZEorn le goélandUpdate configuration.rst for unsafe characters in URLsFix #1049.
This Merge Request includes:
- notes about the need to urlencode variables that are URLsFix #1049.
This Merge Request includes:
- notes about the need to urlencode variables that are URLs0.21https://dev.funkwhale.audio/funkwhale/funkwhale/-/merge_requests/1060See #170: subscriptions management UI2020-03-23T09:44:11ZAgateSee #170: subscriptions management UISee #170
- [x] List recently updated subscriptions in the sidebar
- [x] New `/subscriptions` ui to list/search among subscriptions and add new subscriptions
## Demo
![Peek_2020-03-19_16-13](/uploads/91d0135daedf3fb737acc9742267b99f/P...See #170
- [x] List recently updated subscriptions in the sidebar
- [x] New `/subscriptions` ui to list/search among subscriptions and add new subscriptions
## Demo
![Peek_2020-03-19_16-13](/uploads/91d0135daedf3fb737acc9742267b99f/Peek_2020-03-19_16-13.mp4)0.21https://dev.funkwhale.audio/funkwhale/funkwhale/-/merge_requests/1059See #170: store and compute modification date on artists2020-03-19T13:47:26ZAgateSee #170: store and compute modification date on artistsSee #170
Useful to list channels that were updated recently.See #170
Useful to list channels that were updated recently.0.21https://dev.funkwhale.audio/funkwhale/funkwhale/-/merge_requests/1058See #170: API for OPML export2020-03-19T08:52:54ZAgateSee #170: API for OPML exportSee #170
Accessible at `/api/v1/channels?output=opml`. Support all the filters available for channels (e.g `subscribed=true`)See #170
Accessible at `/api/v1/channels?output=opml`. Support all the filters available for channels (e.g `subscribed=true`)0.21https://dev.funkwhale.audio/funkwhale/funkwhale/-/merge_requests/1057See #170: subsonic API for podcasts2020-03-18T14:52:24ZAgateSee #170: subsonic API for podcastsSee #170
Tested with DSubSee #170
Tested with DSub0.21https://dev.funkwhale.audio/funkwhale/funkwhale/-/merge_requests/1056Resolve "Screening for signups"2020-03-18T10:57:35ZAgateResolve "Screening for signups"Closes #1040
- [x] Signup form with custom fields / help text
- [x] Email to notify mods
- [x] Email to notify user when approved/refused
- [x] Account is inactive while request is pending
- [x] Moderator API to review reque...Closes #1040
- [x] Signup form with custom fields / help text
- [x] Email to notify mods
- [x] Email to notify user when approved/refused
- [x] Account is inactive while request is pending
- [x] Moderator API to review requests
- [x] Moderator UI to review requests
## Demo
![Peek_2020-03-18_11-56](/uploads/21dd3a8cf804bcec990fe00ae6c827f4/Peek_2020-03-18_11-56.mp4)0.21https://dev.funkwhale.audio/funkwhale/funkwhale/-/merge_requests/1055See #170: subscribe to 3d-party RSS feeds in Funkwhale2020-03-13T13:26:27ZAgateSee #170: subscribe to 3d-party RSS feeds in FunkwhaleSee #170:
- [x] Channel has a random actor
- [x] Library is private
- [x] Disable RSS feed for external channels
- [x] Subscribe by RSS feed on existing Funkwhale channel
- [x] We use the channel UUID in the url (since actor is r...See #170:
- [x] Channel has a random actor
- [x] Library is private
- [x] Disable RSS feed for external channels
- [x] Subscribe by RSS feed on existing Funkwhale channel
- [x] We use the channel UUID in the url (since actor is random, and we don't expose the actor at all in the API results)
- [x] Channel is unreachable if not subscribed to
- [x] Subscribing checks if the channel has valid XML / entries
- [x] Hide channel actors attributed to service_actor
- [x] Hide channel actor from channel response if it's service actor
- [x] Include alternate link to activity+json actor, to avoid having duplicate actors / rss feeds
- [x] Tasks and settings to refetch feeds periodically
- [x] Update denormalization for created uploads
- [x] Honor domain block when fetching RSS feed
- [x] Search bar/page to subscribe to feed
- [x] Test with a Funkwhale emitted feed
cf https://mastodon.eliotberriot.com/@eliotberriot/1038157475758358380.21https://dev.funkwhale.audio/funkwhale/funkwhale/-/merge_requests/1054See #170: friendica and AP compat2020-03-11T15:40:38ZAgateSee #170: friendica and AP compatSee #170
Bunch of commits to improve UX/UI oraround federation or fix compat issuesSee #170
Bunch of commits to improve UX/UI oraround federation or fix compat issues0.21https://dev.funkwhale.audio/funkwhale/funkwhale/-/merge_requests/1053Fix #1036: Favor local uploads when playing a track with multiple uploads2020-03-11T13:15:01ZAgateFix #1036: Favor local uploads when playing a track with multiple uploadsCloses #1036Closes #10360.21