funkwhale merge requestshttps://dev.funkwhale.audio/funkwhale/funkwhale/-/merge_requests2019-06-28T07:37:30Zhttps://dev.funkwhale.audio/funkwhale/funkwhale/-/merge_requests/808Resolve "Cannot edit users details"2019-06-28T07:37:30ZAgateResolve "Cannot edit users details"Closes #869
The problem was that `/manage/users/users` (the UI for local accounts only) while the API endpoint expects a federation username. In some circumstances, the two values can differ because we have a strict policy on allowed...Closes #869
The problem was that `/manage/users/users` (the UI for local accounts only) while the API endpoint expects a federation username. In some circumstances, the two values can differ because we have a strict policy on allowed characters in the federation username, and strip everything but letters, digits and underscores. A user having a `test.example` username would actually get a `testexample` federation username.
cc @funkwhale/reviewers-python0.19.1https://dev.funkwhale.audio/funkwhale/funkwhale/-/merge_requests/807Resolve "Provide a default format when transcoding via Subsonic"2019-06-28T07:59:58ZAgateResolve "Provide a default format when transcoding via Subsonic"Closes #867
Basically, it enforces a default MP3 format (but configurable via the `SUBSONIC_DEFAULT_TRANSCODING_FORMAT` env var) when: the `maxBirate` parameter is passed AND `!= 0` AND the `format` parameter is missing or empty.
...Closes #867
Basically, it enforces a default MP3 format (but configurable via the `SUBSONIC_DEFAULT_TRANSCODING_FORMAT` env var) when: the `maxBirate` parameter is passed AND `!= 0` AND the `format` parameter is missing or empty.
cc @funkwhale/reviewers-python0.19.1https://dev.funkwhale.audio/funkwhale/funkwhale/-/merge_requests/806Added opus to supported mimetymes and extensions2019-06-27T09:25:02ZAgateAdded opus to supported mimetymes and extensionsCloses #868
cc @jiri-novacekCloses #868
cc @jiri-novacek0.19.1https://dev.funkwhale.audio/funkwhale/funkwhale/-/merge_requests/803Resolve "Importing tracks without album fails"2019-06-26T08:38:30ZAgateResolve "Importing tracks without album fails"Closes #122
cc @dashie and @funkwhale/reviewers-pythonCloses #122
cc @dashie and @funkwhale/reviewers-python0.19.1https://dev.funkwhale.audio/funkwhale/funkwhale/-/merge_requests/802Cherry pick develop2019-06-25T09:10:08ZAgateCherry pick developCherry-pick of a few commits that shoud be included in the %"0.19.1" release.Cherry-pick of a few commits that shoud be included in the %"0.19.1" release.0.19.1https://dev.funkwhale.audio/funkwhale/funkwhale/-/merge_requests/795Resolve "Clicking on playlist name from PlaylistModal does nothing if current...2019-06-24T09:04:11ZCiarán Ainsworthsporiff@funkwhale.audioResolve "Clicking on playlist name from PlaylistModal does nothing if current page is that playlist's page"After playing about with Route Guards for a while it seems like this happens because technically the route isn't updating at all if you click on the currently selected playlist. Adding an on-click event to close the modal regardless of i...After playing about with Route Guards for a while it seems like this happens because technically the route isn't updating at all if you click on the currently selected playlist. Adding an on-click event to close the modal regardless of its destination addresses this as the modal should always close when navigating.
![Fix](/uploads/21c1767595e43fccf90fcb1d813c936c/Fix.webm)
Closes #8070.19.1Ciarán Ainsworthsporiff@funkwhale.audioCiarán Ainsworthsporiff@funkwhale.audiohttps://dev.funkwhale.audio/funkwhale/funkwhale/-/merge_requests/794Resolve "Align items vertically in search results"2019-06-24T09:32:27ZCiarán Ainsworthsporiff@funkwhale.audioResolve "Align items vertically in search results"This setting should align the title of the search query (artist, album, track) and the results to center, making it much cleaner when returning one or more results.
![One_artist](/uploads/1ae09623e06bd69916a411dd558b5055/One_artist.pn...This setting should align the title of the search query (artist, album, track) and the results to center, making it much cleaner when returning one or more results.
![One_artist](/uploads/1ae09623e06bd69916a411dd558b5055/One_artist.png)
![multi](/uploads/1088629e8ff22b7b1519fb772535b2e4/multi.png)
Closes #7080.19.1Ciarán Ainsworthsporiff@funkwhale.audioCiarán Ainsworthsporiff@funkwhale.audiohttps://dev.funkwhale.audio/funkwhale/funkwhale/-/merge_requests/792Fix #864: Redirect from / to /library when user is logged in2019-06-24T11:31:14ZAgateFix #864: Redirect from / to /library when user is logged inCloses #864Closes #8640.19.1https://dev.funkwhale.audio/funkwhale/funkwhale/-/merge_requests/787Resolve "add Discogs search"2019-06-17T06:15:12ZCiarán Ainsworthsporiff@funkwhale.audioResolve "add Discogs search"Closes #368Closes #3680.19.1https://dev.funkwhale.audio/funkwhale/funkwhale/-/merge_requests/785Resolve ""This backend doesn't support absolute paths" when uploading certain...2019-06-17T06:25:25ZAgateResolve ""This backend doesn't support absolute paths" when uploading certain tracks"Closes #857
Quite a simple fix: instead of using the file *path* to guess the mimetype (when guessing from file content fails), which is unsupported on S3 storages, we use the file *name*, which works seamlessly!
@funkwhale/revie...Closes #857
Quite a simple fix: instead of using the file *path* to guess the mimetype (when guessing from file content fails), which is unsupported on S3 storages, we use the file *name*, which works seamlessly!
@funkwhale/reviewers-python0.19.1https://dev.funkwhale.audio/funkwhale/funkwhale/-/merge_requests/784Fix #833: broken translation on homepage2019-06-17T06:25:47ZAgateFix #833: broken translation on homepageCloses #833
This specific translation had HTML in it, and it's usually causing such problems. Moving it to javascript fixed it :)Closes #833
This specific translation had HTML in it, and it's usually causing such problems. Moving it to javascript fixed it :)0.19.1https://dev.funkwhale.audio/funkwhale/funkwhale/-/merge_requests/783Fix #814: Added copy-to-clipboard button with Subsonic password input2019-06-12T08:41:34ZAgateFix #814: Added copy-to-clipboard button with Subsonic password inputCloses #814
- Adds a "copy-to-clipboard" button next to the subsonic password
- Automatically reveal the password during creation/change to avoid copy-pasting the "hidden password dots"
![Peek_2019-06-11_13-46](/uploads/723964a1b7e9e...Closes #814
- Adds a "copy-to-clipboard" button next to the subsonic password
- Automatically reveal the password during creation/change to avoid copy-pasting the "hidden password dots"
![Peek_2019-06-11_13-46](/uploads/723964a1b7e9ee349d7d7a8c1765c9bb/Peek_2019-06-11_13-46.mp4)0.19.1https://dev.funkwhale.audio/funkwhale/funkwhale/-/merge_requests/782Fix #855: secondary menus truncated on narrow screens2019-06-11T11:13:06ZAgateFix #855: secondary menus truncated on narrow screensCloses #855
This now makes the menu scrollable when needed :)
![Peek_2019-06-11_11-51](/uploads/1ea6bded4798f3497cd4ef5e69b7ab54/Peek_2019-06-11_11-51.mp4)Closes #855
This now makes the menu scrollable when needed :)
![Peek_2019-06-11_11-51](/uploads/1ea6bded4798f3497cd4ef5e69b7ab54/Peek_2019-06-11_11-51.mp4)0.19.1https://dev.funkwhale.audio/funkwhale/funkwhale/-/merge_requests/780Fix #835: Hide pod statistics on about page if those are disabled2019-06-11T08:03:59ZAgateFix #835: Hide pod statistics on about page if those are disabledCloses #835
It just completely hide the stats bloc on the about page if we don't have the minimum data available.
cc @Sporiff Closes #835
It just completely hide the stats bloc on the about page if we don't have the minimum data available.
cc @Sporiff 0.19.1https://dev.funkwhale.audio/funkwhale/funkwhale/-/merge_requests/779Fix #834: Simplified embedded docker reverse proxy IP configuration2019-06-11T07:58:22ZAgateFix #834: Simplified embedded docker reverse proxy IP configurationCloses #834
cc @egon: tested on my own dockerized instance, seems to work great, thank you for the contribution!
cc @Sporiff Closes #834
cc @egon: tested on my own dockerized instance, seems to work great, thank you for the contribution!
cc @Sporiff 0.19.1https://dev.funkwhale.audio/funkwhale/funkwhale/-/merge_requests/778Fix #847: Use ASCII filename before upload to S3 to avoid playback issues2019-06-11T08:04:24ZAgateFix #847: Use ASCII filename before upload to S3 to avoid playback issuesCloses #847
Introduce a new [slugify](https://github.com/mozilla/unicode-slugify) dependency to avoid troubles with non latin filenames, cf [Mastodon](https://mastodon.eliotberriot.com/@eliotberriot/102247691700691956).
This one w...Closes #847
Introduce a new [slugify](https://github.com/mozilla/unicode-slugify) dependency to avoid troubles with non latin filenames, cf [Mastodon](https://mastodon.eliotberriot.com/@eliotberriot/102247691700691956).
This one will translate non-latin characters to something close in latin alphabet, instead of return empty spaces, as our previous implementation did.0.19.1https://dev.funkwhale.audio/funkwhale/funkwhale/-/merge_requests/777Fix #851: wrong og:image url when using S3 storage2019-06-10T10:13:59ZAgateFix #851: wrong og:image url when using S3 storageCloses #851Closes #8510.19.1https://dev.funkwhale.audio/funkwhale/funkwhale/-/merge_requests/776Fix #848: Fixed invalid file extension for transcoded tracks2019-06-10T09:59:44ZAgateFix #848: Fixed invalid file extension for transcoded tracksCloses #848Closes #8480.19.1https://dev.funkwhale.audio/funkwhale/funkwhale/-/merge_requests/775Fix #850: Ensure empty but optional fields in file metadata don't error durin...2019-06-10T09:09:04ZAgateFix #850: Ensure empty but optional fields in file metadata don't error during importCloses #850
Note that the issue wasn't only with `copyright` field, but also license, position, disc number and mbid fields ;)Closes #850
Note that the issue wasn't only with `copyright` field, but also license, position, disc number and mbid fields ;)0.19.1https://dev.funkwhale.audio/funkwhale/funkwhale/-/merge_requests/774Develop cherry pick2019-06-10T07:56:00ZAgateDevelop cherry pickCherry picked a few commits from develop that should be included in the 0.19.1 release:
- aa5fd6b2b7be5c8bc6044b4994a22a374a07b84a Fix websockets reverse proxy
- bc67779303e5ea8bc4fc7552cd7c66e9dc265cd0 Fix French translation for "St...Cherry picked a few commits from develop that should be included in the 0.19.1 release:
- aa5fd6b2b7be5c8bc6044b4994a22a374a07b84a Fix websockets reverse proxy
- bc67779303e5ea8bc4fc7552cd7c66e9dc265cd0 Fix French translation for "Start radio"
- 4ab490eb69cfb7412895316eee3224996b668593 (origin/listenings-filter, listenings-filter) Added username and domain filter on /history/listenings endpoint
- 3814c1101c88207490ace59ad4bca2d493f9dc21 Added some documentation about translations lifecycle
- 7bcf896f3a4e7b77ff5f1a343439f49eccf0b589 Added fix + changelog fragment for #838
- d530aca4d09cc15fc209737f9a7957ac9ee88b9f Resolve "Add documentation for resolver conf"0.19.1