funkwhale merge requestshttps://dev.funkwhale.audio/funkwhale/funkwhale/-/merge_requests2019-01-29T11:28:26Zhttps://dev.funkwhale.audio/funkwhale/funkwhale/-/merge_requests/575Added user upload documentation2019-01-29T11:28:26ZAgateAdded user upload documentation0.18.1https://dev.funkwhale.audio/funkwhale/funkwhale/-/merge_requests/574Translations integration2019-01-29T09:52:18ZAgateTranslations integration0.18.1AgateAgatehttps://dev.funkwhale.audio/funkwhale/funkwhale/-/merge_requests/573Fix #668: list icon alignement on landing page2019-01-29T09:41:31ZAgateFix #668: list icon alignement on landing pageCloses #668Closes #6680.18.1https://dev.funkwhale.audio/funkwhale/funkwhale/-/merge_requests/572Fix #678: Removed potential BREACH exploit because of Gzip compression2019-01-29T09:24:32ZAgateFix #678: Removed potential BREACH exploit because of Gzip compressionCloses #678Closes #6780.18.1https://dev.funkwhale.audio/funkwhale/funkwhale/-/merge_requests/571Resolve "In-place imports cannot be transcoded"2019-01-29T08:32:36ZVierkantorResolve "In-place imports cannot be transcoded"Closes #688
This Merge Request includes:
- [x] Tests
- [x] A changelog fragment (cf https://docs.funkwhale.audio/contributing.html#changelog-management)
In-place imported tracks have no audio_file attribute but only a source a...Closes #688
This Merge Request includes:
- [x] Tests
- [x] A changelog fragment (cf https://docs.funkwhale.audio/contributing.html#changelog-management)
In-place imported tracks have no audio_file attribute but only a source attribute. The transcoding code assumes that the file has an audio_file attribute, so it failed on these cases.
By splitting the transcoding function into one that takes files, and one that takes pydub.AudioSegment, we can make a method on Upload that gives the AudioSegment, either by reading from self.audio_file.open() or open(self.source).
It looks like transcode_file is not used anywhere else, so it could also be an option to delete it entirely and just preserve the function that takes an AudioSegment. Is the function needed for any planned changes?
Another option would be to allow passing open files to transcode_file, which only opens them if it is needed. I'm not sure how to do this idiomatically.0.18.1https://dev.funkwhale.audio/funkwhale/funkwhale/-/merge_requests/569Fixed wrong URL in documentation for funkwhale_proxy.conf file when deploying...2019-01-30T11:04:20ZAgateFixed wrong URL in documentation for funkwhale_proxy.conf file when deploying using Docker0.18.1https://dev.funkwhale.audio/funkwhale/funkwhale/-/merge_requests/568Fix #685: Disable makemigrations in production and misleading message when ru...2019-01-26T21:04:29ZAgateFix #685: Disable makemigrations in production and misleading message when running migrateCloses #685Closes #6850.18.1https://dev.funkwhale.audio/funkwhale/funkwhale/-/merge_requests/567Display progress during file upload2019-01-26T19:48:41ZAgateDisplay progress during file upload0.18.1https://dev.funkwhale.audio/funkwhale/funkwhale/-/merge_requests/566Fix #686: Added name attributes on all inputs to improve UX, especially with ...2019-01-26T17:08:53ZAgateFix #686: Added name attributes on all inputs to improve UX, especially with password managersCloses #686Closes #6860.18.1https://dev.funkwhale.audio/funkwhale/funkwhale/-/merge_requests/564Fix #676: overescaping issue in notifications and album page2019-01-26T12:16:31ZAgateFix #676: overescaping issue in notifications and album pageCloses #676Closes #6760.18.1https://dev.funkwhale.audio/funkwhale/funkwhale/-/merge_requests/563Fix celery issues2019-01-25T14:44:01ZAgateFix celery issuescc @nhaddagcc @nhaddag0.18.1https://dev.funkwhale.audio/funkwhale/funkwhale/-/merge_requests/561Fix #684: Include shared/public playlists in Subsonic API responses2019-01-25T11:14:50ZAgateFix #684: Include shared/public playlists in Subsonic API responsesCloses #684Closes #6840.18.1https://dev.funkwhale.audio/funkwhale/funkwhale/-/merge_requests/560Fix #670: Use proper locale for date-related/duration strings2019-01-25T10:37:02ZAgateFix #670: Use proper locale for date-related/duration stringsCloses #670Closes #6700.18.1https://dev.funkwhale.audio/funkwhale/funkwhale/-/merge_requests/559Fix #683: wrong number of affected elements in bulk action modal2019-01-25T09:34:19ZAgateFix #683: wrong number of affected elements in bulk action modalCloses #683
cc @wrykCloses #683
cc @wryk0.18.1https://dev.funkwhale.audio/funkwhale/funkwhale/-/merge_requests/556Resolve "Error 500 when loading /api/admin/music/track/99104/change/ (edit tr...2019-01-24T13:03:18ZAgateResolve "Error 500 when loading /api/admin/music/track/99104/change/ (edit track via django admin)"Closes #666Closes #6660.18.1