Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Sign in / Register
  • funkwhale funkwhale
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Issues 379
    • Issues 379
    • List
    • Boards
    • Service Desk
    • Milestones
    • Iterations
    • Requirements
  • Merge requests 15
    • Merge requests 15
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
    • Test Cases
  • Deployments
    • Deployments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Container Registry
    • Infrastructure Registry
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Code review
    • Insights
    • Issue
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • funkwhalefunkwhale
  • funkwhalefunkwhale
  • Issues
  • #1612
Closed
Open
Issue created Nov 26, 2021 by Ciarán Ainsworth@SporiffOwner

fix-fomantic-ssh.sh is not portable

When using macOS, trying to bring up the frontend highlights a problem with the fix-fomantic-css.sh frontend script.

Output

$ yarn run fix-fomantic-css
yarn run v1.22.17
$ scripts/fix-fomantic-css.sh
++ dirname scripts/fix-fomantic-css.sh
+ cd scripts/..
+ find node_modules/fomantic-ui-css/components -name '*.min.css' -delete
+ mkdir -p node_modules/fomantic-ui-css/tweaked
+ echo 'Removing google font…'
Removing google font…
+ sed -i '/@import url(/d' node_modules/fomantic-ui-css/components/site.css
sed: 1: "node_modules/fomantic-u ...": extra characters at the end of n command
error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/install for documentation about this command.

This problem is found at https://dev.funkwhale.audio/funkwhale/funkwhale/-/blob/develop/front/scripts/fix-fomantic-css.sh#L8. A hacky workaround is to alter this line as follows:

sed -i.bak '/@import url(/d' node_modules/fomantic-ui-css/components/site.css && rm node_modules/fomantic-ui-css/components/site.css.bak

We need to address the portability of this script.

Assignee
Assign to
Time tracking