Feed RSS can be improved even more
Hi, now that the xmlns:content is implemented !1356 (merged), there are a few things that can be improved in the feed generator.
Sorry for the long post.
I've tested a feed against validator.w3.org and castfeedvalidator.com and this are the warnings:
https://validator.w3.org/feed/check.cgi?url=https%3A%2F%2Fopen.audio%2Fapi%2Fv1%2Fchannels%2Fkde_express%2Frss
line 2, column 1653: itunes:summary should not contain HTML: a
itunes:summary is not recommended anymore by Apple according to this guide, I personally prefer to not generate this tag, but if you want to keep it, It shouldn't contain HTML.
So option A stop using it, option B "planify" the summary. I could try to do it as seems as a easy fix in this lines:
- https://dev.funkwhale.audio/funkwhale/funkwhale/-/blob/develop/api/funkwhale_api/audio/serializers.py#L907
- https://dev.funkwhale.audio/funkwhale/funkwhale/-/blob/develop/api/tests/audio/test_serializers.py#L304
- https://dev.funkwhale.audio/funkwhale/funkwhale/-/blob/develop/api/tests/audio/test_serializers.py#L516
- https://dev.funkwhale.audio/funkwhale/funkwhale/-/blob/develop/api/tests/audio/test_serializers.py#L585
- https://dev.funkwhale.audio/funkwhale/funkwhale/-/blob/develop/api/tests/audio/test_serializers.py#L786
line 2, column 6122: itunes:summary should not contain HTML: p (3 occurrences)
Same problem as above but in items.
- https://dev.funkwhale.audio/funkwhale/funkwhale/-/blob/develop/api/funkwhale_api/audio/serializers.py#L845
- https://dev.funkwhale.audio/funkwhale/funkwhale/-/blob/develop/api/tests/audio/test_serializers.py#L361
- https://dev.funkwhale.audio/funkwhale/funkwhale/-/blob/develop/api/tests/audio/test_serializers.py#L644
- https://dev.funkwhale.audio/funkwhale/funkwhale/-/blob/develop/api/tests/audio/test_serializers.py#L716
- https://dev.funkwhale.audio/funkwhale/funkwhale/-/blob/develop/api/tests/audio/test_serializers.py#L799
line 2, column 2108: Use commas to separate keywords
Commit 3a83290c and !1229 (merged) fixed this for the items but not the channel.
As above it could be deleted or fixed in:
- https://dev.funkwhale.audio/funkwhale/funkwhale/-/blob/develop/api/funkwhale_api/audio/serializers.py#L924
- https://dev.funkwhale.audio/funkwhale/funkwhale/-/blob/develop/api/tests/audio/test_serializers.py#L363
- https://dev.funkwhale.audio/funkwhale/funkwhale/-/blob/develop/api/tests/audio/test_serializers.py#L505
- https://dev.funkwhale.audio/funkwhale/funkwhale/-/blob/develop/api/tests/audio/test_serializers.py#L574
- https://dev.funkwhale.audio/funkwhale/funkwhale/-/blob/develop/api/tests/audio/test_serializers.py#L648
- https://dev.funkwhale.audio/funkwhale/funkwhale/-/blob/develop/api/tests/audio/test_serializers.py#L720
- https://dev.funkwhale.audio/funkwhale/funkwhale/-/blob/develop/api/tests/audio/test_serializers.py#L775
- https://dev.funkwhale.audio/funkwhale/funkwhale/-/blob/develop/api/tests/audio/test_serializers.py#L803
- https://dev.funkwhale.audio/funkwhale/funkwhale/-/blob/develop/api/tests/audio/test_serializers.py#L818
- https://dev.funkwhale.audio/funkwhale/funkwhale/-/blob/develop/api/tests/audio/test_serializers.py#L833
- https://dev.funkwhale.audio/funkwhale/funkwhale/-/blob/develop/api/tests/audio/test_serializers.py#L913
https://castfeedvalidator.com/?url=https://open.audio/api/v1/channels/kde_express/rss#
Found 3 episodes with no content:encoded tag, which is required if you want to displaly HTML (for example, a link) in Apple Podcasts.
Apple wants xmlns:content schema for this tag, as it is the recommended instead of the summary. This one supports HTML.
I would rather replace summary for this tag, or at least add it and make summary "plain"
Found 3 episodes with no itunes:author tag. This will make it harder for users to find your podcast because Apple Podcasts uses this field for searches.
This is also a easy addition to the feed
Disclaimer
I don't use any Apple product or iTunes, I'm just following the spec and the recommendations. But now I have 2 feeds in Apple podcast to test.