funkwhale-worker.service error option --concurrency (#1160) · Issues · funkwhale / funkwhale

funkwhale-worker.service error option --concurrency

Steps to reproduce

celery: error: argument -c/--concurrency: invalid int value: ''

What happens?

Deploy new instance of funkwhale and start funkwhale-worker.service

What is expected?

Log on started service :

Jun 16 10:27:41 funkwhale systemd[1]: Started Funkwhale celery worker.
Jun 16 10:27:42 funkwhale celery[914]: 2020-06-16 10:27:42,359 funkwhale_api.config INFO     Loaded env file at /srv/funkwhale/config/.env
Jun 16 10:27:42 funkwhale celery[914]: 2020-06-16 10:27:42,366 funkwhale_api.config INFO     Running with no plugins
Jun 16 10:27:44 funkwhale celery[914]: [2020-06-16 08:27:44,665: INFO/MainProcess] Connected to redis://127.0.0.1:6379/0
Jun 16 10:27:44 funkwhale celery[914]: [2020-06-16 08:27:44,672: INFO/MainProcess] mingle: searching for neighbors
Jun 16 10:27:45 funkwhale celery[914]: [2020-06-16 08:27:45,685: INFO/MainProcess] mingle: all alone
Jun 16 10:27:45 funkwhale celery[914]: [2020-06-16 08:27:45,696: INFO/MainProcess] celery@funkwhale ready.
Jun 16 10:28:07 funkwhale systemd[1]: funkwhale-worker.service: Current command vanished from the unit file, execution of the command list won't be resumed.
Jun 16 10:28:09 funkwhale systemd[1]: Stopping Funkwhale celery worker...
Jun 16 10:28:11 funkwhale celery[914]: worker: Warm shutdown (MainProcess)
Jun 16 10:28:11 funkwhale celery[914]:  
Jun 16 10:28:11 funkwhale celery[914]:  -------------- celery@funkwhale v4.3.0 (rhubarb)
Jun 16 10:28:11 funkwhale celery[914]: ---- **** -----
Jun 16 10:28:11 funkwhale celery[914]: --- * ***  * -- Linux-5.7.2-arch1-1-x86_64-with-glibc2.2.5 2020-06-16 08:27:44
Jun 16 10:28:11 funkwhale celery[914]: -- * - **** ---
Jun 16 10:28:11 funkwhale celery[914]: - ** ---------- [config]
Jun 16 10:28:11 funkwhale celery[914]: - ** ---------- .> app:         funkwhale_api:0x7f95b76f9850
Jun 16 10:28:11 funkwhale celery[914]: - ** ---------- .> transport:   redis://127.0.0.1:6379/0
Jun 16 10:28:11 funkwhale celery[914]: - ** ---------- .> results:     disabled://
Jun 16 10:28:11 funkwhale celery[914]: - *** --- * --- .> concurrency: 1 (prefork)
Jun 16 10:28:11 funkwhale celery[914]: -- ******* ---- .> task events: OFF (enable -E to monitor tasks in this worker)
Jun 16 10:28:11 funkwhale celery[914]: --- ***** -----
Jun 16 10:28:11 funkwhale celery[914]:  -------------- [queues]
Jun 16 10:28:11 funkwhale celery[914]:                 .> celery           exchange=celery(direct) key=celery
Jun 16 10:28:11 funkwhale celery[914]:                 
Jun 16 10:28:11 funkwhale celery[914]: [tasks]
Jun 16 10:28:11 funkwhale celery[914]:   . audio.fetch_rss_feed
Jun 16 10:28:11 funkwhale celery[914]:   . audio.fetch_rss_feeds
Jun 16 10:28:11 funkwhale celery[914]:   . common.apply_mutation
Jun 16 10:28:11 funkwhale celery[914]:   . common.prune_unattached_attachments
Jun 16 10:28:11 funkwhale celery[914]:   . federation.clean_music_cache
Jun 16 10:28:11 funkwhale celery[914]:   . federation.deliver_to_remote_inbox
Jun 16 10:28:11 funkwhale celery[914]:   . federation.dispatch_inbox
Jun 16 10:28:11 funkwhale celery[914]:   . federation.dispatch_outbox
Jun 16 10:28:11 funkwhale celery[914]:   . federation.fetch
Jun 16 10:28:11 funkwhale celery[914]:   . federation.fetch_collection
Jun 16 10:28:11 funkwhale celery[914]:   . federation.purge_actors
Jun 16 10:28:11 funkwhale celery[914]:   . federation.refresh_nodeinfo_known_nodes
Jun 16 10:28:11 funkwhale celery[914]:   . federation.remove_actor
Jun 16 10:28:11 funkwhale celery[914]:   . federation.rotate_actor_key
Jun 16 10:28:11 funkwhale celery[914]:   . federation.update_domain_nodeinfo
Jun 16 10:28:11 funkwhale celery[914]:   . moderation.send_new_report_email_to_moderators
Jun 16 10:28:11 funkwhale celery[914]:   . moderation.user_request_handle
Jun 16 10:28:11 funkwhale celery[914]:   . music.albums_set_tags_from_tracks
Jun 16 10:28:11 funkwhale celery[914]:   . music.artists_set_tags_from_tracks
Jun 16 10:28:11 funkwhale celery[914]:   . music.clean_transcoding_cache
Jun 16 10:28:11 funkwhale celery[914]:   . music.process_upload
Jun 16 10:28:11 funkwhale celery[914]:   . music.scan_library_page
Jun 16 10:28:11 funkwhale celery[914]:   . music.start_library_scan
Jun 16 10:28:11 funkwhale celery[914]:   . oauth.clear_expired_tokens
Jun 16 10:28:11 funkwhale celery[914]:   . users.delete_account
Jun 16 10:28:11 funkwhale systemd[1]: funkwhale-worker.service: Succeeded.
Jun 16 10:28:11 funkwhale systemd[1]: Stopped Funkwhale celery worker.
Jun 16 10:28:11 funkwhale systemd[1]: Started Funkwhale celery worker.
Jun 16 10:28:11 funkwhale celery[951]: usage: celery worker [options]
Jun 16 10:28:11 funkwhale celery[951]: celery: error: argument -c/--concurrency: invalid int value: ''
Jun 16 10:28:11 funkwhale systemd[1]: funkwhale-worker.service: Main process exited, code=exited, status=2/INVALIDARGUMENT
Jun 16 10:28:11 funkwhale systemd[1]: funkwhale-worker.service: Failed with result 'exit-code'.

cat /etc/systemd/system/funkwhale-worker.service

[Unit]
Description=Funkwhale celery worker
#After=redis.service postgresql.service
After=network.target postgresql.service redis-server.service nginx.service mount.service
PartOf=funkwhale.target

[Service]
User=funkwhale
# adapt this depending on the path of your funkwhale installation
WorkingDirectory=/srv/funkwhale/api
EnvironmentFile=/srv/funkwhale/config/.env
#ExecStart=/srv/funkwhale/virtualenv/bin/celery -A funkwhale_api.taskapp worker -l INFO --concurrency=${CELERYD_CONCURRENCY-0}
ExecStart=/srv/funkwhale/virtualenv/bin/celery -A funkwhale_api.taskapp worker -l INFO

[Install]
WantedBy=multi-user.target

It's worked for me to remove option

Context

Funkwhale version(s) affected: 0.21.1+git.f14858c2

<!--
Hi there! You are reporting a bug on this project, and we want to thank you!

If it's the first time you post here, please take a moment to read our Code of Conduct
(https://funkwhale.audio/code-of-conduct/) and ensure your issue respect our guidelines.

To ensure your bug report is as useful as possible, please try to stick
to the following structure. You can leave the parts text between `<!- ->`
markers untouched, they won't be displayed in your final message.

Please do not edit the following line, it's used for automatic classification
-->

/label ~"Type: Bug" ~"Status: Need triage"

## Steps to reproduce

<!--
Describe the steps to reproduce the issue, like:

1. Deploy new instance
2. curl -L -o "/etc/systemd/system/funkwhale-worker.service" "https://dev.funkwhale.audio/funkwhale/funkwhale/raw/0.21.1/deploy/funkwhale-worker.service"
3. start service funkwhale-worker.service
--> celery: error: argument -c/--concurrency: invalid int value: ''

## What happens?

Deploy new instance of funkwhale and start funkwhale-worker.service

## What is expected?

Log on started service :
```
Jun 16 10:27:41 funkwhale systemd[1]: Started Funkwhale celery worker.
Jun 16 10:27:42 funkwhale celery[914]: 2020-06-16 10:27:42,359 funkwhale_api.config INFO     Loaded env file at /srv/funkwhale/config/.env
Jun 16 10:27:42 funkwhale celery[914]: 2020-06-16 10:27:42,366 funkwhale_api.config INFO     Running with no plugins
Jun 16 10:27:44 funkwhale celery[914]: [2020-06-16 08:27:44,665: INFO/MainProcess] Connected to redis://127.0.0.1:6379/0
Jun 16 10:27:44 funkwhale celery[914]: [2020-06-16 08:27:44,672: INFO/MainProcess] mingle: searching for neighbors
Jun 16 10:27:45 funkwhale celery[914]: [2020-06-16 08:27:45,685: INFO/MainProcess] mingle: all alone
Jun 16 10:27:45 funkwhale celery[914]: [2020-06-16 08:27:45,696: INFO/MainProcess] celery@funkwhale ready.
Jun 16 10:28:07 funkwhale systemd[1]: funkwhale-worker.service: Current command vanished from the unit file, execution of the command list won't be resumed.
Jun 16 10:28:09 funkwhale systemd[1]: Stopping Funkwhale celery worker...
Jun 16 10:28:11 funkwhale celery[914]: worker: Warm shutdown (MainProcess)
Jun 16 10:28:11 funkwhale celery[914]:  
Jun 16 10:28:11 funkwhale celery[914]:  -------------- celery@funkwhale v4.3.0 (rhubarb)
Jun 16 10:28:11 funkwhale celery[914]: ---- **** -----
Jun 16 10:28:11 funkwhale celery[914]: --- * ***  * -- Linux-5.7.2-arch1-1-x86_64-with-glibc2.2.5 2020-06-16 08:27:44
Jun 16 10:28:11 funkwhale celery[914]: -- * - **** ---
Jun 16 10:28:11 funkwhale celery[914]: - ** ---------- [config]
Jun 16 10:28:11 funkwhale celery[914]: - ** ---------- .> app:         funkwhale_api:0x7f95b76f9850
Jun 16 10:28:11 funkwhale celery[914]: - ** ---------- .> transport:   redis://127.0.0.1:6379/0
Jun 16 10:28:11 funkwhale celery[914]: - ** ---------- .> results:     disabled://
Jun 16 10:28:11 funkwhale celery[914]: - *** --- * --- .> concurrency: 1 (prefork)
Jun 16 10:28:11 funkwhale celery[914]: -- ******* ---- .> task events: OFF (enable -E to monitor tasks in this worker)
Jun 16 10:28:11 funkwhale celery[914]: --- ***** -----
Jun 16 10:28:11 funkwhale celery[914]:  -------------- [queues]
Jun 16 10:28:11 funkwhale celery[914]:                 .> celery           exchange=celery(direct) key=celery
Jun 16 10:28:11 funkwhale celery[914]:                 
Jun 16 10:28:11 funkwhale celery[914]: [tasks]
Jun 16 10:28:11 funkwhale celery[914]:   . audio.fetch_rss_feed
Jun 16 10:28:11 funkwhale celery[914]:   . audio.fetch_rss_feeds
Jun 16 10:28:11 funkwhale celery[914]:   . common.apply_mutation
Jun 16 10:28:11 funkwhale celery[914]:   . common.prune_unattached_attachments
Jun 16 10:28:11 funkwhale celery[914]:   . federation.clean_music_cache
Jun 16 10:28:11 funkwhale celery[914]:   . federation.deliver_to_remote_inbox
Jun 16 10:28:11 funkwhale celery[914]:   . federation.dispatch_inbox
Jun 16 10:28:11 funkwhale celery[914]:   . federation.dispatch_outbox
Jun 16 10:28:11 funkwhale celery[914]:   . federation.fetch
Jun 16 10:28:11 funkwhale celery[914]:   . federation.fetch_collection
Jun 16 10:28:11 funkwhale celery[914]:   . federation.purge_actors
Jun 16 10:28:11 funkwhale celery[914]:   . federation.refresh_nodeinfo_known_nodes
Jun 16 10:28:11 funkwhale celery[914]:   . federation.remove_actor
Jun 16 10:28:11 funkwhale celery[914]:   . federation.rotate_actor_key
Jun 16 10:28:11 funkwhale celery[914]:   . federation.update_domain_nodeinfo
Jun 16 10:28:11 funkwhale celery[914]:   . moderation.send_new_report_email_to_moderators
Jun 16 10:28:11 funkwhale celery[914]:   . moderation.user_request_handle
Jun 16 10:28:11 funkwhale celery[914]:   . music.albums_set_tags_from_tracks
Jun 16 10:28:11 funkwhale celery[914]:   . music.artists_set_tags_from_tracks
Jun 16 10:28:11 funkwhale celery[914]:   . music.clean_transcoding_cache
Jun 16 10:28:11 funkwhale celery[914]:   . music.process_upload
Jun 16 10:28:11 funkwhale celery[914]:   . music.scan_library_page
Jun 16 10:28:11 funkwhale celery[914]:   . music.start_library_scan
Jun 16 10:28:11 funkwhale celery[914]:   . oauth.clear_expired_tokens
Jun 16 10:28:11 funkwhale celery[914]:   . users.delete_account
Jun 16 10:28:11 funkwhale systemd[1]: funkwhale-worker.service: Succeeded.
Jun 16 10:28:11 funkwhale systemd[1]: Stopped Funkwhale celery worker.
Jun 16 10:28:11 funkwhale systemd[1]: Started Funkwhale celery worker.
Jun 16 10:28:11 funkwhale celery[951]: usage: celery worker [options]
Jun 16 10:28:11 funkwhale celery[951]: celery: error: argument -c/--concurrency: invalid int value: ''
Jun 16 10:28:11 funkwhale systemd[1]: funkwhale-worker.service: Main process exited, code=exited, status=2/INVALIDARGUMENT
Jun 16 10:28:11 funkwhale systemd[1]: funkwhale-worker.service: Failed with result 'exit-code'.
```

cat /etc/systemd/system/funkwhale-worker.service
```
[Unit]
Description=Funkwhale celery worker
#After=redis.service postgresql.service
After=network.target postgresql.service redis-server.service nginx.service mount.service
PartOf=funkwhale.target

[Service]
User=funkwhale
# adapt this depending on the path of your funkwhale installation
WorkingDirectory=/srv/funkwhale/api
EnvironmentFile=/srv/funkwhale/config/.env
#ExecStart=/srv/funkwhale/virtualenv/bin/celery -A funkwhale_api.taskapp worker -l INFO --concurrency=${CELERYD_CONCURRENCY-0}
ExecStart=/srv/funkwhale/virtualenv/bin/celery -A funkwhale_api.taskapp worker -l INFO

[Install]
WantedBy=multi-user.target
```

It's worked for me to remove option

## Context

**Funkwhale version(s) affected**: 0.21.1+git.f14858c2

<!--
If relevant, share additional context here like:

- Instance configuration non-docker, nginx as proxy

-->