Subsonic integration: Error when loading list of albums
/label Type: Bug Status: Need triage
Steps to reproduce
- Login into app
- App syncs data down
- Error in logs show, and no album art is displayed
What happens?
No album art is displayed
What is expected?
Not all songs have album art, so I don't mind if they don't get displayed, but it seems the whole request errors out
Context
Funkwhale version(s) affected: 0.21 Subsonic app: Substreamer 4.5.9 Instance configuration: docker
HTTP GET Request: /rest/getAlbumList2.view?u=USERNAME&p=CREDENTIALS&v=1.11.0&c=substreamer&f=json&type=recent&size=36
2020-06-11 14:05:11,027 django.request ERROR Internal Server Error: /api/subsonic/rest/getAlbumList2.view
Traceback (most recent call last):
File "/venv/lib/python3.7/site-packages/django/core/handlers/exception.py", line 34, in inner
response = get_response(request)
File "/venv/lib/python3.7/site-packages/django/core/handlers/base.py", line 115, in _get_response
response = self.process_exception_by_middleware(e, request)
File "/venv/lib/python3.7/site-packages/django/core/handlers/base.py", line 113, in _get_response
response = wrapped_callback(request, *callback_args, **callback_kwargs)
File "/usr/lib/python3.7/contextlib.py", line 74, in inner
return func(*args, **kwds)
File "/venv/lib/python3.7/site-packages/django/views/decorators/csrf.py", line 54, in wrapped_view
return view_func(*args, **kwargs)
File "/venv/lib/python3.7/site-packages/rest_framework/viewsets.py", line 114, in view
return self.dispatch(request, *args, **kwargs)
File "/app/funkwhale_api/subsonic/views.py", line 139, in dispatch
return super().dispatch(request, *args, **kwargs)
File "/venv/lib/python3.7/site-packages/rest_framework/views.py", line 505, in dispatch
response = self.handle_exception(exc)
File "/app/funkwhale_api/subsonic/views.py", line 152, in handle_exception
return super().handle_exception(exc)
File "/venv/lib/python3.7/site-packages/rest_framework/views.py", line 465, in handle_exception
self.raise_uncaught_exception(exc)
File "/venv/lib/python3.7/site-packages/rest_framework/views.py", line 476, in raise_uncaught_exception
raise exc
File "/venv/lib/python3.7/site-packages/rest_framework/views.py", line 502, in dispatch
response = handler(request, *args, **kwargs)
File "/app/funkwhale_api/subsonic/views.py", line 461, in get_album_list2
queryset = queryset.exclude(release_date__in=["", None]).order_by(
File "/venv/lib/python3.7/site-packages/django/db/models/query.py", line 912, in exclude
return self._filter_or_exclude(True, *args, **kwargs)
File "/venv/lib/python3.7/site-packages/django/db/models/query.py", line 921, in _filter_or_exclude
clone.query.add_q(~Q(*args, **kwargs))
File "/venv/lib/python3.7/site-packages/django/db/models/sql/query.py", line 1350, in add_q
clause, _ = self._add_q(q_object, self.used_aliases)
File "/venv/lib/python3.7/site-packages/django/db/models/sql/query.py", line 1381, in _add_q
check_filterable=check_filterable,
File "/venv/lib/python3.7/site-packages/django/db/models/sql/query.py", line 1311, in build_filter
condition = self.build_lookup(lookups, col, value)
File "/venv/lib/python3.7/site-packages/django/db/models/sql/query.py", line 1165, in build_lookup
lookup = lookup_class(lhs, rhs)
File "/venv/lib/python3.7/site-packages/django/db/models/lookups.py", line 22, in __init__
self.rhs = self.get_prep_lookup()
File "/venv/lib/python3.7/site-packages/django/db/models/lookups.py", line 223, in get_prep_lookup
rhs_value = self.lhs.output_field.get_prep_value(rhs_value)
File "/venv/lib/python3.7/site-packages/django/db/models/fields/__init__.py", line 1215, in get_prep_value
return self.to_python(value)
File "/venv/lib/python3.7/site-packages/django/db/models/fields/__init__.py", line 1190, in to_python
params={'value': value},
django.core.exceptions.ValidationError: ['“” value has an invalid date format. It must be in YYYY-MM-DD format.']