Improve theming system and dark theme color consistance (#1076) · Issues · funkwhale / funkwhale

Improve theming system and dark theme color consistance

It's an adhoc issue to explain a merge request.

What is the problem you are facing?

I feel like the dark theme isn't very consistant in term of color : the dark green/cyan of the background is not in the same range as the grey from the sidebar.

So I tried to hack around a little to get something that make me feel better.

My small changes weren't in the scope of the theming system which is only global CSS and doesn't affect the scoped CSS of the sidebar for instance.
My color result is probably not to everyone's taste (a bit less groovesharky ;) ).

I thought it would have been great to have a theming system that can affect all components in a consistant way. It would allow to :

make advanced customizations of the front mergeable upstream without breaking everyone's default theme.
making UI improvements for the community to approve.
improve the global consistence of the UI incrementally (with scss variables refactoring for exemple) in a safe manner.

<!--
Hi there! You are about to share feature request or an idea, and we want to thank you!

If it's the first time you post here, please take a moment to read our Code of Conduct
(https://funkwhale.audio/code-of-conduct/) and ensure your issue respect our guidelines.

To ensure we can deal with your idea or request, please try to stick
to the following structure. You can leave the parts text between `<!- ->`
markers untouched, they won't be displayed in your final message.

Please do not edit the following line, it's used for automatic classification
-->

It's an adhoc issue to explain a merge request.

## What is the problem you are facing?

I feel like the dark theme isn't very consistant in term of color : the dark green/cyan of the background is not in the same range as the grey from the sidebar.

So I tried to hack around a little to get something that make me feel better.

- My small changes weren't in the scope of the theming system which is only global CSS and doesn't affect the scoped CSS of the sidebar for instance.

- My color result is probably not to everyone's taste (a bit less groovesharky ;) ).

I thought it would have been great to have a theming system that can affect all components in a consistant way. It would allow to :

- make advanced customizations of the front mergeable upstream without breaking everyone's default theme.
- making UI improvements for the community to approve. 
- improve the global consistence of the UI incrementally (with scss variables refactoring for exemple) in a safe manner.

Edited Apr 17, 2020 by Élie Gavoty

Discussion
Designs

The one place for your designs

To enable design management, you'll need to meet the requirements. If you need help, reach out to our support team for assistance.