Skip to content

GitLab

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
funkwhale
funkwhale
  • Project overview
    • Project overview
    • Details
    • Activity
    • Releases
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 171
    • Issues 171
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
  • Merge Requests 4
    • Merge Requests 4
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
  • Operations
    • Operations
    • Incidents
    • Environments
  • Packages & Registries
    • Packages & Registries
    • Container Registry
  • Analytics
    • Analytics
    • CI / CD
    • Repository
    • Value Stream
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • funkwhale
  • funkwhalefunkwhale
  • Issues
  • #1076

Closed
Open
Opened Apr 17, 2020 by Élie Gavoty@i_lie
  • Report abuse
  • New issue
Report abuse New issue

Improve theming system and dark theme color consistance

It's an adhoc issue to explain a merge request.

What is the problem you are facing?

I feel like the dark theme isn't very consistant in term of color : the dark green/cyan of the background is not in the same range as the grey from the sidebar.

So I tried to hack around a little to get something that make me feel better.

  • My small changes weren't in the scope of the theming system which is only global CSS and doesn't affect the scoped CSS of the sidebar for instance.

  • My color result is probably not to everyone's taste (a bit less groovesharky ;) ).

I thought it would have been great to have a theming system that can affect all components in a consistant way. It would allow to :

  • make advanced customizations of the front mergeable upstream without breaking everyone's default theme.
  • making UI improvements for the community to approve.
  • improve the global consistence of the UI incrementally (with scss variables refactoring for exemple) in a safe manner.
Edited Apr 17, 2020 by Élie Gavoty
Assignee
Assign to
1.0
Milestone
1.0
Assign milestone
Time tracking
None
Due date
None
Reference: funkwhale/funkwhale#1076