funkwhale issueshttps://dev.funkwhale.audio/funkwhale/funkwhale/-/issues2022-01-23T22:40:50Zhttps://dev.funkwhale.audio/funkwhale/funkwhale/-/issues/1685Add backend type-checking2022-01-23T22:40:50ZJuniorJPDJAdd backend type-checkingIt will be pain. Much pain.
Mypy is good CI checker for this btw.It will be pain. Much pain.
Mypy is good CI checker for this btw.backloghttps://dev.funkwhale.audio/funkwhale/funkwhale/-/issues/2223add create_playlist_from_folder_structure command2023-09-12T07:16:13Zpetitminionadd create_playlist_from_folder_structure commandjust a little tool for people using the in-place import and that might want to have their folder converted into playlistjust a little tool for people using the in-place import and that might want to have their folder converted into playlisthttps://dev.funkwhale.audio/funkwhale/funkwhale/-/issues/1756Add cypress for testing2023-12-12T08:44:05ZKasper Sewerynwvffle@funkwhale.audioAdd cypress for testing[cypress](https://www.cypress.io/) allows to test the production builds with actions like clicking on links, verifying if the url has changed to a correct one, if element is displayed or not and stuff like this.
Could be useful to have ...[cypress](https://www.cypress.io/) allows to test the production builds with actions like clicking on links, verifying if the url has changed to a correct one, if element is displayed or not and stuff like this.
Could be useful to have this kind of testshttps://dev.funkwhale.audio/funkwhale/funkwhale/-/issues/1167Added external link to support artists (Bandcamp, personal website)2023-12-12T08:51:58ZNiquarlAdded external link to support artists (Bandcamp, personal website)## What is the problem you are facing?
Links to music stores (like Bandcamp) in order to quicly redirect listeners to buy the music and support the artists.
## What are the possible drawbacks or issues with the requested changes?
I'm ...## What is the problem you are facing?
Links to music stores (like Bandcamp) in order to quicly redirect listeners to buy the music and support the artists.
## What are the possible drawbacks or issues with the requested changes?
I'm not sure I can think of any.
## Context
This would be on par with the possibility to search on disgoogs for example.
Other fediverse projects like Peertube have added a 'Support' box where the uploader can add text linking to anything that the uploader might want to redirect the viewer. This could be a patreon or liberapay link or a crowdsource page (like on Kickstarter). It can also be a way to redirect viewers to other groups that the uploader supports. For example, if I were to create a video about Minetest I could put in the support box a link to donate to the Minetest Project, as it would be a form of inderect support. For musicians, this could be gig tickets on top of their merch or music stores. Or even for political themed songs a link to donate to organisations like the NAACP, EFF, ACLU or even a political party.
Could be said that a better place than just in the discription to promote social accounts also. (See the second video example)
You can see an example of this on these videos:
https://peertube.social/videos/watch/6c631642-fc8a-4b5c-b1eb-a3a1378254ff
https://peertube.social/videos/watch/43637940-110a-4cc7-b728-cc594453bfdfhttps://dev.funkwhale.audio/funkwhale/funkwhale/-/issues/1449Add favorites or listenings ordering to track endpoint2021-06-17T15:37:09ZCiarán Ainsworthsporiff@funkwhale.audioAdd favorites or listenings ordering to track endpoint<!--
Hi there! You are about to share feature request or an idea, and we want to thank you!
If it's the first time you post here, please take a moment to read our Code of Conduct
(https://funkwhale.audio/code-of-conduct/) and ensure yo...<!--
Hi there! You are about to share feature request or an idea, and we want to thank you!
If it's the first time you post here, please take a moment to read our Code of Conduct
(https://funkwhale.audio/code-of-conduct/) and ensure your issue respect our guidelines.
To ensure we can deal with your idea or request, please try to stick
to the following structure. You can leave the parts text between `<!- ->`
markers untouched, they won't be displayed in your final message.
Please do not edit the following line, it's used for automatic classification
-->
## What is the problem you are facing?
<!--
Describe the problem you'd like to solve, and why we need to add or
improve something in the current system to solve that problem.
Be as specific as possible.
-->
As part of !1309, it has been suggested that we add the ability to order tracks by the number of favorites they have received so that we can produce a list in order of popularity. Another suggestion might be to order tracks by the number of listens they have received.
## What are the possible drawbacks or issues with the requested changes?
<!--
Altering the system behaviour is not always a free action, and it can impact
user experience, performance, introduce bugs or complexity, etc..
If you think about anything we should keep in mind while
examining your request, please describe it in this section.
-->
There needs to be a discussion about whether this fits with the app's mission. Listenings and favorites are accessible on a per-user context currently so there would need to be a new model to support storing this aggregate data.
## Context
<!--
If relevant, share additional context here like:
- Links to existing implementations or examples of the requested feature
- Screenshots
-->
This feature is common in other music services such as Spotify, Apple music, Amazon music etc. It would help with some of the design elements mentioned on #1235.https://dev.funkwhale.audio/funkwhale/funkwhale/-/issues/1746Add indication if the podcast is already listened.2022-04-16T15:02:18ZtrollAdd indication if the podcast is already listened.<!--
Hi there! You are about to share feature request or an idea, and we want to thank you!
If it's the first time you post here, please take a moment to read our Code of Conduct
(https://funkwhale.audio/code-of-conduct/) and ensure yo...<!--
Hi there! You are about to share feature request or an idea, and we want to thank you!
If it's the first time you post here, please take a moment to read our Code of Conduct
(https://funkwhale.audio/code-of-conduct/) and ensure your issue respect our guidelines.
To ensure we can deal with your idea or request, please try to stick
to the following structure. You can leave the parts text between `<!- ->`
markers untouched, they won't be displayed in your final message.
Please do not edit the following line, it's used for automatic classification
-->
## What is the problem you are facing?
There is no visual indication of whether you have already listened to an episode of a podcast or not.
It's a bit disorienting I think.
There would be many possibilities for this.
Either by graying the links or the card of the episodes that have already been played.
Or by adding a label under the episode that would indicate that it has already been listened to.
## What are the possible drawbacks or issues with the requested changes?
It would be necessary to record the reading information for each user.
Difficulty in determining when a podcast is considered listened to.
Eventually remember where the user stopped the playback, to be able to resume it later.
(I think there is a mechanism like that for Peertube videos, I don't know if it helps)
## Context
![image](/uploads/6bcbd9faa78eb19b620143f31aa450fe/image.png)https://dev.funkwhale.audio/funkwhale/funkwhale/-/issues/1033Adding an mp3 file without ID3 tags through manage.py results in an obscure e...2021-06-17T13:06:38ZJulius MichaelisAdding an mp3 file without ID3 tags through manage.py results in an obscure error message<!--
Hi there! You are reporting a bug on this project, and we want to thank you!
If it's the first time you post here, please take a moment to read our Code of Conduct
(https://funkwhale.audio/code-of-conduct/) and ensure your issue re...<!--
Hi there! You are reporting a bug on this project, and we want to thank you!
If it's the first time you post here, please take a moment to read our Code of Conduct
(https://funkwhale.audio/code-of-conduct/) and ensure your issue respect our guidelines.
To ensure your bug report is as useful as possible, please try to stick
to the following structure. You can leave the parts text between `<!- ->`
markers untouched, they won't be displayed in your final message.
Please do not edit the following line, it's used for automatic classification
-->
## Steps to reproduce
1. `wget -O/tmp/foo.mp3 https://matrix.org/_matrix/media/r0/download/mtx.liftm.de/mekqiQXkPXYmlCBjYfBBXTnF`
attached: ![foo](/uploads/ba83fc04eed860adb5f92245d1c0f4cf/foo.mp3)
2. `python -m pudb manage.py import_files -x 8fed5211-d2eb-4bd2-b375-7b07315b3073 /tmp/foo.mp3 --recursive --noinput`
## What happens?
```
2020-03-01 13:55:26,721 funkwhale_api.config INFO Running with no plugins
:0: UserWarning: You do not have a working installation of the service_identity module: 'No module named 'service_identity''. Please install it from <https://pypi.python.org/pypi/service_identity> and make sure all of its dependencies are satisfied. Without the service_identity module, Twisted can perform only rudimentary TLS client hostname verification. Many valid certificate/hostname mappings may be rejected.
Import summary:
- 1 files found matching this pattern: ['/tmp/foo.mp3']
- 0 files already found in database
- 1 new files
Selected options: copy music files
For details, please refer to import reference 'cli-2020-03-01T13:55:31.761476+00:00' or URL http://funk.liftm.de/content/libraries/8fed5211-d2eb-4bd2-b375-7b07315b3073/upload?import=cli-2020-03-01T13%3A55%3A31.761476%2B00%3A00
1/1 Importing /tmp/foo.mp3...
Traceback (most recent call last):
File "manage.py", line 20, in <module>
execute_from_command_line(sys.argv)
File "/usr/lib/python3.6/site-packages/django/core/management/__init__.py", line 381, in execute_from_command_line
utility.execute()
File "/usr/lib/python3.6/site-packages/django/core/management/__init__.py", line 375, in execute
self.fetch_command(subcommand).run_from_argv(self.argv)
File "/usr/lib/python3.6/site-packages/django/core/management/base.py", line 323, in run_from_argv
self.execute(*args, **cmd_options)
File "/usr/lib/python3.6/site-packages/django/core/management/base.py", line 364, in execute
output = self.handle(*args, **options)
File "/app/funkwhale_api/music/management/commands/import_files.py", line 235, in handle
import_paths, library=library, reference=reference, options=options
File "/app/funkwhale_api/music/management/commands/import_files.py", line 288, in do_import
options["broadcast"],
File "/app/funkwhale_api/music/management/commands/import_files.py", line 330, in create_upload
import_handler(upload_id=upload.pk)
File "/usr/lib/python3.6/site-packages/celery/local.py", line 191, in __call__
return self._get_current_object()(*a, **kw)
File "/usr/lib/python3.6/site-packages/celery/app/task.py", line 394, in __call__
return self.run(*args, **kwargs)
File "/app/funkwhale_api/taskapp/celery.py", line 51, in inner
return function(*args, **kwargs)
File "/app/funkwhale_api/music/tasks.py", line 182, in process_upload
serializer.is_valid()
File "/usr/lib/python3.6/site-packages/rest_framework/serializers.py", line 235, in is_valid
self._validated_data = self.run_validation(self.initial_data)
File "/usr/lib/python3.6/site-packages/rest_framework/serializers.py", line 430, in run_validation
value = self.to_internal_value(data)
File "/usr/lib/python3.6/site-packages/rest_framework/serializers.py", line 485, in to_internal_value
primitive_value = field.get_value(data)
File "/usr/lib/python3.6/site-packages/rest_framework/fields.py", line 435, in get_value
return dictionary.get(self.field_name, empty)
File "/app/funkwhale_api/music/metadata.py", line 359, in get
return self._get_from_self(key)
File "/app/funkwhale_api/music/metadata.py", line 397, in _get_from_self
v = getter(self._file, real_key)
File "/app/funkwhale_api/music/metadata.py", line 41, in get_id3_tag
v = getattr(f.tags[k], attr)
TypeError: 'NoneType' object is not subscriptable
```
## What is expected?
<!--
Describe the expected behaviour.
-->
Some meaningful error message. Likely to be output from [metadata.py](https://dev.funkwhale.audio/funkwhale/funkwhale/-/blob/65097f6297be24f5866b2c7b1b593528e64f2ebe/api/funkwhale_api/music/metadata.py#L349), after checking for some other bogus values than `None`.
## Context
<!--
The version of your instance can be found on the footer : Source code (x.y)
-->
**Funkwhale version(s) affected**: 0.20.1 (in docker - happens both with mutagen 1.44.0 and 1.42.0)
<!--
If relevant, share additional context here like:
- Browser type and version (for front-end bugs)
- Instance configuration (Docker/non-docker, nginx/apache as proxy, etc.)
- Error messages, screenshots and logs
-->https://dev.funkwhale.audio/funkwhale/funkwhale/-/issues/1772Add manage.py to autodoc path2022-04-27T04:03:42ZCiarán Ainsworthsporiff@funkwhale.audioAdd manage.py to autodoc pathAs discussed in !1773, we would like to add the `manage.py` script to our documentation via autodoc. This doesn't currently work due to import issues.
From Matrix:
> We have two options:
> - we make funkwhale api a python module which...As discussed in !1773, we would like to add the `manage.py` script to our documentation via autodoc. This doesn't currently work due to import issues.
From Matrix:
> We have two options:
> - we make funkwhale api a python module which can be installed as dependency in docs
> - we have a project global poetry confighttps://dev.funkwhale.audio/funkwhale/funkwhale/-/issues/429Add multiple tracks at once to a playlist2023-12-07T19:51:26ZAgateAdd multiple tracks at once to a playlistMathieu JourdanMathieu Jourdanhttps://dev.funkwhale.audio/funkwhale/funkwhale/-/issues/1699Add my funkwhale-docker repo to the documentation to simplifiy the multi-cont...2022-11-21T17:53:18ZCreakAdd my funkwhale-docker repo to the documentation to simplifiy the multi-container installation## Description
As discussed in [Matrix](https://matrix.to/#/!LfWevXYWdhwVFvDXRf:matrix.org/$164416003176087QRwoW:matrix.org?via=tchncs.de&via=matrix.org&via=converser.eu) with @Sporiff, it would be nice to add this repo I made that woul...## Description
As discussed in [Matrix](https://matrix.to/#/!LfWevXYWdhwVFvDXRf:matrix.org/$164416003176087QRwoW:matrix.org?via=tchncs.de&via=matrix.org&via=converser.eu) with @Sporiff, it would be nice to add this repo I made that would drastically simplify the multi-container installation steps (it is basically one script to run and then setup the reverse-proxy).
Here's the link to the repo: https://dev.funkwhale.audio/creak/funkwhale-docker
The README explains how to use it and the script help as well (i.e. `./setup.sh --help`).
## Caveats
**One caveat I've seen so far:**
It's not linked to my script directly, but once the Funkwhale instance is up and running, it's confusing that you can't easily access your instance locally. You can't set it up for https://my.domain.io, but still be able to access it through http://localhost:5000 (the exposed port on the host). It is possible to see the web page, but because the protocol is different (HTTP vs HTTPS), it's impossible to log in.
The workaround I've found so far is to set up your instance with the "localhost" hostname and the "http" protocol (which would translate with this command line with the script: `./setup.sh -h localhost -p http`). This way, since the protocols are the same between when you access locally and the Funkwhale's protocol configuration, you can log in your instance. It's nice to know if you just want to quickly test a Funkwhale instance without having to set up a reverse-proxy on top.
## Future improvements
- The script can be a bit verbosy, especially because of all the warnings when running the API. I want to keep it because it gives some log information, but also I can't hide it because you wouldn't understand the superuser creation prompt
- Is there a way to give the user, e-mail and password directly in the `createsuperuser` command line?
- As discussed a few weeks ago, it would be very nice to remove the nginx configuration files and keep them hidden within the `nginx` container; I don't think they are very useful for the vast majority of the Funkwhale users and they tend to confuse the users because of the other nginx config files for the reverse-proxyhttps://dev.funkwhale.audio/funkwhale/funkwhale/-/issues/1411"Add new" channel defaults to Podcast even though Artist was chosen2022-11-02T11:33:37ZColin Axner"Add new" channel defaults to Podcast even though Artist was chosen<!--
Hi there! You are reporting a bug on this project, and we want to thank you!
If it's the first time you post here, please take a moment to read our Code of Conduct
(https://funkwhale.audio/code-of-conduct/) and ensure your issue re...<!--
Hi there! You are reporting a bug on this project, and we want to thank you!
If it's the first time you post here, please take a moment to read our Code of Conduct
(https://funkwhale.audio/code-of-conduct/) and ensure your issue respect our guidelines.
To ensure your bug report is as useful as possible, please try to stick
to the following structure. You can leave the parts text between `<!- ->`
markers untouched, they won't be displayed in your final message.
Please do not edit the following line, it's used for automatic classification
-->
## Steps to reproduce
<!--
Describe the steps to reproduce the issue, like:
1. Visit the page at /artists/
2. Type that
3. Submit
-->
1. visit page for my account /@myaccount/
2. Click "Add new"
3. Select "Artist discography" and click "Next Step:
4. Close out of the popup
5. Click "Add new"
## What happens?
<!--
Describe what happens once the previous steps are completed.
-->
"Podcast channel" is shown (first step is skipped and assumes podcast)
## What is expected?
<!--
Describe the expected behaviour.
-->
"Artist channel" is shown (first step is skipped and assumes artist - as that was the last chosen option)
## Context
<!--
The version of your instance can be found on the footer : Source code (x.y)
-->
**Funkwhale version(s) affected**: 1.1
<!--
If relevant, share additional context here like:
- Browser type and version (for front-end bugs)
- Instance configuration (Docker/non-docker, nginx/apache as proxy, etc.)
- Error messages, screenshots and logs
-->
Using Firefox. Might just be easiest to reset to the first step if the popup is closedhttps://dev.funkwhale.audio/funkwhale/funkwhale/-/issues/2070Add new CI lint_docs job2023-02-04T23:05:52ZjooolaAdd new CI lint_docs jobWhen editing the documentation, we want to make sure that translators always work on the latest version possible.
I propose to add a small CI job that checks by generating the pot/po files and fail if changes were found.
This will ensu...When editing the documentation, we want to make sure that translators always work on the latest version possible.
I propose to add a small CI job that checks by generating the pot/po files and fail if changes were found.
This will ensure that the docs po files are always up to day and weblate will be able to pick the changes.
@Sporiffhttps://dev.funkwhale.audio/funkwhale/funkwhale/-/issues/1926Add new frontend tests2023-12-12T08:47:32ZCiarán Ainsworthsporiff@funkwhale.audioAdd new frontend tests<!--
Hello and welcome to our issue tracker! We appreciate you taking the time to help us make Funkwhale even better :smile:
Before you begin, here are some helpful tips for submitting an issue:
* If you need help setting up or using ...<!--
Hello and welcome to our issue tracker! We appreciate you taking the time to help us make Funkwhale even better :smile:
Before you begin, here are some helpful tips for submitting an issue:
* If you need help setting up or using Funkwhale, try asking in our
[forum's support board](https://forum.funkwhale.audio/support) or our [support
chat room](https://riot.im/app/#/room/#funkwhale-support:tchncs.de).
* If you think you've found a bug but aren't sure, you can ask in one of the above channels
first. Once you're confident it's a bug, go ahead and create an issue for us to investigate.
Select the **Bug** template in the **Description** dropdown menu. This template contains
helpful tips for creating your report.
* For smaller additions and enhancements, please file a feature request.
Select the **Feature Request** template in the **Description** dropdown
menu. This template contains helpful tips for creating your request.
* If you have ideas for new features or use cases, consider opening a thread in our
[forum](https://forum.funkwhale.audio/t/development). This enables us to
discuss the feature, its use cases, and the development effort it requires.
We always like hearing ideas from our community. If you're still not sure, click
the **Create issue** button and we'll work with you to sort out the issue.
Happy listening! :whale:
-->
Our old frontend tests don't work properly with the new audio player introduced in !2009. We've removed them for now, but we need to create new ones to test our changes. Some of this will be covered by Cypress, but the old unit tests should be replicated.
See [this log](https://dev.funkwhale.audio/funkwhale/funkwhale/-/jobs/127441) for the failures.https://dev.funkwhale.audio/funkwhale/funkwhale/-/issues/836Add option to be able to import / export playlists2024-01-23T21:14:01ZGhost UserAdd option to be able to import / export playlistsHello Everybody!
First of all thanks for this awsome application!
I would like to have an option to import / export playlists:
My playlists are really precious to me and i like to be able to export them:
2 reasons:
1st - backup purpos...Hello Everybody!
First of all thanks for this awsome application!
I would like to have an option to import / export playlists:
My playlists are really precious to me and i like to be able to export them:
2 reasons:
1st - backup purpose
2nd - I have a script running wich convert and import them to my Moode-audio player so i always have my playlists synced.
Thanks for your work and attention :-)API v2petitminionpetitminionhttps://dev.funkwhale.audio/funkwhale/funkwhale/-/issues/969Add option to merged artists metadata manually2022-07-31T19:35:45ZAgateAdd option to merged artists metadata manuallyas reported by @wyrk in a private matrix room, importing MBID tagged files matching an existing artist without MBID creates a duplicated artist instead of adding the corresponding albums to the existing artist.
Not sure what to do abou...as reported by @wyrk in a private matrix room, importing MBID tagged files matching an existing artist without MBID creates a duplicated artist instead of adding the corresponding albums to the existing artist.
Not sure what to do about this yet, but we need to investigate.https://dev.funkwhale.audio/funkwhale/funkwhale/-/issues/1445add option to merge duplicate album when release is different2021-11-25T06:25:44Zpetitminionadd option to merge duplicate album when release is differentAs we can see in https://audio.gafamfree.party/library/artists/1093/ there is duplicated album. This is probably due to the fac they don't have the same mbid because various release of the same album exist.
Didn't looked the code but m...As we can see in https://audio.gafamfree.party/library/artists/1093/ there is duplicated album. This is probably due to the fac they don't have the same mbid because various release of the same album exist.
Didn't looked the code but maybe we should use the release-group instead of the release to create the albums.petitminionpetitminionhttps://dev.funkwhale.audio/funkwhale/funkwhale/-/issues/861Add quality selector (MP3 / FLAC)2021-06-17T13:06:55ZFluorFRAdd quality selector (MP3 / FLAC)Hi !
A large number of users of my instance are on Safari and therefore do not have the ability to read the FLAC.
Funkwhale does not detect this icompatibility and so this produces an error.
In addition to reduce data consumption I thi...Hi !
A large number of users of my instance are on Safari and therefore do not have the ability to read the FLAC.
Funkwhale does not detect this icompatibility and so this produces an error.
In addition to reduce data consumption I think it would be nice to set up a button to choose the quality of reading.https://dev.funkwhale.audio/funkwhale/funkwhale/-/issues/2250Add schemas for existing v2 feature specs2023-11-18T04:18:53ZCiarán Ainsworthsporiff@funkwhale.audioAdd schemas for existing v2 feature specs<!--
Hello and welcome to our issue tracker! We appreciate you taking the time to help us make Funkwhale even better :smile:
Before you begin, here are some helpful tips for submitting an issue:
* If you need help setting up or using ...<!--
Hello and welcome to our issue tracker! We appreciate you taking the time to help us make Funkwhale even better :smile:
Before you begin, here are some helpful tips for submitting an issue:
* If you need help setting up or using Funkwhale, try asking in our
[forum's support board](https://forum.funkwhale.audio/support) or our [support
chat room](https://riot.im/app/#/room/#funkwhale-support:tchncs.de).
* If you think you've found a bug but aren't sure, you can ask in one of the above channels
first. Once you're confident it's a bug, go ahead and create an issue for us to investigate.
Select the **Bug** template in the **Description** dropdown menu. This template contains
helpful tips for creating your report.
* For smaller additions and enhancements, please file a feature request.
Select the **Feature Request** template in the **Description** dropdown
menu. This template contains helpful tips for creating your request.
* If you have ideas for new features or use cases, consider opening a thread in our
[forum](https://forum.funkwhale.audio/t/development). This enables us to
discuss the feature, its use cases, and the development effort it requires.
We always like hearing ideas from our community. If you're still not sure, click
the **Create issue** button and we'll work with you to sort out the issue.
Happy listening! :whale:
-->API v2Ciarán Ainsworthsporiff@funkwhale.audioCiarán Ainsworthsporiff@funkwhale.audiohttps://dev.funkwhale.audio/funkwhale/funkwhale/-/issues/1607add shortcuts to browse library2021-11-07T20:35:29Zpetitminionadd shortcuts to browse librarySelecting tracks in your library is difficult. I should be able to use shift, ctrl and ctrl + A shortcuts, or a "select all" button.
From #1570Selecting tracks in your library is difficult. I should be able to use shift, ctrl and ctrl + A shortcuts, or a "select all" button.
From #1570https://dev.funkwhale.audio/funkwhale/funkwhale/-/issues/1409Add statistic information about federation : numbers of domains followed2023-03-20T23:32:03ZpetitminionAdd statistic information about federation : numbers of domains followedWe could add numbers of followed domains by the instance. This give information about how much the instance is isolated or connected to the network.We could add numbers of followed domains by the instance. This give information about how much the instance is isolated or connected to the network.backlogpetitminionpetitminion