compose/app.django.yml

@@ -3,11 +3,11 @@ x-django: &django
   volumes:
     - ../api:/app
     - ../.env:/app/.env
-    - "${MUSIC_DIRECTORY_SERVE_PATH:-../.state/music}:/music:ro"
-    - "../.state/plugins:/srv/funkwhale/plugins"
-    - "../.state/staticfiles:/staticfiles"
-    - "../.state/media:/protected/media"
-    - "../.state/${COMPOSE_PROJECT_NAME:-funkwhale}/media:/data/media"
+    - '${MUSIC_DIRECTORY_SERVE_PATH:-../.state/music}:/music:ro'
+    - '../.state/plugins:/srv/funkwhale/plugins'
+    - '../.state/staticfiles:/staticfiles'
+    - '../.state/media:/protected/media'
+    - '../.state/${COMPOSE_PROJECT_NAME:-funkwhale}/media:/data/media'
   depends_on:
     postgres:
       condition: service_healthy
@@ -23,11 +23,7 @@ services:
       context: ../api
       dockerfile: Dockerfile.debian
     healthcheck:
-      test:
-        [
-          "CMD-SHELL",
-          'docker compose logs api | grep -q "Uvicorn running on" || exit 0',
-        ]
+      test: ['CMD-SHELL', 'docker compose logs api | grep -q "Uvicorn running on" || exit 0']
       interval: 3s
       timeout: 5s
       retries: 3
@@ -42,7 +38,7 @@ services:
     command: >
       sh -c '
         pip install watchdog[watchmedo] &&
-        watchmedo auto-restart --patterns="*.py" --recursive -- celery -A funkwhale_api.taskapp worker -l debug -B --concurrency=${CELERYD_CONCURRENCY}
+        watchmedo auto-restart --patterns="*.py" --recursive -- celery -A funkwhale_api.taskapp worker -l debug -B --concurrency=${CELERYD_CONCURRENCY:-0}
       '
     depends_on:
       api:

compose/app.nginx.yml

@@ -5,7 +5,7 @@ services:
       - api
       - front
     volumes:
-      - "${MUSIC_DIRECTORY_SERVE_PATH:-../.state/music}:${MUSIC_DIRECTORY_PATH:-/music}:ro"
+      - '${MUSIC_DIRECTORY_SERVE_PATH:-../.state/music}:${MUSIC_DIRECTORY_PATH:-/music}:ro'
 
       - ./etc/nginx/conf.dev:/etc/nginx/templates/default.conf.template:ro
       - ../deploy/funkwhale_proxy.conf:/etc/nginx/funkwhale_proxy.conf:ro

compose/docs.openapi.yml

@@ -2,18 +2,18 @@ services:
   openapi:
     image: swaggerapi/swagger-ui
     environment:
-      - "URL=/openapi.yml"
+      - 'URL=/openapi.yml'
     ports:
-      - "8002:8080"
+      - '8002:8080'
     volumes:
-      - "../docs/specs/nodeinfo21/schema.yml:/usr/share/nginx/html/openapi.yml"
+      - '../docs/specs/nodeinfo21/schema.yml:/usr/share/nginx/html/openapi.yml'
     #  - "../docs/api:/usr/share/nginx/html/api"
     labels:
-      - "traefik.enable=true"
-      - "traefik.http.routers.test-funkwhale-openapi-web.rule=Host(`openapi.funkwhale.test`)"
-      - "traefik.http.routers.test-funkwhale-openapi-web.entrypoints=web"
-      - "traefik.http.services.test-funkwhale-openapi.loadbalancer.server.port=8080"
-      - "traefik.http.routers.test-funkwhale-openapi-webs.rule=Host(`openapi.funkwhale.test`)"
-      - "traefik.http.routers.test-funkwhale-openapi-webs.entrypoints=webs"
-      - "traefik.http.routers.test-funkwhale-openapi-webs.tls=true"
-    networks: ["web"]
+      - 'traefik.enable=true'
+      - 'traefik.http.routers.test-funkwhale-openapi-web.rule=Host(`openapi.funkwhale.test`)'
+      - 'traefik.http.routers.test-funkwhale-openapi-web.entrypoints=web'
+      - 'traefik.http.services.test-funkwhale-openapi.loadbalancer.server.port=8080'
+      - 'traefik.http.routers.test-funkwhale-openapi-webs.rule=Host(`openapi.funkwhale.test`)'
+      - 'traefik.http.routers.test-funkwhale-openapi-webs.entrypoints=webs'
+      - 'traefik.http.routers.test-funkwhale-openapi-webs.tls=true'
+    networks: ['web']

compose/docs.sphinx.yml

@@ -4,16 +4,16 @@ services:
       context: ../
       dockerfile: docs/Dockerfile
     init: true
-    ports: ["8001:8001"]
+    ports: ['8001:8001']
     command: sh -c 'cd /src/docs && make dev'
     volumes:
       - ../docs:/src/docs
     labels:
-      - "traefik.enable=true"
-      - "traefik.http.routers.test-funkwhale-docs-web.rule=Host(`docs.funkwhale.test`)"
-      - "traefik.http.routers.test-funkwhale-docs-web.entrypoints=web"
+      - 'traefik.enable=true'
+      - 'traefik.http.routers.test-funkwhale-docs-web.rule=Host(`docs.funkwhale.test`)'
+      - 'traefik.http.routers.test-funkwhale-docs-web.entrypoints=web'
 
-      - "traefik.http.routers.test-funkwhale-docs-webs.rule=Host(`docs.funkwhale.test`)"
-      - "traefik.http.routers.test-funkwhale-docs-webs.entrypoints=webs"
-      - "traefik.http.routers.test-funkwhale-docs-webs.tls=true"
-    networks: ["web"]
+      - 'traefik.http.routers.test-funkwhale-docs-webs.rule=Host(`docs.funkwhale.test`)'
+      - 'traefik.http.routers.test-funkwhale-docs-webs.entrypoints=webs'
+      - 'traefik.http.routers.test-funkwhale-docs-webs.tls=true'
+    networks: ['web']

compose/docs.ui.yml

+services:
+  ui:
+    build:
+      context: ../front
+      dockerfile: Dockerfile.dev
+    command: yarn dev:docs --host 0.0.0.0
+    expose: ['5173']
+    ports:
+      - '8003:5173'
+    volumes:
+      - '../front:/app'
+      - '/app/node_modules'
+    networks: ['web']
+    labels:
+      - 'traefik.enable=true'
+      - 'traefik.http.routers.test-funkwhale-ui-web.rule=Host(`ui.funkwhale.test`)'
+      - 'traefik.http.routers.test-funkwhale-ui-web.entrypoints=web'
+      - 'traefik.http.services.test-funkwhale-ui.loadbalancer.server.port=5173'
+      - 'traefik.http.routers.test-funkwhale-ui-webs.rule=Host(`ui.funkwhale.test`)'
+      - 'traefik.http.routers.test-funkwhale-ui-webs.entrypoints=webs'
+      - 'traefik.http.routers.test-funkwhale-ui-webs.tls=true'

compose/etc/nginx/conf.dev

@@ -74,6 +74,11 @@ server {
         proxy_pass   http://funkwhale-api;
     }
 
+    location /node_modules/.vite/ {
+        include /etc/nginx/funkwhale_proxy.conf;
+        proxy_pass   http://funkwhale-front;
+    }
+
     location ~ ^/@(vite-plugin-pwa|vite|id)/ {
         include /etc/nginx/funkwhale_proxy.conf;
         proxy_pass   http://funkwhale-front;

compose/etc/traefik/dynamic/mailpit.yml

@@ -3,7 +3,7 @@ http:
     test-funkwhale-mailpit:
       loadbalancer:
         servers:
-          - url: "http://172.17.0.1:8025"
+          - url: 'http://172.17.0.1:8025'
         passhostheader: true
   routers:
     test-funkwhale-mailpit-web:

compose/etc/traefik/traefik.yml

@@ -13,8 +13,8 @@ api:
 
 entryPoints:
   traefik:
-    address: "172.17.0.1:8008"
+    address: '172.17.0.1:8008'
   web:
-    address: "172.17.0.1:80"
+    address: '172.17.0.1:80'
   webs:
-    address: "172.17.0.1:443"
+    address: '172.17.0.1:443'

compose/net.helpers.yml

 x-busybox: &busybox
   init: true
-  image: "busybox"
+  image: 'busybox'
   network_mode: bridge
   dns: 172.17.0.1
   dns_search: funkwhale.test
@@ -11,18 +11,18 @@ networks:
 
 services:
   whoami:
-    image: "traefik/whoami"
+    image: 'traefik/whoami'
     networks:
       - web
     labels:
-      - "traefik.enable=true"
-      - "traefik.http.routers.whoami-web.rule=Host(`whoami.funkwhale.test`)"
-      - "traefik.http.routers.whoami-web.entrypoints=web"
+      - 'traefik.enable=true'
+      - 'traefik.http.routers.whoami-web.rule=Host(`whoami.funkwhale.test`)'
+      - 'traefik.http.routers.whoami-web.entrypoints=web'
 
-      - "traefik.http.routers.whoami-webs.rule=Host(`whoami.funkwhale.test`)"
-      - "traefik.http.routers.whoami-webs.entrypoints=webs"
-      - "traefik.http.routers.whoami-webs.tls=true"
-      - "traefik.http.routers.whoami.tls.domains[0].main=whoami.funkwhale.test"
+      - 'traefik.http.routers.whoami-webs.rule=Host(`whoami.funkwhale.test`)'
+      - 'traefik.http.routers.whoami-webs.entrypoints=webs'
+      - 'traefik.http.routers.whoami-webs.tls=true'
+      - 'traefik.http.routers.whoami.tls.domains[0].main=whoami.funkwhale.test'
 
   shell:
     <<: *busybox

compose/net.mailpit.yml

@@ -9,5 +9,5 @@ services:
       MP_SMTP_BIND_ADDR: 172.17.0.1:1025
       MP_MAX_MESSAGES: 5000
       MP_DATABASE: /data/mailpit.db
-      MP_SMTP_AUTH_ACCEPT_ANY: "true"
-      MP_SMTP_AUTH_ALLOW_INSECURE: "true"
+      MP_SMTP_AUTH_ACCEPT_ANY: 'true'
+      MP_SMTP_AUTH_ALLOW_INSECURE: 'true'

compose/net.minio.yml

@@ -3,13 +3,13 @@ services:
     image: minio/minio
     command: server /data
     volumes:
-      - "../.state/${COMPOSE_PROJECT_NAME:-funkwhale}/minio:/data"
+      - '../.state/${COMPOSE_PROJECT_NAME:-funkwhale}/minio:/data'
     environment:
-      - "MINIO_ACCESS_KEY=${AWS_ACCESS_KEY_ID:-access_key}"
-      - "MINIO_SECRET_KEY=${AWS_SECRET_ACCESS_KEY:-secret_key}"
-      - "MINIO_HTTP_TRACE: /dev/stdout"
+      - 'MINIO_ACCESS_KEY=${AWS_ACCESS_KEY_ID:-access_key}'
+      - 'MINIO_SECRET_KEY=${AWS_SECRET_ACCESS_KEY:-secret_key}'
+      - 'MINIO_HTTP_TRACE: /dev/stdout'
     ports:
-      - "9000:9000"
+      - '9000:9000'
     networks:
       - web
       - internal

compose/net.verify.yml

 x-verify: &verify
   init: true
-  image: "busybox"
+  image: 'busybox'
   network_mode: bridge
   dns: 172.17.0.1
   dns_search: funkwhale.test
@@ -12,4 +12,4 @@ services:
 
   verify-internal-connectivity:
     <<: *verify
-    command: "ping -c 1 ${COMPOSE_PROJECT_NAME:-funkwhale}.funkwhale.test"
+    command: 'ping -c 1 ${COMPOSE_PROJECT_NAME:-funkwhale}.funkwhale.test'

deploy/docker-compose.yml

-version: "3"
+version: '3'
 
 services:
   postgres:
     restart: unless-stopped
     env_file: .env
     environment:
-      - "POSTGRES_HOST_AUTH_METHOD=trust"
+      - 'POSTGRES_HOST_AUTH_METHOD=trust'
     image: postgres:15-alpine
     volumes:
       - ./data/postgres:/var/lib/postgresql/data
@@ -41,8 +41,8 @@ services:
     environment:
       - C_FORCE_ROOT=true
     volumes:
-      - "${MUSIC_DIRECTORY_SERVE_PATH-/srv/funkwhale/data/music}:${MUSIC_DIRECTORY_PATH-/music}:ro"
-      - "${MEDIA_ROOT}:${MEDIA_ROOT}"
+      - '${MUSIC_DIRECTORY_SERVE_PATH-/srv/funkwhale/data/music}:${MUSIC_DIRECTORY_PATH-/music}:ro'
+      - '${MEDIA_ROOT}:${MEDIA_ROOT}'
 
   celerybeat:
     restart: unless-stopped
@@ -65,9 +65,9 @@ services:
       - redis
     env_file: .env
     volumes:
-      - "${MUSIC_DIRECTORY_SERVE_PATH-/srv/funkwhale/data/music}:${MUSIC_DIRECTORY_PATH-/music}:ro"
-      - "${MEDIA_ROOT}:${MEDIA_ROOT}"
-      - "${STATIC_ROOT}:${STATIC_ROOT}"
+      - '${MUSIC_DIRECTORY_SERVE_PATH-/srv/funkwhale/data/music}:${MUSIC_DIRECTORY_PATH-/music}:ro'
+      - '${MEDIA_ROOT}:${MEDIA_ROOT}'
+      - '${STATIC_ROOT}:${STATIC_ROOT}'
 
   front:
     restart: unless-stopped
@@ -78,7 +78,7 @@ services:
       - .env
     environment:
       # Override those variables in your .env file if needed
-      - "NGINX_MAX_BODY_SIZE=${NGINX_MAX_BODY_SIZE-100M}"
+      - 'NGINX_MAX_BODY_SIZE=${NGINX_MAX_BODY_SIZE-100M}'
     volumes:
       # Uncomment if you want to use your previous nginx config, please let us
       # know what special configuration you need, so we can support it with out
@@ -86,12 +86,12 @@ services:
       #- "./nginx/funkwhale.template:/etc/nginx/templates/default.conf.template:ro"
       #- "./nginx/funkwhale_proxy.conf:/etc/nginx/funkwhale_proxy.conf:ro"
 
-      - "${MUSIC_DIRECTORY_SERVE_PATH-/srv/funkwhale/data/music}:${MUSIC_DIRECTORY_PATH-/music}:ro"
-      - "${MEDIA_ROOT}:${MEDIA_ROOT}:ro"
-      - "${STATIC_ROOT}:/usr/share/nginx/html/staticfiles:ro"
+      - '${MUSIC_DIRECTORY_SERVE_PATH-/srv/funkwhale/data/music}:${MUSIC_DIRECTORY_PATH-/music}:ro'
+      - '${MEDIA_ROOT}:${MEDIA_ROOT}:ro'
+      - '${STATIC_ROOT}:/usr/share/nginx/html/staticfiles:ro'
     ports:
       # override those variables in your .env file if needed
-      - "${FUNKWHALE_API_IP}:${FUNKWHALE_API_PORT}:80"
+      - '${FUNKWHALE_API_IP}:${FUNKWHALE_API_PORT}:80'
 
   typesense:
     restart: unless-stopped

docs/administrator/import.md

@@ -34,30 +34,6 @@ docker compose run --rm api funkwhale-manage import_files --help
 :local:
 ```
 
-## Get demo music
-
-If you don't have music on your server, you can download creative commons music to test imports with. The Funkwhale project provides a collection courtesy of [Jamendo](https://jamendo.com). To download these tracks:
-
-1. Download the shell script.
-
-   ```{parsed-literal}
-   curl -L -o download-tracks.sh "https://dev.funkwhale.audio/funkwhale/funkwhale/raw/{sub-ref}`version`/demo/download-tracks.sh"
-   ```
-
-2. Download the music list.
-
-   ```{parsed-literal}
-   curl -L -o music.txt "https://dev.funkwhale.audio/funkwhale/funkwhale/raw/{sub-ref}`version`/demo/music.txt" chmod +x download-tracks.sh
-   ```
-
-3. Run the shell script against the music list to download the tracks.
-
-   ```{code-block} sh
-   ./download-tracks.sh music.txt
-   ```
-
-This downloads a set compressed albums to your `data/music` directory and unzips them. You can then import these tracks using the methods in this article.
-
 ## Find your library ID
 
 You need to create a library before you can import music. Follow the instructions in [Create a library](../user/libraries/create.md) to get started.
@@ -200,7 +176,7 @@ Funkwhale imports the music in your storage directory into the specified library
 
 Funkwhale attempts to import album art for your music library. The import process checks for the following.
 
-1. The cover embedded in the audio files (works with FLAC and MP3 files).
+1. The cover embedded in the audio files (works with FLAC, OGG, MP3 and MP4 files, possibly others).
 2. A `cover.jpg` or `cover.png` in the the track's directory.
 3. An `mbid` in the file's tags. If there is an `mbid`, the import process tries to fetch cover art from Musicbrainz.
 

docs/developer/api/schema.md

+# OpenApi schema
+
+The frontend need up to date schemas ! If you change the api you need to upgrade the schema by running : `docker compose run --rm api funkwhale-manage spectacular > ./api/funkwhale_api/common/schema.yml`.
+
+Then you need to upgrade the frontend schema has well by running `yarn generate-types-from-local-schema`.
+
+Be aware that `get_signup_form_additional_fields_serializer` can tweak the schema generation.

docs/developer/contribute/api.md

@@ -129,8 +129,13 @@ def test_downgrade_not_superuser_skips_email(factories, mocker):
     mocked_notify.assert_not_called()
 ```
 
+<!-- prettier-ignore-start -->
+
+(runtests)=
 ## Run tests
 
+<!-- prettier-ignore-end -->
+
 You can run all tests in the pytest suite with the following command:
 
 ```sh

docs/developer/contribute/copy.md

@@ -47,8 +47,8 @@ const labels = computed(() => ({
 :::{tab-item} Template
 
 ```html
-<h2>{{ $t('components.About.header.funkwhale') }}</h2>
-<button>{{ $t('components.About.button.cancel') }}</button>
+<h2>{{ t('components.About.header.funkwhale') }}</h2>
+<button>{{ t('components.About.button.cancel') }}</button>
 ```
 
 :::
@@ -84,11 +84,11 @@ Some strings change depending on whether they are plural or not. You can create
     v-if="object.artist?.content_category === 'podcast'"
     class="meta ellipsis"
   >
-    {{ $t('components.audio.ChannelCard.meta.episodes', {episode_count:
+    {{ t('components.audio.ChannelCard.meta.episodes', {episode_count:
     object.artist.tracks_count}) }}
   </span>
   <span v-else>
-    {{ $t('components.audio.ChannelCard.meta.tracks', {tracks_count:
+    {{ t('components.audio.ChannelCard.meta.tracks', {tracks_count:
     object.artist?.tracks_count}) }}
   </span>
   <tags-list

docs/developer/contribute/frontend.md

@@ -2,25 +2,72 @@
 
 The Funkwhale frontend is a {abbr}`SPA (Single Page Application)` written in [Typescript](https://typescriptlang.org) and [Vue.js](https://vuejs.org).
 
+## Troubleshooting
+
+### Network errors (405 and 404) in the console
+
+If you are using Google Chrome, you may have to disable the network cache:
+
+- Go to the Dev Tools
+- Select the Network tab
+- In the toolbar under the Network tab, activate the checkmark "Disable Cache"
+
+### Edits don't appear when I check them in the browser
+
+Reload the page with `Ctrl+Shift+R` (Mac: `Cmd+Shift+R`)
+
+Make sure you have no add-ons in your browser that mess with the DOM. The best way to check is to open a private window/tab with `Ctrl/Cmd+Shift+P` (Firefox)
+
 ## Styles
 
-We currently use [Fomantic UI](https://fomantic-ui.com) as our UI framework. We customize this with our own SCSS files located in `front/src/styles/_main.scss`.
+<--! TODO: Mermaid diagrams -->
 
-We apply changes to the Fomantic CSS files before we import them:
+### UI styles
 
-1. We replace hardcoded color values with CSS variables to make themin easier. For example: `color: orange` is replaced by `color: var(--vibrant-color)`
-2. We remove unused values from the CSS files to keep the size down
+```mermaid
+graph TD
+  /node_modules/bootstrap-icons/font/bootstrap-icons.css --> src/styles/font.scss
+  src/styles/base/generic.scss --> src/styles/base/index.scss
+  src/styles/base/index.scss --> src/styles/funkwhale.scss
+  src/styles/font.scss --> src/styles/funkwhale.scss
+  src/styles/colors.scss --> src/styles/funkwhale.scss
+  src/styles/funkwhale.scss --> src/main.ts
+```
 
-These changes are applied when you run `yarn install` through a `postinstall` hook. If you want to modify these changes, check the `front/scripts/fix-fomantic-css.py` script.
+### App styles
 
-We plan to replace Fomantic with our own UI framework in the near future. Check our [Penpot](https://design.funkwhale.audio) to see what we've got planned.
+```mermaid
+graph TD
+  _css_vars --> /themes/_...
+  vendor/_media.scss --> _main.scss
+  /globals/_... --> _main.scss
+  /components/_... --> _main.scss
+  /pages/_... --> _main.scss
+  /themes/_... --> _main.scss
+  _vars.scss --> /themes/_...
+```
 
 ## Components
 
-Our [component library](https://ui.funkwhale.audio) contains reusable Vue components that you can add to the Funkwhale frontend. If you want to add a new component, check out [the repository](https://dev.funkwhale.audio/funkwhale/vui).
+Start the **UI Live Docs** (vitepress) and follow the link:
 
+```sh
+yarn dev:docs
+```
+
+- Example: [Button component in the live docs](http://localhost:5173/components/ui/button)
+
+- Find more details about the UI library and [how to contributein the live docs](http://localhost:5173/contributing)
+
+<!-- prettier-ignore-start -->
+
+(testing)=
 ## Testing
 
+<!-- prettier-ignore-end -->
+
+### Unit tests
+
 The Funkwhale frontend contains some tests to catch errors before changes go live. The coverage is still fairly low, so we welcome any contributions.
 
 To run the test suite, run the following command:
@@ -34,3 +81,7 @@ To run tests as you make changes, launch the test suite with the `-w` flag:
 ```sh
 docker compose run --rm front yarn test:unit -w
 ```
+
+### End-to-end testing and User testing
+
+In addition, there are End-to-end tests (cyprus), and we are planning to do User tests in 2025.

docs/developer/federation/index.md

@@ -19,6 +19,12 @@ maxdepth: 1
 objects
 ```
 
+## How to use federation in the user interface
+
+If you have the fediverse handle of a user ('xx@xx.xx'), displayed in their profile, you can paste this address in the global search field. Funkwhale will then clone the profile onto your instance and you will be able to see their profile locally and follow their activities. You are not automatically subscribed to their channels or have access to their public libraries. We still have to implement this in a [viable way] (https://dev.funkwhale.audio/funkwhale/funkwhale/-/issues/2422)
+
+The same works for rss feeds that are outside of the fediverse. Just enter the RSS feed URI into the search field and you can add it as a podcast or music channel.
+
 ## Technologies and standards
 
 Funkwhale's federation is built on top of the following technologies:
@@ -798,8 +804,7 @@ An `Audio` object is a custom object used to store upload information. It extend
     - Integer
     - The bitrate of the audio in bytes/s
   * - `duration`*
-    - Integer
-    - The duration of the audio in seconds
+    - The duration of the audio as defined in [as](https://www.w3.org/TR/activitystreams-vocabulary/#dfn-duration)
   * - `library`*
     - String (URI)
     - The ID of the audio's containing [`Library` object](#library)
@@ -826,7 +831,7 @@ An `Audio` object is a custom object used to store upload information. It extend
   "name": "Krav Boca - Mortem",
   "size": 8656581,
   "bitrate": 320000,
-  "duration": 213,
+  "duration": "PT1312S,
   "library": "https://awesome.music/federation/music/libraries/dc702491-f6ce-441b-9da0-cecbed08bcc6",
   "updated": "2018-10-02T19:49:35.646372+00:00",
   "published": "2018-10-02T19:49:35.646359+00:00",

docs/developer/federation/privacy.md

@@ -7,16 +7,18 @@ Two level of privacy for activities :
 - from the Actor of the activities
 - from the Object of the activities
 
-We follow both actor and object privacy_level. If an user want to share it's playlist he need both the user privacy level and playlist privacy level set to allow it.
-
 ### User level privacy_level
 
-Check is done in `activity_pass_user_privacy_level` but only works if `actor` is passed within the `context`
+Check is done in `activity_pass_user_privacy_level` but only works if `actor` is passed within the `context`. This applies to object that don't have their own privacy_level settings :
+
+- `Listening`
+- `TrackFavorite`
 
 ### Object privacy_level
 
-Playlist support it's own privacy level. Check is done in `activity_pass_object_privacy_level`. Other objects should be added manually to this function.
+`Playlist` support it's own privacy level. Check is done in `activity_pass_object_privacy_level` for AP activities and on `has_playlist_access` for the federation views. Other objects should be added manually to this function.
+`PlaylistTracks` follow the `Playlist` privacy_level setting.
 
-## Followers privacy_level
+## Followers privacy_level for User
 
 If a user follow a local user we don't need to send ActivityPub activities since the data is already in our db. We can use the local database the fetch the data. That's why Funkwhale outbox will always discard activities that are not public. But this need to be updated to support `followers` privacy level. Some warning should be displayed to the users to explain that setting a privacy_level to `followers` will send the data to remote server. This means we need to trust the remote server admins to follow our privacy_level wish. In other words when you trust your followers your also trust the admins of your followers.