Skip to content
GitLab
Menu
Projects
Groups
Snippets
Help
Help
Support
Community forum
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
Menu
Open sidebar
funkwhale
funkwhale
Commits
a8f7893d
Verified
Commit
a8f7893d
authored
Oct 20, 2018
by
Eliot Berriot
Browse files
Fix #470: Properly encode Wikipedia and lyrics search urls
parent
3a5a4465
Pipeline
#2263
passed with stages
in 6 minutes and 57 seconds
Changes
4
Pipelines
1
Hide whitespace changes
Inline
Side-by-side
changes/changelog.d/470.bugfix
0 → 100644
View file @
a8f7893d
Properly encode Wikipedia and lyrics search urls (#470)
front/src/components/library/Album.vue
View file @
a8f7893d
...
...
@@ -102,7 +102,7 @@ export default {
}
},
wikipediaUrl
()
{
return
'
https://en.wikipedia.org/w/index.php?search=
'
+
this
.
album
.
title
+
'
'
+
this
.
album
.
artist
.
name
return
'
https://en.wikipedia.org/w/index.php?search=
'
+
encodeURI
(
this
.
album
.
title
+
'
'
+
this
.
album
.
artist
.
name
)
},
musicbrainzUrl
()
{
return
'
https://musicbrainz.org/release/
'
+
this
.
album
.
mbid
...
...
front/src/components/library/Artist.vue
View file @
a8f7893d
...
...
@@ -151,7 +151,7 @@ export default {
}).
length
>
0
},
wikipediaUrl
()
{
return
'
https://en.wikipedia.org/w/index.php?search=
'
+
this
.
artist
.
name
return
'
https://en.wikipedia.org/w/index.php?search=
'
+
encodeURI
(
this
.
artist
.
name
)
},
musicbrainzUrl
()
{
return
'
https://musicbrainz.org/artist/
'
+
this
.
artist
.
mbid
...
...
front/src/components/library/Track.vue
View file @
a8f7893d
...
...
@@ -196,7 +196,7 @@ export default {
}
},
wikipediaUrl
()
{
return
'
https://en.wikipedia.org/w/index.php?search=
'
+
this
.
track
.
title
+
'
'
+
this
.
track
.
artist
.
name
return
'
https://en.wikipedia.org/w/index.php?search=
'
+
encodeURI
(
this
.
track
.
title
+
'
'
+
this
.
track
.
artist
.
name
)
},
musicbrainzUrl
()
{
return
'
https://musicbrainz.org/recording/
'
+
this
.
track
.
mbid
...
...
@@ -211,7 +211,7 @@ export default {
lyricsSearchUrl
()
{
let
base
=
'
http://lyrics.wikia.com/wiki/Special:Search?query=
'
let
query
=
this
.
track
.
artist
.
name
+
'
'
+
this
.
track
.
title
return
base
+
query
return
base
+
encodeURI
(
query
)
},
cover
()
{
return
null
...
...
Write
Preview
Supports
Markdown
0%
Try again
or
attach a new file
.
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment