Commit 51d94a13 authored by Agate's avatar Agate 💬

Merge branch '798-more-flexible-user-url' into 'develop'

Fix #798: Allow users with dots in their usernames to request a subsonic password

Closes #798

See merge request funkwhale/funkwhale!733
parents dfae0334 b23e87e1
Pipeline #4011 passed with stages
in 8 minutes and 44 seconds
......@@ -28,6 +28,7 @@ class UserViewSet(mixins.UpdateModelMixin, viewsets.GenericViewSet):
queryset = models.User.objects.all()
serializer_class = serializers.UserWriteSerializer
lookup_field = "username"
lookup_value_regex = r"[a-zA-Z0-9-_.]+"
required_scope = "profile"
@action(methods=["get"], detail=False)
......
......@@ -230,6 +230,21 @@ def test_user_can_get_subsonic_token(logged_in_api_client):
assert response.data == {"subsonic_api_token": "test"}
def test_user_can_request_new_subsonic_token_uncommon_username(logged_in_api_client):
user = logged_in_api_client.user
user.username = "firstname.lastname"
user.subsonic_api_token = "test"
user.save()
url = reverse(
"api:v1:users:users-subsonic-token", kwargs={"username": user.username}
)
response = logged_in_api_client.post(url)
assert response.status_code == 200
def test_user_can_delete_subsonic_token(logged_in_api_client):
user = logged_in_api_client.user
user.subsonic_api_token = "test"
......
Allow users with dots in their usernames to request a subsonic password (#798)
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment