cli merge requestshttps://dev.funkwhale.audio/funkwhale/cli/-/merge_requests2024-03-11T04:05:11Zhttps://dev.funkwhale.audio/funkwhale/cli/-/merge_requests/27chore(deps): update dependency aiofiles to v0.8.02024-03-11T04:05:11ZRenovateBotchore(deps): update dependency aiofiles to v0.8.0This MR contains the following updates:
| Package | Type | Update | Change |
|---|---|---|---|
| [aiofiles](https://github.com/Tinche/aiofiles#history) ([changelog](https://github.com/Tinche/aiofiles#history)) | install | minor | `==0.7...This MR contains the following updates:
| Package | Type | Update | Change |
|---|---|---|---|
| [aiofiles](https://github.com/Tinche/aiofiles#history) ([changelog](https://github.com/Tinche/aiofiles#history)) | install | minor | `==0.7.0` -> `==0.8.0` |
---
### Release Notes
<details>
<summary>Tinche/aiofiles (aiofiles)</summary>
### [`v0.8.0`](https://github.com/Tinche/aiofiles/compare/v0.7.0...v0.8.0)
[Compare Source](https://github.com/Tinche/aiofiles/compare/v0.7.0...v0.8.0)
</details>
---
### Configuration
📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.
â™» **Rebasing**: Whenever MR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 **Ignore**: Close this MR and you won't be reminded about this update again.
---
- [ ] <!-- rebase-check -->If you want to rebase/retry this MR, check this box
---
This MR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4xMjguMCIsInVwZGF0ZWRJblZlciI6IjM3LjEyOC4wIiwidGFyZ2V0QnJhbmNoIjoibWFzdGVyIn0=-->https://dev.funkwhale.audio/funkwhale/cli/-/merge_requests/17Added OAuth login-method2024-03-11T04:05:22ZEorlBruderAdded OAuth login-methodFixes #1
The following was implemented
- Added separate method for the login. This method takes the
client-id and client-secret as params.
- Added method to refresh the oauth-token
Open questions/issues
- [x] Should this completly ...Fixes #1
The following was implemented
- Added separate method for the login. This method takes the
client-id and client-secret as params.
- Added method to refresh the oauth-token
Open questions/issues
- [x] Should this completly replace the basic-auth method?
- In that case I would name the method login
- Otherwise we should decide whether the oauth is the main method for this (being called login) or if basic-auth should be main
- [x] Should there be an option to provide the access-token from the application-details overview? It would probably be useful and users wouldn't need to authenticate (and specifically refresh) with the client-id and client-secret
- [x] For refreshing the token the client-id and secret need to be provided again, making that process kinda similar to the usual login. Maybe here it would be an idea to also save client and server id in the keyring and refresh automatically on auth-errors.
- [x] The docs need to be updated for this
- [x] There are no unit-tests for this functionality yetGeorg KrauseGeorg Krause