cli merge requestshttps://dev.funkwhale.audio/funkwhale/cli/-/merge_requests2020-04-09T13:37:34Zhttps://dev.funkwhale.audio/funkwhale/cli/-/merge_requests/8Fix hack incompatibility with cryptfile keyring2020-04-09T13:37:34ZAdrian PetrescuFix hack incompatibility with cryptfile keyringI'm not exactly sure what this hack was ever supposed to accomplish, but it's clearly unnecessary for dummy keyrings like `keyrings.alt` or `keyrings.cryptfile`. When I try to login, the CLI just crashes with an `AttributeError` on `keyr...I'm not exactly sure what this hack was ever supposed to accomplish, but it's clearly unnecessary for dummy keyrings like `keyrings.alt` or `keyrings.cryptfile`. When I try to login, the CLI just crashes with an `AttributeError` on `keyring.backend.get_all_keyring.__wrapped__.always_returns`, which is what the hack is trying to remove anyway.
So this patch just skips trying to `del` the attribute if it already doesn't exist.backloghttps://dev.funkwhale.audio/funkwhale/cli/-/merge_requests/26chore(deps): pin dependencies2024-01-10T14:29:33ZRenovateBotchore(deps): pin dependenciesThis MR contains the following updates:
| Package | Type | Update | Change |
|---|---|---|---|
| [aiofiles](https://github.com/Tinche/aiofiles#history) ([changelog](https://github.com/Tinche/aiofiles#history)) | install | pin | `~=0.7.0...This MR contains the following updates:
| Package | Type | Update | Change |
|---|---|---|---|
| [aiofiles](https://github.com/Tinche/aiofiles#history) ([changelog](https://github.com/Tinche/aiofiles#history)) | install | pin | `~=0.7.0` -> `==0.7.0` |
| [aiohttp](https://github.com/aio-libs/aiohttp) | install | pin | `~=3.7.4` -> `==3.7.4.post0` |
| [aioresponses](https://github.com/pnuckowski/aioresponses) | extra | pin | `~=0.7.2` -> `==0.7.6` |
| [appdirs](https://github.com/ActiveState/appdirs) | install | pin | `~=1.4.4` -> `==1.4.4` |
| [asynctest](https://github.com/Martiusweb/asynctest) | extra | pin | `~=0.13.0` -> `==0.13.0` |
| [click](https://palletsprojects.com/p/click/) ([changelog](https://click.palletsprojects.com/changes/)) | install | pin | `~=7.1.2` -> `==7.1.2` |
| [click-log](https://github.com/click-contrib/click-log) | install | pin | `~=0.3.2` -> `==0.3.2` |
| [ipdb](https://github.com/gotcha/ipdb) | extra | pin | `~=0.13.9` -> `==0.13.13` |
| [keyring](https://github.com/jaraco/keyring) | install | pin | `~=23.0.1` -> `==23.0.1` |
| [marshmallow](https://github.com/marshmallow-code/marshmallow) ([changelog](https://marshmallow.readthedocs.io/en/latest/changelog.html)) | install | pin | `~=2.19.2` -> `==2.19.5` |
| [pathvalidate](https://github.com/thombashi/pathvalidate) | install | pin | `~=2.4.1` -> `==2.4.1` |
| [pyinstaller](https://www.pyinstaller.org/) ([source](https://github.com/pyinstaller/pyinstaller)) | extra | pin | `~=4.3` -> `==4.10` |
| [pytest](https://docs.pytest.org/en/latest/) ([source](https://github.com/pytest-dev/pytest), [changelog](https://docs.pytest.org/en/stable/changelog.html)) | extra | pin | `~=6.2.4` -> `==6.2.5` |
| [pytest-env](https://github.com/pytest-dev/pytest-env) | extra | pin | `~=0.6.2` -> `==0.6.2` |
| [pytest-mock](https://github.com/pytest-dev/pytest-mock) ([changelog](https://pytest-mock.readthedocs.io/en/latest/changelog.html)) | extra | pin | `~=3.6.1` -> `==3.6.1` |
| [python-dotenv](https://github.com/theskumar/python-dotenv) | install | pin | `~=0.18.0` -> `==0.18.0` |
| [semver](https://github.com/python-semver/python-semver) ([changelog](https://python-semver.readthedocs.io/en/latest/changelog.html)) | install | pin | `~=2.13.0` -> `==2.13.0` |
| [setuptools](https://github.com/pypa/setuptools) ([changelog](https://setuptools.pypa.io/en/stable/history.html)) | extra | pin | `~=56.0.0` -> `==56.0.0` |
| [tabulate](https://github.com/astanin/python-tabulate) | install | pin | `~=0.8.9` -> `==0.8.10` |
| [towncrier](https://github.com/twisted/towncrier) | extra | pin | `~=21.3.0` -> `==21.3.0` |
| [tqdm](https://github.com/tqdm/tqdm) ([changelog](https://tqdm.github.io/releases)) | install | pin | `~=4.61.1` -> `==4.61.2` |
| [twine](https://twine.readthedocs.io/) ([source](https://github.com/pypa/twine)) | extra | pin | `~=3.4.1` -> `==3.4.2` |
| [wheel](https://github.com/pypa/wheel) ([changelog](https://wheel.readthedocs.io/en/stable/news.html)) | extra | pin | `~=0.36.2` -> `==0.36.2` |
Add the preset `:preserveSemverRanges` to your config if you don't want to pin your dependencies.
---
### Configuration
📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.
♻ **Rebasing**: Whenever MR is behind base branch, or you tick the rebase/retry checkbox.
👻 **Immortal**: This MR will be recreated if closed unmerged. Get [config help](https://github.com/renovatebot/renovate/discussions) if that's undesired.
---
- [ ] <!-- rebase-check -->If you want to rebase/retry this MR, check this box
---
This MR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4xMjguMCIsInVwZGF0ZWRJblZlciI6IjM3LjEyOC4wIiwidGFyZ2V0QnJhbmNoIjoibWFzdGVyIn0=-->https://dev.funkwhale.audio/funkwhale/cli/-/merge_requests/25Configure Renovate2024-01-10T13:40:15ZRenovateBotConfigure RenovateWelcome to [Renovate](https://github.com/renovatebot/renovate)! This is an onboarding MR to help you understand and configure settings before regular Merge Requests begin.
🚦 To activate Renovate, merge this Merge Request. To disable Ren...Welcome to [Renovate](https://github.com/renovatebot/renovate)! This is an onboarding MR to help you understand and configure settings before regular Merge Requests begin.
🚦 To activate Renovate, merge this Merge Request. To disable Renovate, simply close this Merge Request unmerged.
---
### Detected Package Files
* `.gitlab-ci.yml` (gitlabci)
* `setup.cfg` (setup-cfg)
### What to Expect
With your current configuration, Renovate will create 30 Merge Requests:
<details>
<summary>chore(deps): update dependency aiofiles to ~=0.8.0</summary>
- Schedule: ["at any time"]
- Branch name: `renovate/aiofiles-0.x`
- Merge into: `master`
- Upgrade [aiofiles](https://github.com/Tinche/aiofiles#history) to `~=0.8.0`
</details>
<details>
<summary>chore(deps): update dependency aiohttp to ~=3.9.1</summary>
- Schedule: ["at any time"]
- Branch name: `renovate/aiohttp-3.x`
- Merge into: `master`
- Upgrade [aiohttp](https://github.com/aio-libs/aiohttp) to `~=3.9.1`
</details>
<details>
<summary>chore(deps): update dependency click-log to ~=0.4.0</summary>
- Schedule: ["at any time"]
- Branch name: `renovate/click-log-0.x`
- Merge into: `master`
- Upgrade [click-log](https://github.com/click-contrib/click-log) to `~=0.4.0`
</details>
<details>
<summary>chore(deps): update dependency keyring to ~=23.13.1</summary>
- Schedule: ["at any time"]
- Branch name: `renovate/keyring-23.x`
- Merge into: `master`
- Upgrade [keyring](https://github.com/jaraco/keyring) to `~=23.13.1`
</details>
<details>
<summary>chore(deps): update dependency marshmallow to ~=2.21.0</summary>
- Schedule: ["at any time"]
- Branch name: `renovate/marshmallow-2.x`
- Merge into: `master`
- Upgrade [marshmallow](https://github.com/marshmallow-code/marshmallow) to `~=2.21.0`
</details>
<details>
<summary>chore(deps): update dependency pathvalidate to ~=2.5.2</summary>
- Schedule: ["at any time"]
- Branch name: `renovate/pathvalidate-2.x`
- Merge into: `master`
- Upgrade [pathvalidate](https://github.com/thombashi/pathvalidate) to `~=2.5.2`
</details>
<details>
<summary>chore(deps): update dependency pytest-env to ~=0.8.2</summary>
- Schedule: ["at any time"]
- Branch name: `renovate/pytest-env-0.x`
- Merge into: `master`
- Upgrade [pytest-env](https://github.com/pytest-dev/pytest-env) to `~=0.8.2`
</details>
<details>
<summary>chore(deps): update dependency pytest-mock to ~=3.12.0</summary>
- Schedule: ["at any time"]
- Branch name: `renovate/pytest-mock-3.x`
- Merge into: `master`
- Upgrade [pytest-mock](https://github.com/pytest-dev/pytest-mock) to `~=3.12.0`
</details>
<details>
<summary>chore(deps): update dependency python-dotenv to ~=0.21.1</summary>
- Schedule: ["at any time"]
- Branch name: `renovate/python-dotenv-0.x`
- Merge into: `master`
- Upgrade [python-dotenv](https://github.com/theskumar/python-dotenv) to `~=0.21.1`
</details>
<details>
<summary>chore(deps): update dependency setuptools to ~=56.2.0</summary>
- Schedule: ["at any time"]
- Branch name: `renovate/setuptools-56.x`
- Merge into: `master`
- Upgrade [setuptools](https://github.com/pypa/setuptools) to `~=56.2.0`
</details>
<details>
<summary>chore(deps): update dependency tabulate to ~=0.9.0</summary>
- Schedule: ["at any time"]
- Branch name: `renovate/tabulate-0.x`
- Merge into: `master`
- Upgrade [tabulate](https://github.com/astanin/python-tabulate) to `~=0.9.0`
</details>
<details>
<summary>chore(deps): update dependency towncrier to ~=21.9.0</summary>
- Schedule: ["at any time"]
- Branch name: `renovate/towncrier-21.x`
- Merge into: `master`
- Upgrade [towncrier](https://github.com/twisted/towncrier) to `~=21.9.0`
</details>
<details>
<summary>chore(deps): update dependency tqdm to ~=4.66.1</summary>
- Schedule: ["at any time"]
- Branch name: `renovate/tqdm-4.x`
- Merge into: `master`
- Upgrade [tqdm](https://github.com/tqdm/tqdm) to `~=4.66.1`
</details>
<details>
<summary>chore(deps): update dependency twine to ~=3.8.0</summary>
- Schedule: ["at any time"]
- Branch name: `renovate/twine-3.x`
- Merge into: `master`
- Upgrade [twine](https://github.com/pypa/twine) to `~=3.8.0`
</details>
<details>
<summary>chore(deps): update dependency wheel to ~=0.42.0</summary>
- Schedule: ["at any time"]
- Branch name: `renovate/wheel-0.x`
- Merge into: `master`
- Upgrade [wheel](https://github.com/pypa/wheel) to `~=0.42.0`
</details>
<details>
<summary>chore(deps): update python docker tag to v3.12</summary>
- Schedule: ["at any time"]
- Branch name: `renovate/python-3.x`
- Merge into: `master`
- Upgrade python to `3.12`
</details>
<details>
<summary>chore(deps): update dependency aiofiles to v23</summary>
- Schedule: ["at any time"]
- Branch name: `renovate/aiofiles-23.x`
- Merge into: `master`
- Upgrade [aiofiles](https://github.com/Tinche/aiofiles#history) to `~=23.2.1`
</details>
<details>
<summary>chore(deps): update dependency click to v8</summary>
- Schedule: ["at any time"]
- Branch name: `renovate/click-8.x`
- Merge into: `master`
- Upgrade click to `~=8.1.7`
</details>
<details>
<summary>chore(deps): update dependency keyring to v24</summary>
- Schedule: ["at any time"]
- Branch name: `renovate/keyring-24.x`
- Merge into: `master`
- Upgrade [keyring](https://github.com/jaraco/keyring) to `~=24.3.0`
</details>
<details>
<summary>chore(deps): update dependency marshmallow to v3</summary>
- Schedule: ["at any time"]
- Branch name: `renovate/marshmallow-3.x`
- Merge into: `master`
- Upgrade [marshmallow](https://github.com/marshmallow-code/marshmallow) to `~=3.20.2`
</details>
<details>
<summary>chore(deps): update dependency pathvalidate to v3</summary>
- Schedule: ["at any time"]
- Branch name: `renovate/pathvalidate-3.x`
- Merge into: `master`
- Upgrade [pathvalidate](https://github.com/thombashi/pathvalidate) to `~=3.2.0`
</details>
<details>
<summary>chore(deps): update dependency pyinstaller to v6</summary>
- Schedule: ["at any time"]
- Branch name: `renovate/pyinstaller-6.x`
- Merge into: `master`
- Upgrade [pyinstaller](https://github.com/pyinstaller/pyinstaller) to `~=6.3`
</details>
<details>
<summary>chore(deps): update dependency pytest to v7</summary>
- Schedule: ["at any time"]
- Branch name: `renovate/pytest-7.x`
- Merge into: `master`
- Upgrade [pytest](https://github.com/pytest-dev/pytest) to `~=7.4.4`
</details>
<details>
<summary>chore(deps): update dependency pytest-env to v1</summary>
- Schedule: ["at any time"]
- Branch name: `renovate/pytest-env-1.x`
- Merge into: `master`
- Upgrade [pytest-env](https://github.com/pytest-dev/pytest-env) to `~=1.1.3`
</details>
<details>
<summary>chore(deps): update dependency python-dotenv to v1</summary>
- Schedule: ["at any time"]
- Branch name: `renovate/python-dotenv-1.x`
- Merge into: `master`
- Upgrade [python-dotenv](https://github.com/theskumar/python-dotenv) to `~=1.0.0`
</details>
<details>
<summary>chore(deps): update dependency semver to v3</summary>
- Schedule: ["at any time"]
- Branch name: `renovate/semver-3.x`
- Merge into: `master`
- Upgrade [semver](https://github.com/python-semver/python-semver) to `~=3.0.2`
</details>
<details>
<summary>chore(deps): update dependency setuptools to v69</summary>
- Schedule: ["at any time"]
- Branch name: `renovate/setuptools-69.x`
- Merge into: `master`
- Upgrade [setuptools](https://github.com/pypa/setuptools) to `~=69.0.3`
</details>
<details>
<summary>chore(deps): update dependency towncrier to v23</summary>
- Schedule: ["at any time"]
- Branch name: `renovate/towncrier-23.x`
- Merge into: `master`
- Upgrade [towncrier](https://github.com/twisted/towncrier) to `~=23.11.0`
</details>
<details>
<summary>chore(deps): update dependency twine to v4</summary>
- Schedule: ["at any time"]
- Branch name: `renovate/twine-4.x`
- Merge into: `master`
- Upgrade [twine](https://github.com/pypa/twine) to `~=4.0.2`
</details>
<details>
<summary>chore(deps): update docker docker tag to v24</summary>
- Schedule: ["at any time"]
- Branch name: `renovate/docker-24.x`
- Merge into: `master`
- Upgrade docker to `24-dind`
</details>
<br />
🚸 Branch creation will be limited to maximum 2 per hour, so it doesn't swamp any CI resources or overwhelm the project. See docs for `prhourlylimit` for details.
---
❓ Got questions? Check out Renovate's [Docs](https://docs.renovatebot.com/), particularly the Getting Started section.
If you need any further assistance then you can also [request help here](https://github.com/renovatebot/renovate/discussions).
---
This MR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).
<!--renovate-config-hash:94693a990c975907e7f13da3309b9d56ba02b3983519b41786edf5cf031e457c-->Georg KrauseGeorg Krausehttps://dev.funkwhale.audio/funkwhale/cli/-/merge_requests/24fix: python 3.10 compatibility2022-07-21T16:17:57ZJuniorJPDJfix: python 3.10 compatibilityretry of !22retry of !22Georg KrauseGeorg Krausehttps://dev.funkwhale.audio/funkwhale/cli/-/merge_requests/23feat(ci): test on every python version2022-07-20T17:16:33ZJuniorJPDJfeat(ci): test on every python versiondepends on !22depends on !22https://dev.funkwhale.audio/funkwhale/cli/-/merge_requests/22fix: python 3.10 compatibility2022-07-21T08:26:53ZJuniorJPDJfix: python 3.10 compatibilityfixes #28fixes #28https://dev.funkwhale.audio/funkwhale/cli/-/merge_requests/21Output the disc-number2022-06-07T16:11:27ZEorlBruderOutput the disc-numberThe disc-number was using the wrong field name.
Fixes #25The disc-number was using the wrong field name.
Fixes #25https://dev.funkwhale.audio/funkwhale/cli/-/merge_requests/20bugfix: Albums Tracks field is track count only2021-11-28T10:29:06Zvilibaldbugfix: Albums Tracks field is track count onlyhttps://dev.funkwhale.audio/funkwhale/cli/-/merge_requests/19Fix #23: Missing server command2021-08-23T20:03:11ZMatthew J.Fix #23: Missing server commandBrings back the `funkwhale server` command.Brings back the `funkwhale server` command.https://dev.funkwhale.audio/funkwhale/cli/-/merge_requests/18Added publish-pipeline2021-08-05T09:21:51ZEorlBruderAdded publish-pipelineFixes #20
This will publish new versions to pypi from tagged commits.
We probably should create a first version in a new issue. I'd suggest versioning similar to the compatible funkwhale version (thus creating 1.1.x versions). In that...Fixes #20
This will publish new versions to pypi from tagged commits.
We probably should create a first version in a new issue. I'd suggest versioning similar to the compatible funkwhale version (thus creating 1.1.x versions). In that issue we might also add items for the CHANGELOG from the issues closed up until now.
/cc @georgkrauseGeorg KrauseGeorg Krausehttps://dev.funkwhale.audio/funkwhale/cli/-/merge_requests/16Clean up and pin dependencies2021-06-25T10:10:35ZEorlBruderClean up and pin dependenciesThis MR is regarding #9.
**Changes**
- Removed the requirements.txt, thus we only have one way of tracking dependencies (the setup.cfg)
- Adjusted the metadata in setup.cfg. This would mean a transfer from @agate to the collective.
- ...This MR is regarding #9.
**Changes**
- Removed the requirements.txt, thus we only have one way of tracking dependencies (the setup.cfg)
- Adjusted the metadata in setup.cfg. This would mean a transfer from @agate to the collective.
- split up the extra_requires into dev, build and test
- I pinned the dependencies to the ones which pip auto-pulled for me
**Open questions**
- [x] Is the transfer of the authorship desired in this case?
- [x] I was a bit unsure about which e-mail-address to use in the metadata, for now I used the one from https://dev.funkwhale.audio/funkwhale/mopidy/-/blob/master/setup.cfg
- [ ] I'm a little bit conflicted about pinning the dependencies to those specific versions. On one hand it means we know the environment in which each version of the tool will run, thus making debugging easier. On the other hand it means we should continually update, to not miss critical updates. I can imagine something like https://gitlab.com/dependabot-gitlab/dependabot could help out here?
- [x] What is the best practice regarding which version to pin and how to pin it? Like I mentioned in this case I just used the ones which pip pulled for me - but should maybe rather pull more "major" versions and use "~=" for minor versions?
- [x] In the classifiers-section Python 3.6 is specifically mentioned. Should this be bumped up to a newer version too?
- [x] In the cli.spec, there's a line referencing a specfic home-directory. I feel like this should be more generic, though I have no idea what exactly happens in that file and also nothing seems to be breaking atm. (I marked that one with a TODO).https://dev.funkwhale.audio/funkwhale/cli/-/merge_requests/15Added AGPL-license2021-06-18T14:05:29ZEorlBruderAdded AGPL-licenseFixes #21Fixes #21https://dev.funkwhale.audio/funkwhale/cli/-/merge_requests/14Access keys via get, to prevent KeyErrors2021-06-18T14:03:08ZEorlBruderAccess keys via get, to prevent KeyErrorsFixes #19Fixes #19https://dev.funkwhale.audio/funkwhale/cli/-/merge_requests/13Added generate-playlist command to tracks2021-06-18T07:28:01ZEorlBruderAdded generate-playlist command to tracksThis command allows users to generate a playlist, similar
to the feature described in #16.This command allows users to generate a playlist, similar
to the feature described in #16.https://dev.funkwhale.audio/funkwhale/cli/-/merge_requests/12Don't abort whole download, when one file doesn't exist2021-06-17T08:10:20ZEorlBruderDon't abort whole download, when one file doesn't existWe now catch the error raised, when a file doesn't exist and just skip
that file. Also the exception is a bit more verbose and provides the
affected id.
Fixes #18We now catch the error raised, when a file doesn't exist and just skip
that file. Also the exception is a bit more verbose and provides the
affected id.
Fixes #18https://dev.funkwhale.audio/funkwhale/cli/-/merge_requests/10Replace "/" in param-name with "_" during sanitizing2021-06-06T09:29:50ZEorlBruderReplace "/" in param-name with "_" during sanitizingWhile sanitizing the params for filenames, this avoids creating
unwanted sub-dirs, when fields contain "/".
Fixes #17While sanitizing the params for filenames, this avoids creating
unwanted sub-dirs, when fields contain "/".
Fixes #17https://dev.funkwhale.audio/funkwhale/cli/-/merge_requests/9Added definition of ID field to "PLAYLIST_TRACK"2021-06-03T04:25:52ZEorlBruderAdded definition of ID field to "PLAYLIST_TRACK"fixes #15fixes #15Georg KrauseGeorg Krausehttps://dev.funkwhale.audio/funkwhale/cli/-/merge_requests/7Handling ValueError exception when login command2019-06-19T08:39:52ZneodarzHandling ValueError exception when login commandThis fix #8.This fix #8.https://dev.funkwhale.audio/funkwhale/cli/-/merge_requests/6Handling ValueError exception when commands executed2019-06-19T08:40:52ZneodarzHandling ValueError exception when commands executedThis fix issue #7.This fix issue #7.https://dev.funkwhale.audio/funkwhale/cli/-/merge_requests/5Resolve "Provide precompiled binaries for easier install"2019-05-23T15:43:21ZAgateResolve "Provide precompiled binaries for easier install"Closes #5Closes #5