cli merge requestshttps://dev.funkwhale.audio/funkwhale/cli/-/merge_requests2019-05-23T07:39:04Zhttps://dev.funkwhale.audio/funkwhale/cli/-/merge_requests/1Add pathvalidate module dependence2019-05-23T07:39:04ZneodarzAdd pathvalidate module dependenceThis fix issue #2. But for the moment there is only `pathvalidate` because the second dependence need some discussions.This fix issue #2. But for the moment there is only `pathvalidate` because the second dependence need some discussions.https://dev.funkwhale.audio/funkwhale/cli/-/merge_requests/2Cryptfile exception handling2019-05-23T07:44:18ZneodarzCryptfile exception handlingCatch the exception handled by the cryptfile backend of keyring module when enter keyring password. This fix #3.Catch the exception handled by the cryptfile backend of keyring module when enter keyring password. This fix #3.https://dev.funkwhale.audio/funkwhale/cli/-/merge_requests/3Ci2019-05-23T08:04:44ZAgateCiBasic CI setup, fix #6 Basic CI setup, fix #6 https://dev.funkwhale.audio/funkwhale/cli/-/merge_requests/4Fix #4: lazy password evaluation2019-05-23T08:30:59ZAgateFix #4: lazy password evaluationCloses #4
Mimics django's lazy string behaviour.Closes #4
Mimics django's lazy string behaviour.https://dev.funkwhale.audio/funkwhale/cli/-/merge_requests/5Resolve "Provide precompiled binaries for easier install"2019-05-23T15:43:21ZAgateResolve "Provide precompiled binaries for easier install"Closes #5Closes #5https://dev.funkwhale.audio/funkwhale/cli/-/merge_requests/6Handling ValueError exception when commands executed2019-06-19T08:40:52ZneodarzHandling ValueError exception when commands executedThis fix issue #7.This fix issue #7.https://dev.funkwhale.audio/funkwhale/cli/-/merge_requests/7Handling ValueError exception when login command2019-06-19T08:39:52ZneodarzHandling ValueError exception when login commandThis fix #8.This fix #8.https://dev.funkwhale.audio/funkwhale/cli/-/merge_requests/8Fix hack incompatibility with cryptfile keyring2020-04-09T13:37:34ZAdrian PetrescuFix hack incompatibility with cryptfile keyringI'm not exactly sure what this hack was ever supposed to accomplish, but it's clearly unnecessary for dummy keyrings like `keyrings.alt` or `keyrings.cryptfile`. When I try to login, the CLI just crashes with an `AttributeError` on `keyr...I'm not exactly sure what this hack was ever supposed to accomplish, but it's clearly unnecessary for dummy keyrings like `keyrings.alt` or `keyrings.cryptfile`. When I try to login, the CLI just crashes with an `AttributeError` on `keyring.backend.get_all_keyring.__wrapped__.always_returns`, which is what the hack is trying to remove anyway.
So this patch just skips trying to `del` the attribute if it already doesn't exist.backloghttps://dev.funkwhale.audio/funkwhale/cli/-/merge_requests/9Added definition of ID field to "PLAYLIST_TRACK"2021-06-03T04:25:52ZEorlBruderAdded definition of ID field to "PLAYLIST_TRACK"fixes #15fixes #15Georg KrauseGeorg Krausehttps://dev.funkwhale.audio/funkwhale/cli/-/merge_requests/10Replace "/" in param-name with "_" during sanitizing2021-06-06T09:29:50ZEorlBruderReplace "/" in param-name with "_" during sanitizingWhile sanitizing the params for filenames, this avoids creating
unwanted sub-dirs, when fields contain "/".
Fixes #17While sanitizing the params for filenames, this avoids creating
unwanted sub-dirs, when fields contain "/".
Fixes #17https://dev.funkwhale.audio/funkwhale/cli/-/merge_requests/12Don't abort whole download, when one file doesn't exist2021-06-17T08:10:20ZEorlBruderDon't abort whole download, when one file doesn't existWe now catch the error raised, when a file doesn't exist and just skip
that file. Also the exception is a bit more verbose and provides the
affected id.
Fixes #18We now catch the error raised, when a file doesn't exist and just skip
that file. Also the exception is a bit more verbose and provides the
affected id.
Fixes #18https://dev.funkwhale.audio/funkwhale/cli/-/merge_requests/13Added generate-playlist command to tracks2021-06-18T07:28:01ZEorlBruderAdded generate-playlist command to tracksThis command allows users to generate a playlist, similar
to the feature described in #16.This command allows users to generate a playlist, similar
to the feature described in #16.https://dev.funkwhale.audio/funkwhale/cli/-/merge_requests/14Access keys via get, to prevent KeyErrors2021-06-18T14:03:08ZEorlBruderAccess keys via get, to prevent KeyErrorsFixes #19Fixes #19https://dev.funkwhale.audio/funkwhale/cli/-/merge_requests/15Added AGPL-license2021-06-18T14:05:29ZEorlBruderAdded AGPL-licenseFixes #21Fixes #21https://dev.funkwhale.audio/funkwhale/cli/-/merge_requests/16Clean up and pin dependencies2021-06-25T10:10:35ZEorlBruderClean up and pin dependenciesThis MR is regarding #9.
**Changes**
- Removed the requirements.txt, thus we only have one way of tracking dependencies (the setup.cfg)
- Adjusted the metadata in setup.cfg. This would mean a transfer from @agate to the collective.
- ...This MR is regarding #9.
**Changes**
- Removed the requirements.txt, thus we only have one way of tracking dependencies (the setup.cfg)
- Adjusted the metadata in setup.cfg. This would mean a transfer from @agate to the collective.
- split up the extra_requires into dev, build and test
- I pinned the dependencies to the ones which pip auto-pulled for me
**Open questions**
- [x] Is the transfer of the authorship desired in this case?
- [x] I was a bit unsure about which e-mail-address to use in the metadata, for now I used the one from https://dev.funkwhale.audio/funkwhale/mopidy/-/blob/master/setup.cfg
- [ ] I'm a little bit conflicted about pinning the dependencies to those specific versions. On one hand it means we know the environment in which each version of the tool will run, thus making debugging easier. On the other hand it means we should continually update, to not miss critical updates. I can imagine something like https://gitlab.com/dependabot-gitlab/dependabot could help out here?
- [x] What is the best practice regarding which version to pin and how to pin it? Like I mentioned in this case I just used the ones which pip pulled for me - but should maybe rather pull more "major" versions and use "~=" for minor versions?
- [x] In the classifiers-section Python 3.6 is specifically mentioned. Should this be bumped up to a newer version too?
- [x] In the cli.spec, there's a line referencing a specfic home-directory. I feel like this should be more generic, though I have no idea what exactly happens in that file and also nothing seems to be breaking atm. (I marked that one with a TODO).https://dev.funkwhale.audio/funkwhale/cli/-/merge_requests/18Added publish-pipeline2021-08-05T09:21:51ZEorlBruderAdded publish-pipelineFixes #20
This will publish new versions to pypi from tagged commits.
We probably should create a first version in a new issue. I'd suggest versioning similar to the compatible funkwhale version (thus creating 1.1.x versions). In that...Fixes #20
This will publish new versions to pypi from tagged commits.
We probably should create a first version in a new issue. I'd suggest versioning similar to the compatible funkwhale version (thus creating 1.1.x versions). In that issue we might also add items for the CHANGELOG from the issues closed up until now.
/cc @georgkrauseGeorg KrauseGeorg Krausehttps://dev.funkwhale.audio/funkwhale/cli/-/merge_requests/19Fix #23: Missing server command2021-08-23T20:03:11ZMatthew J.Fix #23: Missing server commandBrings back the `funkwhale server` command.Brings back the `funkwhale server` command.https://dev.funkwhale.audio/funkwhale/cli/-/merge_requests/20bugfix: Albums Tracks field is track count only2021-11-28T10:29:06Zvilibaldbugfix: Albums Tracks field is track count onlyhttps://dev.funkwhale.audio/funkwhale/cli/-/merge_requests/21Output the disc-number2022-06-07T16:11:27ZEorlBruderOutput the disc-numberThe disc-number was using the wrong field name.
Fixes #25The disc-number was using the wrong field name.
Fixes #25https://dev.funkwhale.audio/funkwhale/cli/-/merge_requests/22fix: python 3.10 compatibility2022-07-21T08:26:53ZJuniorJPDJfix: python 3.10 compatibilityfixes #28fixes #28