From fc8f29d52e2b4b7a532914b0c8b870c4f86f0c2b Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Ciar=C3=A1n=20Ainsworth?= <cda@rootkey.co.uk>
Date: Wed, 22 Jul 2020 12:10:07 +0100
Subject: [PATCH] Improve naming of pages for accessibility audit
---
changes/changelog.d/1127.enhancement | 1 +
front/src/components/About.vue | 7 ++++++-
front/src/components/Home.vue | 2 +-
front/src/components/library/Home.vue | 2 +-
front/src/views/admin/moderation/ReportsList.vue | 2 +-
front/src/views/admin/moderation/RequestsList.vue | 2 +-
6 files changed, 11 insertions(+), 5 deletions(-)
create mode 100644 changes/changelog.d/1127.enhancement
diff --git a/changes/changelog.d/1127.enhancement b/changes/changelog.d/1127.enhancement
new file mode 100644
index 000000000..415b97b33
--- /dev/null
+++ b/changes/changelog.d/1127.enhancement
@@ -0,0 +1 @@
+Improved naming of pages for accessibility (#1127)
\ No newline at end of file
diff --git a/front/src/components/About.vue b/front/src/components/About.vue
index 8dac106de..2c019918f 100644
--- a/front/src/components/About.vue
+++ b/front/src/components/About.vue
@@ -1,5 +1,5 @@
<template>
- <main class="main pusher page-about">
+ <main class="main pusher page-about" v-title="labels.title">
<section :class="['ui', 'head', {'with-background': banner}, 'vertical', 'center', 'aligned', 'stripe', 'segment']" :style="headerStyle">
<div class="segment-content">
<h1 class="ui center aligned large header">
@@ -216,6 +216,11 @@ export default {
...mapState({
nodeinfo: state => state.instance.nodeinfo,
}),
+ labels() {
+ return {
+ title: this.$pgettext('Head/About/Title', "About")
+ }
+ },
podName() {
return _.get(this.nodeinfo, 'metadata.nodeName') || "Funkwhale"
},
diff --git a/front/src/components/Home.vue b/front/src/components/Home.vue
index a872022f1..fa72b2b79 100644
--- a/front/src/components/Home.vue
+++ b/front/src/components/Home.vue
@@ -214,7 +214,7 @@ export default {
}),
labels() {
return {
- title: this.$pgettext('Head/Home/Title', "Welcome")
+ title: this.$pgettext('Head/Home/Title', "Home")
}
},
podName() {
diff --git a/front/src/components/library/Home.vue b/front/src/components/library/Home.vue
index fd053b10d..e591d6ad4 100644
--- a/front/src/components/library/Home.vue
+++ b/front/src/components/library/Home.vue
@@ -75,7 +75,7 @@ export default {
computed: {
labels() {
return {
- title: this.$pgettext('Head/Home/Title', "Home")
+ title: this.$pgettext('Head/Home/Title', "Library")
}
}
},
diff --git a/front/src/views/admin/moderation/ReportsList.vue b/front/src/views/admin/moderation/ReportsList.vue
index 3d3ccb991..2833ac05c 100644
--- a/front/src/views/admin/moderation/ReportsList.vue
+++ b/front/src/views/admin/moderation/ReportsList.vue
@@ -1,5 +1,5 @@
<template>
- <main v-title="labels.accounts">
+ <main v-title="labels.reports">
<section class="ui vertical stripe segment">
<h2 class="ui header"><translate translate-context="*/Moderation/*/Noun">Reports</translate></h2>
<div class="ui hidden divider"></div>
diff --git a/front/src/views/admin/moderation/RequestsList.vue b/front/src/views/admin/moderation/RequestsList.vue
index 88f5eb0b9..921783246 100644
--- a/front/src/views/admin/moderation/RequestsList.vue
+++ b/front/src/views/admin/moderation/RequestsList.vue
@@ -1,5 +1,5 @@
<template>
- <main v-title="labels.accounts">
+ <main v-title="labels.reports">
<section class="ui vertical stripe segment">
<h2 class="ui header"><translate translate-context="*/Moderation/*/Noun">User Requests</translate></h2>
<div class="ui hidden divider"></div>
--
GitLab