From 03a7b80d035ce03a655580191c9243b1c77ff50a Mon Sep 17 00:00:00 2001
From: Eliot Berriot <contact@eliotberriot.com>
Date: Wed, 19 Dec 2018 16:05:45 +0100
Subject: [PATCH] Use cropped images for og:image
---
api/funkwhale_api/music/spa_views.py | 10 +++++++---
api/tests/music/test_spa_views.py | 12 +++++++++---
2 files changed, 16 insertions(+), 6 deletions(-)
diff --git a/api/funkwhale_api/music/spa_views.py b/api/funkwhale_api/music/spa_views.py
index 251c6e458..e0ba2d950 100644
--- a/api/funkwhale_api/music/spa_views.py
+++ b/api/funkwhale_api/music/spa_views.py
@@ -44,7 +44,9 @@ def library_track(request, pk):
{
"tag": "meta",
"property": "og:image",
- "content": utils.join_url(settings.FUNKWHALE_URL, obj.album.cover.url),
+ "content": utils.join_url(
+ settings.FUNKWHALE_URL, obj.album.cover.crop["400x400"].url
+ ),
}
)
@@ -108,7 +110,9 @@ def library_album(request, pk):
{
"tag": "meta",
"property": "og:image",
- "content": utils.join_url(settings.FUNKWHALE_URL, obj.cover.url),
+ "content": utils.join_url(
+ settings.FUNKWHALE_URL, obj.cover.crop["400x400"].url
+ ),
}
)
@@ -153,7 +157,7 @@ def library_artist(request, pk):
"tag": "meta",
"property": "og:image",
"content": utils.join_url(
- settings.FUNKWHALE_URL, latest_album.cover.url
+ settings.FUNKWHALE_URL, latest_album.cover.crop["400x400"].url
),
}
)
diff --git a/api/tests/music/test_spa_views.py b/api/tests/music/test_spa_views.py
index e75dbc46f..881c5a6ab 100644
--- a/api/tests/music/test_spa_views.py
+++ b/api/tests/music/test_spa_views.py
@@ -46,7 +46,9 @@ def test_library_track(spa_html, no_api_auth, client, factories, settings):
{
"tag": "meta",
"property": "og:image",
- "content": utils.join_url(settings.FUNKWHALE_URL, track.album.cover.url),
+ "content": utils.join_url(
+ settings.FUNKWHALE_URL, track.album.cover.crop["400x400"].url
+ ),
},
{
"tag": "meta",
@@ -103,7 +105,9 @@ def test_library_album(spa_html, no_api_auth, client, factories, settings):
{
"tag": "meta",
"property": "og:image",
- "content": utils.join_url(settings.FUNKWHALE_URL, album.cover.url),
+ "content": utils.join_url(
+ settings.FUNKWHALE_URL, album.cover.crop["400x400"].url
+ ),
},
{
"tag": "link",
@@ -142,7 +146,9 @@ def test_library_artist(spa_html, no_api_auth, client, factories, settings):
{
"tag": "meta",
"property": "og:image",
- "content": utils.join_url(settings.FUNKWHALE_URL, album.cover.url),
+ "content": utils.join_url(
+ settings.FUNKWHALE_URL, album.cover.crop["400x400"].url
+ ),
},
]
--
GitLab