From f73c7714c6292fce9cd4959381fc6a6913e57610 Mon Sep 17 00:00:00 2001
From: Eliot Berriot <contact@eliotberriot.com>
Date: Fri, 8 Mar 2019 09:29:43 +0100
Subject: [PATCH] Fixed a crash when federating a track with unspecified
position
---
api/funkwhale_api/music/tasks.py | 2 +-
changes/changelog.d/null-position.bugfix | 1 +
2 files changed, 2 insertions(+), 1 deletion(-)
create mode 100644 changes/changelog.d/null-position.bugfix
diff --git a/api/funkwhale_api/music/tasks.py b/api/funkwhale_api/music/tasks.py
index 76bc3897..c8fed584 100644
--- a/api/funkwhale_api/music/tasks.py
+++ b/api/funkwhale_api/music/tasks.py
@@ -273,7 +273,7 @@ def federation_audio_track_to_metadata(payload):
new_data = {
"title": payload["name"],
"album": payload["album"]["name"],
- "track_number": payload["position"],
+ "track_number": payload.get("position") or 1,
"disc_number": payload.get("disc"),
"artist": payload["artists"][0]["name"],
"album_artist": payload["album"]["artists"][0]["name"],
diff --git a/changes/changelog.d/null-position.bugfix b/changes/changelog.d/null-position.bugfix
new file mode 100644
index 00000000..a3c7b5a0
--- /dev/null
+++ b/changes/changelog.d/null-position.bugfix
@@ -0,0 +1 @@
+Fixed a crash when federating a track with unspecified position
--
GitLab