diff --git a/api/funkwhale_api/music/metadata.py b/api/funkwhale_api/music/metadata.py index 3aa643e56f4f3774b00d9aa2b2eb1905ace28fef..522c64c85d11fbbe2697b707f229485d61a8529c 100644 --- a/api/funkwhale_api/music/metadata.py +++ b/api/funkwhale_api/music/metadata.py @@ -132,7 +132,7 @@ CONF = { 'getter': get_id3_tag, 'fields': { 'track_number': { - 'field': 'TPOS', + 'field': 'TRCK', 'to_application': convert_track_number }, 'title': { diff --git a/api/tests/music/test.mp3 b/api/tests/music/test.mp3 index 35a6e5fcef6fb272010c19534995393f840eafa7..8502de71b8284e9f30a397f58401d96fc42dbb17 100644 Binary files a/api/tests/music/test.mp3 and b/api/tests/music/test.mp3 differ diff --git a/api/tests/music/test_metadata.py b/api/tests/music/test_metadata.py index bacec07fb55da8695411437e9e6b08133512d5b4..9f9c9398418aca521e0e27581d2b26b756fe2bab 100644 --- a/api/tests/music/test_metadata.py +++ b/api/tests/music/test_metadata.py @@ -43,10 +43,10 @@ def test_can_get_metadata_from_ogg_theora_file(field, value): @pytest.mark.parametrize('field,value', [ ('title', 'Bend'), - ('artist', 'Binärpilot'), + ('artist', 'Bindrpilot'), ('album', 'You Can\'t Stop Da Funk'), ('date', datetime.date(2006, 2, 7)), - ('track_number', 1), + ('track_number', 2), ('musicbrainz_albumid', uuid.UUID('ce40cdb1-a562-4fd8-a269-9269f98d4124')), ('musicbrainz_recordingid', uuid.UUID('f269d497-1cc0-4ae4-a0c4-157ec7d73fcb')), ('musicbrainz_artistid', uuid.UUID('9c6bddde-6228-4d9f-ad0d-03f6fcb19e13')), diff --git a/changes/changelog.d/220.bugfix b/changes/changelog.d/220.bugfix new file mode 100644 index 0000000000000000000000000000000000000000..1913df1bdf93bf96f3ce8196f80c5ea6903c41a7 --- /dev/null +++ b/changes/changelog.d/220.bugfix @@ -0,0 +1 @@ +Read ID3Tag Tracknumber from TRCK (#220)