From c53f03c4a5d374de67337f1c8cfbb72b94e38ae1 Mon Sep 17 00:00:00 2001
From: Eliot Berriot <contact@eliotberriot.com>
Date: Fri, 27 Jul 2018 19:05:10 +0200
Subject: [PATCH] Fix #457: Fixed crash on artist pages when no cover is
available
---
changes/changelog.d/457.bugfix | 1 +
front/src/components/library/Artist.vue | 8 ++++----
2 files changed, 5 insertions(+), 4 deletions(-)
create mode 100644 changes/changelog.d/457.bugfix
diff --git a/changes/changelog.d/457.bugfix b/changes/changelog.d/457.bugfix
new file mode 100644
index 00000000..bfd9dc96
--- /dev/null
+++ b/changes/changelog.d/457.bugfix
@@ -0,0 +1 @@
+Fixed crash on artist pages when no cover is available (#457)
diff --git a/front/src/components/library/Artist.vue b/front/src/components/library/Artist.vue
index 0f0abe1e..a507ae40 100644
--- a/front/src/components/library/Artist.vue
+++ b/front/src/components/library/Artist.vue
@@ -1,6 +1,6 @@
<template>
- <div>
- <div v-if="isLoading" class="ui vertical segment" v-title="labels.title">
+ <div v-title="labels.title">
+ <div v-if="isLoading" class="ui vertical segment">
<div :class="['ui', 'centered', 'active', 'inline', 'loader']"></div>
</div>
<template v-if="artist">
@@ -102,7 +102,7 @@ export default {
self.artist = response.data
self.isLoading = false
self.isLoadingAlbums = true
- axios.get('albums/', {params: {artist: this.id, ordering: '-release_date'}}).then((response) => {
+ axios.get('albums/', {params: {artist: self.id, ordering: '-release_date'}}).then((response) => {
let parsed = JSON.parse(JSON.stringify(response.data.results))
self.albums = parsed.map((album) => {
return backend.Album.clean(album)
@@ -158,7 +158,7 @@ export default {
})[0]
},
headerStyle () {
- if (!this.cover.original) {
+ if (!this.cover || !this.cover.original) {
return ''
}
return 'background-image: url(' + this.$store.getters['instance/absoluteUrl'](this.cover.original) + ')'
--
GitLab