1. 12 Apr, 2019 3 commits
  2. 11 Apr, 2019 5 commits
  3. 09 Apr, 2019 5 commits
  4. 08 Apr, 2019 7 commits
  5. 05 Apr, 2019 6 commits
  6. 04 Apr, 2019 4 commits
    • Agate's avatar
      Merge branch '783-migration-error' into 'develop' · 48ce87d2
      Agate authored
      Fix #783: migration issue on develop
      
      Closes #783
      
      See merge request funkwhale/funkwhale!704
      48ce87d2
    • Agate's avatar
      Merge branch '718-error-handling' into 'develop' · 47b3b1ae
      Agate authored
      Resolve "Upload problem due to a formatting error in the date tag"
      
      Closes #718, #583, #501, #252, #544 (yes, that's a lot :D)
      
      So, this MR changes the way we parse audio metadata and handle validation for this data:
      
      - There is now a strict and explicit separation between the retrieve step (extracting raw metadata value from files), and the validation step (ensure the raw metadata is actually valid, convert it to our internal types, etc.)
      - The date parsing issue from #718 should be solved (and Funkwhale should not crash anymore against invalid dates, skipping those instead)
      - We are now ready to deal with multiple artists at the metadata parsing level (cf !515). It should also be easier to exclude featuring artists now (cf #736), but it's not implemented here
      - When invalid metadata makes the import fail, we store the errors on the upload so we can display those to the user
      - Tables that list uploads in the Web UI leverage this new data to display more detailed errors and advices, as shown on the screenshot below
      
      ## Link to the detail modal
      
      ![image](/uploads/20eab969c7cb46fe68a402d8a509815d/image.png)
      
      ## Import error detail
      
      ![image](/uploads/7cebae6dd05f437345fa38340e8675c7/image.png)
      
      ![image](/uploads/946c8ae59cd89fe29e701700fbd5063f/image.png)
      
      As you can see, we display the type of errors, the failing tags and the actual error, as well as some link to the documentation, support forum and some debug info you can easily copy-paste to get help.
      
      See merge request funkwhale/funkwhale!703
      47b3b1ae
    • Agate's avatar
    • Agate's avatar
      Fix #783: migration issue on develop · 63c3c225
      Agate authored
      63c3c225
  7. 27 Mar, 2019 10 commits